use only data target to query elements in our pluginfeat/data-target

1 files changed, 13 insertions, 1 deletions

diff --git a/js/src/scrollspy.js b/js/src/scrollspy.js
index 90e03b000..ff80de767 100644
--- a/js/src/scrollspy.js
+++ b/js/src/scrollspy.js
@@ -121,7 +121,7 @@ class ScrollSpy {
     targets
       .map(element => {
         let target
-        const targetSelector = getSelectorFromElement(element)
+        const targetSelector = this._getSelectorFromElement(element)
 
         if (targetSelector) {
           target = SelectorEngine.findOne(targetSelector)
@@ -163,6 +163,18 @@ class ScrollSpy {
 
   // Private
 
+  _getSelectorFromElement(element) {
+    let selector = getSelectorFromElement(element)
+
+    if (!selector) {
+      const hrefAttr = element.getAttribute('href')
+
+      selector = hrefAttr && hrefAttr !== '#' ? hrefAttr.trim() : null
+    }
+
+    return selector
+  }
+
   _getConfig(config) {
     config = {
       ...Default,