| Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
as role="menu" is a very specific (and strict) ARIA pattern for
desktop-like application menus, and our dropdowns are often used
as pure navigation dropdowns, this change abandons ARIA menus for
a more open-ended and light-weight approach
(see http://heydonworks.com/practical_aria_examples/#submenus and
http://www.w3.org/WAI/tutorials/menus/flyout/#improve-screen-reader-support-using-wai-aria)
note that in dropdown.js, switched to now target ``.dropdown-menu``
instead of ``role["menu"]`` - this also prevents bootstrap scripts
from "bleeding" into non-bootstrap components on the same page.
also removed the ``role=["listbox"]`` part, which appears to be
vestigial/unused (only place in bootstrap that uses that
role are carousels, and their key handling is done separately)
|
|
http://www.w3.org/TR/wai-aria/roles#separator
|
|
|
|
Normalized the heading hierarchy in the documentation for the Dropdowns component.
|
|
|
|
Condense the dropup example
|
|
data-example-id not need be moved. Only change, because data-example-id="static-dropdown" already exists.
Remove whitespace after h3.
Variation not need capitalize.
|
|
* Remove `<h3>Example</h3>;`
* Move `data-example-id=""` to `<h3>Dropup Variation</h3>` and change value;
|
|
Fix issue #15597 — Mention dropup variation in dropdown docs
Other pull request was so messed up I sincerely have no clue how to save it. The recommended command doesn't work, can't believe rebasing is so problematic...
|
|
Remove "Separated link" in example where it's not
|
|
Removed "Separated link" in example where it's not separated. This may confuse people to think that it is separated.
I don't want to sound nitpick, but I've been working with a client maintaining a custom internal Bootstrap installation with customized docs, so I've been getting a lot of feedback from client developers using the docs.
|
|
Refs #11410
|
|
[skip sauce]
|
|
Closes #14951 by merging it.
|
|
|
|
|
|
|
|
possibly less confusing option, as per discussion, is to always show the
dropdown trigger button (both live and in that code example)
|
|
Assuming sr-only is used in the actual live code so that the menu can be
shown open already ... but having sr-only in the highlighted example
code itself is confusing/misleading.
Also, change the text for the button from "Dropdown" to "Dropdown
trigger" for clarity (and it then matches
http://getbootstrap.com/javascript/#dropdowns)
|
|
|