| Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
* unicorn/prefer-dom-node-append
* unicorn/prefer-dom-node-remove
|
|
|
|
* test(carousel): add test to check if next/prev button work as intended
* fix(carousel): merge passed config with instance config in carouselInterface
|
|
Co-authored-by: Rohit Sharma <[email protected]>
Co-authored-by: XhmikosR <[email protected]>
|
|
* Remove potential false positive assertions
querySelector() returns null but
expect(document.querySelector('...')).toBeDefined()
tests that the value is not undefined
* Migrated assertions from .toBeDefined() to .not.toBeNull() for .getInstance() calls in tests
* Migrate offcanvas assertions from .toBeDefined() to .not.toBeNull() for .getInstance() call
* convert more cases to not.toBeNull assertions
Co-authored-by: XhmikosR <[email protected]>
|
|
|
|
* move common code to reusable functions
* add/re-factor tests, directionToOrder func
* add _orderToDirection tests
Co-authored-by: XhmikosR <[email protected]>
|
|
Co-authored-by: XhmikosR <[email protected]>
Co-authored-by: Mark Otto <[email protected]>
|
|
Co-authored-by: XhmikosR <[email protected]>
|
|
|
|
* Fix event handler removal in carousel dispose
* Fix event handler removal in dropdown dispose
* Test event handlers in scrollspy dispose
* Test event handlers in toast dispose
* Test event handlers in tooltip dispose
Co-authored-by: XhmikosR <[email protected]>
Co-authored-by: Rohit Sharma <[email protected]>
|
|
|
|
* Carousel: use buttons, not links, for prev/next
- expand the styles to neutralise border/background
- change docs page
- add extra unit test to check that links or buttons work as controls
- modify visual test to use buttons as well
- use buttons instead of links for prev/next
- remove `role="button"` from links that are actually links
* Clarify that controls can be button or link
* Update site/content/docs/5.0/components/carousel.md
Co-authored-by: Mark Otto <[email protected]>
* Explicitly set padding to 0 to prevent dipping/moving on active in Firefox
Co-authored-by: XhmikosR <[email protected]>
|
|
* Change from Error to TypeError
* Convert the `NAME` to upper case to make the consistency in the error message
* Update the remaining tests to be stricter
Co-authored-by: XhmikosR <[email protected]>
|
|
|
|
|
|
|
|
- Add `bs` in data APIs everywhere
- Update unit tests
|
|
* check for data-interval on the first slide of carousel
* add updateInterval method for elements of a carousel
* add test for carousel interval being set during cycle
* update activeElement as soon as slide has finished (before transition end)
* only updateInterval before using it
Co-authored-by: XhmikosR <[email protected]>
|
|
|
|
|
|
|
|
|