| Age | Commit message (Collapse) | Author | Files | Lines |
|
Fix handling of transitionend events dispatched by nested elements
Properly handle events from nested elements
Change `emulateTransitionEnd` to `executeAfterTransition` &&
|
|
The current config can cause the "body" to become stale. Specifically,
if the entire body element is swapped out for a new body element, then
the backdrop will continue to append itself to the original body element,
since it's stored in memory as a reference on this object.
This also no longer allows an explicit null to be passed to Backdrop's rootElement
This still accomplishes the laziness of "not finding the rootElement
until the Backdrop is created" to avoid problems of the JavaScript
being included inside <head> (so, before body is available).
|
|
displayed again (#34085)
Fix modal, in case is faded, a prevented show event can cause show method to not be executed again.
|
|
|
|
Fixes regression of https://github.com/twbs/bootstrap/commit/a2b5901efc6de12bb828f8dda118ddccbcd545cf breaking the test runner because it would wipe document.body.
|
|
the body (#34014)
Co-authored-by: Rohit Sharma <[email protected]>
|
|
alternate means (#33960)
|
|
exists (#33948)
* scrollbar.js:
add some tests
transfer test from modal.spec. to scrollbar.spec
proper handling if style property doesn't exist
|
|
jQueryInterface, when component does not exists. (#33371)
|
|
implementation through components (#33608)
|
|
|
|
* Remove content holder when there is no content
* Add tests to check the removal of header/content
Co-authored-by: XhmikosR <[email protected]>
|
|
Looking around on js components I found out many checks, different expressed but with same purpose.
Some of them are trying to parse string to element, others, jQuery element to js simple nodeElement etc
With this Pr, I am trying to give a standard way to parse an element
So this pr:
* Creates `getElement` helper that tries to parse an argument to element or null
* Changes `isElement` to make explicit checks and return Boolean
* fixes tests deficiencies
|
|
|
|
Co-authored-by: XhmikosR <[email protected]>
|
|
Co-authored-by: XhmikosR <[email protected]>
|
|
* Force each plugin that extends base-components to implement a static method `NAME()`
* Remove redundant `NAME` argument from 'Utils.defineJQueryPlugin' & fix test
|
|
(#33920)
* test: add test if user clicks on input not contained within dropdown-menu
* fix: click on inputs that are not contained within dropdown-menu prevent dropdown from closing
|
|
* Remove potential false positive assertions
querySelector() returns null but
expect(document.querySelector('...')).toBeDefined()
tests that the value is not undefined
* Migrated assertions from .toBeDefined() to .not.toBeNull() for .getInstance() calls in tests
* Migrate offcanvas assertions from .toBeDefined() to .not.toBeNull() for .getInstance() call
* convert more cases to not.toBeNull assertions
Co-authored-by: XhmikosR <[email protected]>
|
|
|
|
* Initialize default value of rootElement before using
* Remove redundant test | put rootElement tests together
Co-authored-by: GeoSot <[email protected]>
|
|
* add method to handle overflow on body element & tests
* replace duplicated code on modal/offcanvas tests
|
|
|
|
Co-authored-by: XhmikosR <[email protected]>
|
|
(#33677)
|
|
* use prevent default only if triggered by anchor
* disable auto-initialization if trigger is disabled
|
|
|
|
#33310 (#33679)
* test: update spec for sibling adjacent mouseenter/mouseleave events
there is a regression introduced by #33310 - this would have catched that
* fix: fixup regression for mouseenter/mouseleave events introduced by #33310
the old logic only worked for parent-child movement since it checked for the relatedTarget to contain the delegateTarget - this should be fixed with this
Co-authored-by: XhmikosR <[email protected]>
|
|
* respect /share modal's backdrop functionality, keeping consistency
* listen click events over backdrop (only) and trigger `hide()` without add/remove event tricks
* achieve to hide foreign open offcanvas instances without glitches `if (allReadyOpen && allReadyOpen !== target)`, in case another is going to be open, when user clicks on trigger button
|
|
Co-authored-by: XhmikosR <[email protected]>
|
|
Scope selector to `dropdownElement` when adding active classes
|
|
* Create backdrop.js util
* revert breaking changes
remove PromiseTimout usage
revert class name
* one more test | change bundlewatch.config
* add config obj to backdrop helper | tests for rootElement | use transitionend helper
* Minor tweaks — Renaming
Co-authored-by: Rohit Sharma <[email protected]>
|
|
|
|
* fix: make EventHandler better handle mouseenter/mouseleave events
* refactor: simplify custom events regex and move it to a variable
|
|
|
|
|
|
|
|
Since the value for the `backdrop` option is available in the configuration object.
|
|
|
|
|
|
|
|
* Update `aria-expanded` attribute in `hide` method
* Remove empty mouseover listeners added for iOS
|
|
|
|
* remove stopPropagation from button click event
* test for delegated click events
* ensure button children can open menu
* test to ensure clicking button opens the menu
* check current element and parents
* allow dropdown form click events to bubble
|
|
* Update docs to use new .show behavior and clarify some copy for first example
Co-authored-by: Mark Otto <[email protected]>
Co-authored-by: XhmikosR <[email protected]>
|
|
|
|
|
|
|
|
* show() should bail if the trigger has `disabled` attribute
* use 'isDisabled' helper
Co-authored-by: GeoSot <[email protected]>
Co-authored-by: XhmikosR <[email protected]>
|
|
* move common code to reusable functions
* add/re-factor tests, directionToOrder func
* add _orderToDirection tests
Co-authored-by: XhmikosR <[email protected]>
|