aboutsummaryrefslogtreecommitdiff
path: root/js
AgeCommit message (Collapse)AuthorFilesLines
2021-03-10@rollup/plugin-replace: specify `preventAssignment: true` (#33329)XhmikosR2-2/+4
This is to fix a warning since the option will be set to true in the next major version of the plugin
2021-03-08modal: move common code to a new `isAnimated` method (#33056)GeoSot1-16/+17
2021-03-02Offcanvas as component (#29017)GeoSot6-0/+819
* Add a new offcanvas component * offcanvas.js: switch to string constants and `event.key` * Remove unneeded code * Sass optimizations * Fixes Make sure the element is hidden and not offscreen when inactive fix close icon negative margins Add content in right & bottom examples Re-fix bottom offcanvas height not to cover all viewport * Wording tweaks * update tests and offcanvas class * separate scrollbar functionality and use it in offcanvas * Update .bundlewatch.config.json * fix focus * update btn-close / fix focus on close * add aria-modal and role return focus on trigger when offcanvas is closed change body scrolling timings * move common code to reusable functions * add aria-labelledby * Replace lorem ipsum text * fix focus when offcanvas is closed * updates * revert modal, add tests for scrollbar * show backdrop by default * Update offcanvas.md * Update offcanvas CSS to better match modals - Add background-clip for borders - Move from outline to border (less clever, more consistent) - Add scss-docs in vars * Revamp offcanvas docs - Add static example to show and explain the components - Split live examples and rename them - Simplify example content - Expand docs notes elsewhere - Add sass docs * Add .offcanvas-title instead of .modal-title * Rename offcanvas example to offcanvas-navbar to reflect it's purpose * labelledby references title and not header * Add default shadow to offcanvas * enable offcanvas-body to fill all the remaining wrapper area * Be more descriptive, on Accessibility area * remove redundant classes * ensure in case of an already open offcanvas, not to open another one * bring back backdrop|scroll combinations * bring back toggling class * refactor scrollbar method, plus tests * add check if element is not full-width, according to #30621 * revert all in modal * use documentElement innerWidth * Rename classes to -start and -end Also copyedit some docs wording * omit some things on scrollbar * PASS BrowserStack tests -- IOS devices, Android devices and Browsers on Mac, hide scrollbar by default and appear it, only while scrolling. * Rename '_handleClosing' to '_addEventListeners' * change pipe usage to comma * change Data.getData to Data.get Co-authored-by: XhmikosR <[email protected]> Co-authored-by: Martijn Cuppens <[email protected]> Co-authored-by: Mark Otto <[email protected]>
2021-03-02Dropdown — Drop `flip` option (#33198)Rohit Sharma1-3/+0
2021-03-02refactor: use a Map instead of an Object in dom/data (#32180)alpadev14-160/+125
Co-authored-by: XhmikosR <[email protected]> Co-authored-by: Rohit Sharma <[email protected]>
2021-02-23modal: don't add margin & padding when sticky is not full width (#30621)Muhammadamin2-0/+28
* modal: don't add margin & padding when sticky is not full width * Check if element is shorter than window Co-authored-by: XhmikosR <[email protected]> Co-authored-by: Rohit Sharma <[email protected]>
2021-02-22Allow constructors to accept a CSS selector (#32245)Rohit Sharma14-6/+131
Co-authored-by: XhmikosR <[email protected]> Co-authored-by: Mark Otto <[email protected]>
2021-02-22visual tests: add missing base-component dist file (#33167)XhmikosR11-0/+11
Regression of #32313
2021-02-21Fix small typos / follow-up to #32630 (#33164)Patrick H. Lauke1-1/+1
2021-02-19Adjust regex `SAFE_URL_PATTERN` for use with test method of regexes. (#33136)Nikon the Third2-1/+11
The test method on regexes behaves different than the match method on strings in the presence of the global modifier. Add a unit test for sanitizing the same template twice. Co-authored-by: XhmikosR <[email protected]>
2021-02-18add some spacenlipka1-0/+1
2021-02-16Simplify karma.conf.js (#33045)XhmikosR1-10/+6
`customLaunchers` does not seem to be needed.
2021-02-16util: change `isRTL` to a function (#32446)XhmikosR5-19/+17
This allows the bundler to tree-shake the function.
2021-02-16Add tests for `DATA_KEY` (#33090)GeoSot8-0/+48
Co-authored-by: XhmikosR <[email protected]>
2021-02-12Add the missing expectations for touch events (#33060)Rohit Sharma1-2/+10
2021-02-12Fix event handler removal in dropdown/carousel dispose (#33000)Kyle Tsang7-7/+54
* Fix event handler removal in carousel dispose * Fix event handler removal in dropdown dispose * Test event handlers in scrollspy dispose * Test event handlers in toast dispose * Test event handlers in tooltip dispose Co-authored-by: XhmikosR <[email protected]> Co-authored-by: Rohit Sharma <[email protected]>
2021-02-11Revert dist changes from #32747 (#33050)Mark Otto23-31/+141
2021-02-10Add Sass docs (variables, mixins, and loops) to most pages (#32747)Mark Otto23-141/+31
* WIP: Mention variables, mixins, and loops in docs * Add Sass sections to component pages * add sass docs for forms and content * Update buttons.md * Remove empty mixins sections * Massive update to utilities and some consistency changes Co-authored-by: XhmikosR <[email protected]>
2021-02-10Release v5.0.0-beta2 (#32467)v5.0.0-beta2XhmikosR52-1055/+1318
* Bump version to 5.0.0-beta2 * Dist
2021-02-09Add function type for `popperConfig` option (#32882)Rohit Sharma4-9/+46
* Add function type for `popperConfig` option * Update .bundlewatch.config.json * copy edits Co-authored-by: XhmikosR <[email protected]> Co-authored-by: Mark Otto <[email protected]>
2021-02-09Dropdown — Change the selector to check the use of Popper (#33003)Rohit Sharma1-2/+2
* Create the popper instance first Make sure that popper instance has been created first and then apply the styling on the dropdown(menu) * Use `data-bs-popper` attibute to check popper Co-authored-by: XhmikosR <[email protected]>
2021-02-09Remove .dropdown-menu[style] reset and adjust .dropdown-menu-* modifiersMark Otto2-3/+72
- Removes the &[style] selector that was used for resetting Popper styles - Separate Popper-based alignment from static alignment with `data-bs-popover` attribute that separates the --bs-position and custom right/left properties Co-Authored-By: Rohit Sharma <[email protected]>
2021-02-09Remove custom `fallbackPlacements` from dropdown (#32843)Rohit Sharma1-6/+0
2021-02-09Dynamic tabs: use buttons rather than links (#32630)Patrick H. Lauke2-85/+106
* Dynamic tabs: use buttons rather than links - change docs - add mention that tabs should be <button> elements - tweak styles to neutralise border and background * Update js unit and visual test accordingly - replace links with buttons - make one specific test that uses links instead of buttons, as we still want to support it despite it being non-semantically appropriate - Leaving a couple of tests for now. The test for removed tabs should be redone so that tabs are removed programmatically (as the approach of having that close button inside the link is invalid and broken markup). The test for dropdowns should be removed together we actually ripping out the handling for dropdowns in the tab.js code (arguably a breaking change, though we discouraged this for a few versions and effectively "deprecated" it) * Add isolation:isolate to prevent focus being overlapped https://github.com/twbs/bootstrap/pull/32630#issuecomment-756015766
2021-02-04Fix Popper preventOverflow boundary config (#32845)Kyle Tsang2-2/+2
Currently, the boundary config is being assigned to the wrong var (`rootBoundary`) in the popper config. It should be assigned to the `boundary` var in popper's config. Ref: https://popper.js.org/docs/v2/utils/detect-overflow/#boundary
2021-02-03Fix dropdown keys to open menu (#32750)Siju Samson2-0/+54
Co-authored-by: XhmikosR <[email protected]>
2021-02-03Prevent `getSelector` from returning URLs as selector (#32586)Florian Vick2-1/+36
* added checks to getSelector in util to prevent returning hrefs that are invalid selectors * restored compatibility for the class selector and added test cases for keeping urls from being returned as a selector Co-authored-by: XhmikosR <[email protected]>
2021-02-03Dropdown — Emit events on the `.dropdown-toggle` button (#32625)Rohit Sharma2-110/+104
* Emit events on the dropdown button Emit the events on `.dropdown-toggle` button and then bubble up * Add migration note for events * Update the docs for events * Add unit test to check the event bubbling Co-authored-by: XhmikosR <[email protected]>
2021-02-03Remove the initial margin from dropdown/popover in favor of Popper (#32524)Rohit Sharma2-1/+2
* Remove the margin from dropdown in favor of Popper - Set the default margin to 0 for dropdowns (To remove the Popper's warning) - Set the required offset in dropdown's defaults * Remove the margin from the popover component Co-authored-by: XhmikosR <[email protected]>
2021-01-28Just find the active indicatorRohit Sharma1-5/+3
2021-01-28Make carousel indicators actual buttonsPatrick H. Lauke4-23/+31
2021-01-28Restore `offset` option for tooltip/popover componentsRohit Sharma2-0/+57
2021-01-28Restore offset option for dropdown componentjoke2k2-2/+70
2021-01-28Minor ESLint rules cleanup (#32904)XhmikosR1-11/+3
2021-01-27Tooltip refactoring (#32523)GeoSot1-84/+74
* tooltip: move common code to a reusable function * tooltip: return early in `show()` Co-authored-by: Rohit Sharma <[email protected]> Co-authored-by: XhmikosR <[email protected]>
2021-01-27Carousel: use buttons, not links, for prev/next controls (#32627)Patrick H. Lauke2-11/+35
* Carousel: use buttons, not links, for prev/next - expand the styles to neutralise border/background - change docs page - add extra unit test to check that links or buttons work as controls - modify visual test to use buttons as well - use buttons instead of links for prev/next - remove `role="button"` from links that are actually links * Clarify that controls can be button or link * Update site/content/docs/5.0/components/carousel.md Co-authored-by: Mark Otto <[email protected]> * Explicitly set padding to 0 to prevent dipping/moving on active in Firefox Co-authored-by: XhmikosR <[email protected]>
2021-01-14modal: move common code to reusable functions (#32511)GeoSot1-52/+25
Co-authored-by: XhmikosR <[email protected]>
2021-01-14Bump eslint-plugin-unicorn from 25.0.1 to 26.0.1 (#32784)dependabot[bot]2-2/+3
* Bump eslint-plugin-unicorn from 25.0.1 to 26.0.1 Bumps [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn) from 25.0.1 to 26.0.1. - [Release notes](https://github.com/sindresorhus/eslint-plugin-unicorn/releases) - [Commits](https://github.com/sindresorhus/eslint-plugin-unicorn/compare/v25.0.1...v26.0.1) Signed-off-by: dependabot[bot] <[email protected]> * Updates for `[email protected]` Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: XhmikosR <[email protected]>
2021-01-13Throw a `TypeError` instead of the generic `Error` (#32585)Rohit Sharma12-45/+26
* Change from Error to TypeError * Convert the `NAME` to upper case to make the consistency in the error message * Update the remaining tests to be stricter Co-authored-by: XhmikosR <[email protected]>
2021-01-13Fix toggling modal when clicking on `data-bs-toggle="modal"` (#32691)Rohit Sharma2-2/+11
Co-authored-by: XhmikosR <[email protected]>
2021-01-13JS: update karma config (#32769)XhmikosR1-16/+18
* rename constants * enforce the constants to be Boolean * fix karma `logLevel`
2021-01-08Move "active" class from `.nav-item` to `.nav-link` (#32730)Théophile Helleboid - chtitux3-6/+6
2021-01-07Scrollspy - Remove unnecessary event argument (#32603)Rohit Sharma1-1/+1
Co-authored-by: XhmikosR <[email protected]>
2020-12-21collapse: prevent url change if `A` nested tag is clicked (#32438)Daniele Faraglia2-1/+24
Co-authored-by: XhmikosR <[email protected]>
2020-12-21Support Popper virtual elements (#32376)Nils K2-1/+62
Adds the ability to use objects implementing the virtual element interface as the value for the reference option of a dropdown config. Co-authored-by: XhmikosR <[email protected]>
2020-12-18test(carousel): french word in the wild (#32528)Gaël Poupard1-1/+1
2020-12-18Bump eslint-plugin-unicorn from 23.0.0 to 24.0.0 (#32516)dependabot[bot]1-1/+1
* Bump eslint-plugin-unicorn from 23.0.0 to 24.0.0 Bumps [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn) from 23.0.0 to 24.0.0. - [Release notes](https://github.com/sindresorhus/eslint-plugin-unicorn/releases) - [Commits](https://github.com/sindresorhus/eslint-plugin-unicorn/compare/v23.0.0...v24.0.0) Signed-off-by: dependabot[bot] <[email protected]> * Update karma.conf.js Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: XhmikosR <[email protected]>
2020-12-16tests: replace deprecated jQuery method (#32309)Rohit Sharma1-1/+1
Co-authored-by: XhmikosR <[email protected]>
2020-12-16BrowserStack: test on macOS Catalina instead of High Sierra (#32486)XhmikosR1-3/+3
2020-12-14Tooltip/popover - change the default value for `fallbackPlacements` (#32437)Rohit Sharma1-15/+9
The default Popper `fallbackPlacements` value is `[oppositePlacement]`. - The default value was previously (in v4) `'flip'` that can be achieved by passing the single value in the array, like — `[oppositePlacement]`. Keeping `null` also sets the `fallbackPlacements` to `[oppositePlacement]` (Default value in Popper) - It's better to have **clockwise** (`['top', 'right', 'bottom', 'left']`) fallback options so that tooltip/popover can be placed to another side even if the opposite placement doesn't fit. Co-authored-by: XhmikosR <[email protected]>