aboutsummaryrefslogtreecommitdiff
path: root/js
AgeCommit message (Collapse)AuthorFilesLines
2021-06-25restrict changes only to backdrop.js, add testGeoSot4-65/+65
2021-06-25Variabilize backdrop class name (#34094)Romain4-16/+35
2021-06-22ScrollSpy: Make Proper use of the SelectorEngineGeoSot2-36/+8
* avoid extra work, creating ids * simplify selectors and constrain search inside `config.target`
2021-06-22Release v5.0.2 (#34276)v5.0.2XhmikosR57-486/+681
* Bump version to v5.0.2. * Dist
2021-06-22Register only one `DOMContentLoaded` event listener in `onDOMContentLoaded` ↵alpadev2-3/+21
(#34158) * refactor: reuse one DOMContentLoaded event listener in onDOMContentLoaded function Instead of adding an event listener everytime the utility function is called, cache the callbacks and execute them all at once. * refactor: drop iife for onDOMContentLoaded Co-authored-by: XhmikosR <[email protected]>
2021-06-22fix(carousel): arrow keys break animation if carousel sliding (#34307)alpadev2-15/+81
2021-06-16Fix carousel buttons (#34266)alpadev2-1/+36
* test(carousel): add test to check if next/prev button work as intended * fix(carousel): merge passed config with instance config in carouselInterface
2021-06-06Refactor scrollbar.js to be used as a Class (#33947)GeoSot6-112/+135
2021-06-03Add `getOrCreateInstance` method in base-component (#33276)GeoSot26-118/+602
Co-authored-by: Rohit Sharma <[email protected]> Co-authored-by: XhmikosR <[email protected]>
2021-06-03Fix handling of transitionend events dispatched by nested elements(#33845)alpadev7-87/+200
Fix handling of transitionend events dispatched by nested elements Properly handle events from nested elements Change `emulateTransitionEnd` to `executeAfterTransition` &&
2021-05-31Changing Backdrop rootElement to default to a string (#34092)Ryan Weaver2-6/+7
The current config can cause the "body" to become stale. Specifically, if the entire body element is swapped out for a new body element, then the backdrop will continue to append itself to the original body element, since it's stored in memory as a reference on this object. This also no longer allows an explicit null to be passed to Backdrop's rootElement This still accomplishes the laziness of "not finding the rootElement until the Backdrop is created" to avoid problems of the JavaScript being included inside <head> (so, before body is available).
2021-05-25Change `element.parentNode.removeChild(element)` to `element.remove()` (#34071)GeoSot5-15/+9
2021-05-24Fix prevented show event disables modals with fade class from being ↵alpadev2-6/+35
displayed again (#34085) Fix modal, in case is faded, a prevented show event can cause show method to not be executed again.
2021-05-22Automatically select an item in the dropdown when using arrow keys (#34052)alpadev4-22/+57
2021-05-22fix test of #34014 (#34070)GeoSot1-14/+16
Fixes regression of https://github.com/twbs/bootstrap/commit/a2b5901efc6de12bb828f8dda118ddccbcd545cf breaking the test runner because it would wipe document.body.
2021-05-22Fix bug where backdrop calls method on null if it is already removed from ↵Ryan Weaver2-1/+24
the body (#34014) Co-authored-by: Rohit Sharma <[email protected]>
2021-05-20Refactor `isVisible` helper, fixing false positives from deep nesting or ↵Ryan Berliner2-13/+52
alternate means (#33960)
2021-05-20Add Tests on scrollbar.js & better handling if a style property doesn't ↵GeoSot3-245/+127
exists (#33948) * scrollbar.js: add some tests transfer test from modal.spec. to scrollbar.spec proper handling if style property doesn't exist
2021-05-20Allow use of `dispose/hide` methods on Tooltip & Popover from ↵GeoSot4-38/+0
jQueryInterface, when component does not exists. (#33371)
2021-05-19Add `getNextActiveElement` helper function to utils, replacing custom ↵GeoSot4-31/+76
implementation through components (#33608)
2021-05-18Reset inside a Dialog does not work if `data-dismiss="modal"` is set (#33928)GeoSot2-1/+55
2021-05-18Don't add empty content holder when there is no content available (#33982)Rohit Sharma2-1/+59
* Remove content holder when there is no content * Add tests to check the removal of header/content Co-authored-by: XhmikosR <[email protected]>
2021-05-13Release v5.0.1 (#33972)v5.0.1XhmikosR57-755/+545
* Bump version to 5.0.1. * Dist
2021-05-13Move get element functionality to a helper (#33327)GeoSot8-49/+85
Looking around on js components I found out many checks, different expressed but with same purpose. Some of them are trying to parse string to element, others, jQuery element to js simple nodeElement etc With this Pr, I am trying to give a standard way to parse an element So this pr: * Creates `getElement` helper that tries to parse an argument to element or null * Changes `isElement` to make explicit checks and return Boolean * fixes tests deficiencies
2021-05-12Popover/Tooltip: streamline config property to start with underscore (#33381)GeoSot3-41/+41
2021-05-11Fix test warning for dropdown, without expectations (#33938)GeoSot1-0/+1
Co-authored-by: XhmikosR <[email protected]>
2021-05-11Fix offcanvas test to expect the initial body `overflow` value (#33927)GeoSot1-1/+2
Co-authored-by: XhmikosR <[email protected]>
2021-05-11Extract static `DATA_KEY` & `EVENT_KEY` to base-component (#33635)GeoSot16-53/+167
* Force each plugin that extends base-components to implement a static method `NAME()` * Remove redundant `NAME` argument from 'Utils.defineJQueryPlugin' & fix test
2021-05-11Fix: Click on input outside of dropdown-menu prevents dropdown from closing ↵alpadev2-12/+32
(#33920) * test: add test if user clicks on input not contained within dropdown-menu * fix: click on inputs that are not contained within dropdown-menu prevent dropdown from closing
2021-05-11Refactor: move disposing properties into the base class (#33740)GeoSot9-52/+6
Moves more functionality to `base-component`, transferring the responsibility of disposal to parent class. Each component, dusting disposal, sets its protected properties to `null`. So the same can be done in one place for all children components .
2021-05-11Remove potential false positive assertions (#33288)Ben Lertlumprasertkul13-67/+67
* Remove potential false positive assertions querySelector() returns null but expect(document.querySelector('...')).toBeDefined() tests that the value is not undefined * Migrated assertions from .toBeDefined() to .not.toBeNull() for .getInstance() calls in tests * Migrate offcanvas assertions from .toBeDefined() to .not.toBeNull() for .getInstance() call * convert more cases to not.toBeNull assertions Co-authored-by: XhmikosR <[email protected]>
2021-05-11Prevent toast autohiding if focusing or hovering (#33221)Ryan Berliner2-6/+229
2021-05-10Merge js-components 'transitionend' listener callbacks into one methodGeoSot9-107/+47
2021-05-10Fix backdrop `rootElement` not initialized in Modal (#33853)Nagarjun Bodduna2-29/+45
* Initialize default value of rootElement before using * Remove redundant test | put rootElement tests together Co-authored-by: GeoSot <[email protected]>
2021-05-05Release v5.0.0 (#33647)v5.0.0XhmikosR57-466/+754
* Bump version to 5.0.0 * Fix npm tag * Dist
2021-04-25Scrollbar: respect the initial body overflow value (#33706)GeoSot5-26/+113
* add method to handle overflow on body element & tests * replace duplicated code on modal/offcanvas tests
2021-04-25Add missing test for clicking select option in a dropdown (#33734)alpadev1-0/+41
2021-04-21Dropdown: support `.dropdown-item` wrapped in `<li>` tags (#33634)Carson Sievert2-1/+28
Co-authored-by: XhmikosR <[email protected]>
2021-04-20Offcanvas.js: If scroll is allowed, should allow focus on other elements ↵GeoSot2-1/+35
(#33677)
2021-04-20Tab.js: Fixes on click handling (#33586)GeoSot2-55/+77
* use prevent default only if triggered by anchor * disable auto-initialization if trigger is disabled
2021-04-20Dropdown — Add option to make the dropdown menu clickable (#33389)Rohit Sharma2-11/+110
2021-04-19Don't change the value for `altBoundary` option (#33684)Rohit Sharma1-1/+0
- Since bootstrap is not changing the default value of `elementContext` option, changing the value of `altBoundary` option is not needed for any modifier in real Co-authored-by: XhmikosR <[email protected]>
2021-04-19Fix regression for handling `mouseenter`/`mouseleave` events introduced by ↵alpadev2-2/+16
#33310 (#33679) * test: update spec for sibling adjacent mouseenter/mouseleave events there is a regression introduced by #33310 - this would have catched that * fix: fixup regression for mouseenter/mouseleave events introduced by #33310 the old logic only worked for parent-child movement since it checked for the relatedTarget to contain the delegateTarget - this should be fixed with this Co-authored-by: XhmikosR <[email protected]>
2021-04-19Use the backdrop util in offcanvas, enforcing consistency (#33545)GeoSot4-36/+163
* respect /share modal's backdrop functionality, keeping consistency * listen click events over backdrop (only) and trigger `hide()` without add/remove event tricks * achieve to hide foreign open offcanvas instances without glitches `if (allReadyOpen && allReadyOpen !== target)`, in case another is going to be open, when user clicks on trigger button
2021-04-18modal.js: fix test for scrollbar (#33666)GeoSot1-4/+6
Co-authored-by: XhmikosR <[email protected]>
2021-04-18fix: clicking an item in navbar dropdown collapses the dropdown in firefox ↵alpadev1-1/+1
(#33643)
2021-04-18Change `toggle` method to `remove`Rohit Sharma1-2/+2
Since the class `.show` must be removed
2021-04-18Use context propertiesRohit Sharma1-4/+3
2021-04-18Refactor dropdown's hide functionalityRohit Sharma1-50/+33
2021-04-15Fix v5 regressions in tab dropdown functionality (#33626)Carson Sievert2-1/+36
Scope selector to `dropdownElement` when adding active classes