From b9c4a5cde2f1791624633e9023cab28d1d4edab9 Mon Sep 17 00:00:00 2001 From: Johann-S Date: Wed, 4 Oct 2017 15:24:10 +0200 Subject: Fix dropup in bottom navbar for all the breakpoints --- scss/_navbar.scss | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/scss/_navbar.scss b/scss/_navbar.scss index a0ccc06fb..6b023e82e 100644 --- a/scss/_navbar.scss +++ b/scss/_navbar.scss @@ -74,13 +74,6 @@ position: static; float: none; } - - .dropdown-toggle { - &::after { - border-top: $caret-width solid; - border-bottom: 0; - } - } } @@ -151,18 +144,6 @@ padding-right: 0; padding-left: 0; } - - .dropup { - .dropdown-menu { - position: absolute; - top: auto; - bottom: 100%; - } - - .dropdown-toggle { - @include caret(up); - } - } } @include media-breakpoint-up($next) { @@ -203,6 +184,13 @@ .navbar-toggler { display: none; } + + .dropup { + .dropdown-menu { + top: auto; + bottom: 100%; + } + } } } } -- cgit v1.2.3 From 347b3ac1c01ee9996daf542fb816a7dc34923d8a Mon Sep 17 00:00:00 2001 From: Johann-S Date: Wed, 4 Oct 2017 16:31:35 +0200 Subject: Remove global jQuery in eslint because we import jQuery (#24246) --- js/.eslintrc.json | 3 +-- js/tests/.eslintrc.json | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/js/.eslintrc.json b/js/.eslintrc.json index 7316e6f22..fc5f6a491 100644 --- a/js/.eslintrc.json +++ b/js/.eslintrc.json @@ -3,8 +3,7 @@ "parser": "babel-eslint", "env": { "browser": true, - "es6": true, - "jquery": true + "es6": true }, "extends": "eslint:recommended", "plugins": ["compat"], diff --git a/js/tests/.eslintrc.json b/js/tests/.eslintrc.json index 460286508..1452045e2 100644 --- a/js/tests/.eslintrc.json +++ b/js/tests/.eslintrc.json @@ -1,7 +1,8 @@ { "env": { "es6": false, - "qunit": true + "qunit": true, + "jquery": true }, "globals": { "Util": false -- cgit v1.2.3 From 19aebb420325a3901fb4db39a51c84fefe1ff5f4 Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Wed, 4 Oct 2017 19:07:47 +0300 Subject: Suggest CodePen along with JSBin. (#24238) --- .github/ISSUE_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index d9fc88e2b..98b760eca 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -14,7 +14,7 @@ When reporting a bug, include: - Operating system and version (Windows, Mac OS X, Android, iOS, Win10 Mobile) - Browser and version (Chrome, Firefox, Safari, IE, MS Edge, Opera 15+, Android Browser) -- Reduced test cases and potential fixes using [JS Bin](https://jsbin.com/) +- Reduced test cases and potential fixes using [CodePen](https://codepen.io/) or [JS Bin](https://jsbin.com/) When suggesting a feature, include: -- cgit v1.2.3 From 7b715ee7e846d0e53d9839b91254676f3795f3bd Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Wed, 4 Oct 2017 19:23:17 +0300 Subject: Examples: remove unused images. (#24237) --- docs/4.0/examples/screenshots/equal-height-columns.jpg | Bin 129265 -> 0 bytes docs/4.0/examples/screenshots/non-responsive.jpg | Bin 61060 -> 0 bytes docs/4.0/examples/screenshots/theme.jpg | Bin 85405 -> 0 bytes 3 files changed, 0 insertions(+), 0 deletions(-) delete mode 100644 docs/4.0/examples/screenshots/equal-height-columns.jpg delete mode 100644 docs/4.0/examples/screenshots/non-responsive.jpg delete mode 100644 docs/4.0/examples/screenshots/theme.jpg diff --git a/docs/4.0/examples/screenshots/equal-height-columns.jpg b/docs/4.0/examples/screenshots/equal-height-columns.jpg deleted file mode 100644 index 63b043f48..000000000 Binary files a/docs/4.0/examples/screenshots/equal-height-columns.jpg and /dev/null differ diff --git a/docs/4.0/examples/screenshots/non-responsive.jpg b/docs/4.0/examples/screenshots/non-responsive.jpg deleted file mode 100644 index 4262d5dd0..000000000 Binary files a/docs/4.0/examples/screenshots/non-responsive.jpg and /dev/null differ diff --git a/docs/4.0/examples/screenshots/theme.jpg b/docs/4.0/examples/screenshots/theme.jpg deleted file mode 100644 index 2b966ff9a..000000000 Binary files a/docs/4.0/examples/screenshots/theme.jpg and /dev/null differ -- cgit v1.2.3