From 5fd7bc1554d492bdd5794d35fce515fe951439a6 Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Tue, 2 Jun 2015 09:41:40 +0100 Subject: generalize dropdowns / drop role="menu" as role="menu" is a very specific (and strict) ARIA pattern for desktop-like application menus, and our dropdowns are often used as pure navigation dropdowns, this change abandons ARIA menus for a more open-ended and light-weight approach (see http://heydonworks.com/practical_aria_examples/#submenus and http://www.w3.org/WAI/tutorials/menus/flyout/#improve-screen-reader-support-using-wai-aria) note that in dropdown.js, switched to now target ``.dropdown-menu`` instead of ``role["menu"]`` - this also prevents bootstrap scripts from "bleeding" into non-bootstrap components on the same page. also removed the ``role=["listbox"]`` part, which appears to be vestigial/unused (only place in bootstrap that uses that role are carousels, and their key handling is done separately) --- docs/_includes/js/dropdowns.html | 78 ++++++++++++++++++++-------------------- docs/_includes/js/scrollspy.html | 10 +++--- docs/_includes/js/tabs.html | 6 ++-- 3 files changed, 47 insertions(+), 47 deletions(-) (limited to 'docs/_includes/js') diff --git a/docs/_includes/js/dropdowns.html b/docs/_includes/js/dropdowns.html index 192d9a106..7d8c50bdc 100644 --- a/docs/_includes/js/dropdowns.html +++ b/docs/_includes/js/dropdowns.html @@ -20,44 +20,44 @@ @@ -134,12 +134,12 @@

To keep URLs intact with link buttons, use the data-target attribute instead of href="#".

{% highlight html %} diff --git a/docs/_includes/js/scrollspy.html b/docs/_includes/js/scrollspy.html index adcce1f29..8fa6215a5 100644 --- a/docs/_includes/js/scrollspy.html +++ b/docs/_includes/js/scrollspy.html @@ -20,12 +20,12 @@
  • @fat
  • @mdo
  • Profile