From f140084f2beb17b0a266b42ab9a03d0b935e5f66 Mon Sep 17 00:00:00 2001 From: Josh Dague Date: Thu, 22 Aug 2013 14:50:15 -0400 Subject: Don't explicitly reference global jQuery Removes `window.jQuery` in favor of `jQuery`, fixes #10038 --- js/dropdown.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'js/dropdown.js') diff --git a/js/dropdown.js b/js/dropdown.js index 6093f11a8..9293b830b 100644 --- a/js/dropdown.js +++ b/js/dropdown.js @@ -151,4 +151,4 @@ .on('click.bs.dropdown.data-api' , toggle, Dropdown.prototype.toggle) .on('keydown.bs.dropdown.data-api', toggle + ', [role=menu]' , Dropdown.prototype.keydown) -}(window.jQuery); +}(jQuery); -- cgit v1.2.3 From 63433fbef9e47f04658085e01d637559f4f14392 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zlatan=20Vasovi=C4=87?= Date: Tue, 22 Oct 2013 18:41:33 +0200 Subject: Update license year --- js/dropdown.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'js/dropdown.js') diff --git a/js/dropdown.js b/js/dropdown.js index 6093f11a8..98c816e4f 100644 --- a/js/dropdown.js +++ b/js/dropdown.js @@ -2,7 +2,7 @@ * Bootstrap: dropdown.js v3.0.0 * http://twbs.github.com/bootstrap/javascript.html#dropdowns * ======================================================================== - * Copyright 2012 Twitter, Inc. + * Copyright 2013 Twitter, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. -- cgit v1.2.3 From 583697fec330b7f3aa3ae7dd6074d461ba91029c Mon Sep 17 00:00:00 2001 From: Jared Christensen Date: Tue, 29 Oct 2013 12:10:47 -0500 Subject: JS comments pointed to new documentation --- js/dropdown.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'js/dropdown.js') diff --git a/js/dropdown.js b/js/dropdown.js index 98c816e4f..e45d51c2d 100644 --- a/js/dropdown.js +++ b/js/dropdown.js @@ -1,6 +1,6 @@ /* ======================================================================== * Bootstrap: dropdown.js v3.0.0 - * http://twbs.github.com/bootstrap/javascript.html#dropdowns + * http://getbootstrap.com/javascript/#dropdowns * ======================================================================== * Copyright 2013 Twitter, Inc. * -- cgit v1.2.3 From 4e0d022de5b0d27b063156533dfcc248fc08257e Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Fri, 1 Nov 2013 17:15:34 -0700 Subject: update version numbers in JS file comment headers to v3.0.1 & regrunt --- js/dropdown.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'js/dropdown.js') diff --git a/js/dropdown.js b/js/dropdown.js index e45d51c2d..5680791c3 100644 --- a/js/dropdown.js +++ b/js/dropdown.js @@ -1,5 +1,5 @@ /* ======================================================================== - * Bootstrap: dropdown.js v3.0.0 + * Bootstrap: dropdown.js v3.0.1 * http://getbootstrap.com/javascript/#dropdowns * ======================================================================== * Copyright 2013 Twitter, Inc. -- cgit v1.2.3 From 6a4230556532d3d947a84aa0d07f57e40a68a9ff Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Wed, 6 Nov 2013 12:57:28 -0800 Subject: bump versions to v3.0.2 --- js/dropdown.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'js/dropdown.js') diff --git a/js/dropdown.js b/js/dropdown.js index 192903340..d5da638de 100644 --- a/js/dropdown.js +++ b/js/dropdown.js @@ -1,5 +1,5 @@ /* ======================================================================== - * Bootstrap: dropdown.js v3.0.1 + * Bootstrap: dropdown.js v3.0.2 * http://getbootstrap.com/javascript/#dropdowns * ======================================================================== * Copyright 2013 Twitter, Inc. -- cgit v1.2.3 From 56f6847ed60b5a8a15861a5db31676fe9901ff41 Mon Sep 17 00:00:00 2001 From: "Cina S." Date: Sat, 16 Nov 2013 09:43:47 -0600 Subject: Add missing data namespace for dropdown --- js/dropdown.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'js/dropdown.js') diff --git a/js/dropdown.js b/js/dropdown.js index d5da638de..2bf65e5df 100644 --- a/js/dropdown.js +++ b/js/dropdown.js @@ -123,9 +123,9 @@ $.fn.dropdown = function (option) { return this.each(function () { var $this = $(this) - var data = $this.data('dropdown') + var data = $this.data('bs.dropdown') - if (!data) $this.data('dropdown', (data = new Dropdown(this))) + if (!data) $this.data('bs.dropdown', (data = new Dropdown(this))) if (typeof option == 'string') data[option].call($this) }) } -- cgit v1.2.3 From ad86d9a51bca001a52969d6cae65957023e30e9c Mon Sep 17 00:00:00 2001 From: Valera Rozuvan Date: Mon, 18 Nov 2013 11:55:33 +0200 Subject: Update dropdown.js --- js/dropdown.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'js/dropdown.js') diff --git a/js/dropdown.js b/js/dropdown.js index d5da638de..ecce5af78 100644 --- a/js/dropdown.js +++ b/js/dropdown.js @@ -41,7 +41,7 @@ if (!isActive) { if ('ontouchstart' in document.documentElement && !$parent.closest('.navbar-nav').length) { - // if mobile we we use a backdrop because click events don't delegate + // if mobile we use a backdrop because click events don't delegate $('
').insertAfter($(this)).on('click', clearMenus) } -- cgit v1.2.3 From 8a74264344489e8b9e10c5c5e2098bb75116b8bd Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Sun, 1 Dec 2013 19:31:52 -0800 Subject: bump version numbers to 3.0.3 --- js/dropdown.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'js/dropdown.js') diff --git a/js/dropdown.js b/js/dropdown.js index 147fcd7b0..a56ac8f94 100644 --- a/js/dropdown.js +++ b/js/dropdown.js @@ -1,5 +1,5 @@ /* ======================================================================== - * Bootstrap: dropdown.js v3.0.2 + * Bootstrap: dropdown.js v3.0.3 * http://getbootstrap.com/javascript/#dropdowns * ======================================================================== * Copyright 2013 Twitter, Inc. -- cgit v1.2.3 From f7d21d6919f186dc6e760f0dc8a574dbb0c133d6 Mon Sep 17 00:00:00 2001 From: mdxs Date: Wed, 4 Dec 2013 11:15:48 +0100 Subject: Dropping unused variable in dropdown.js Dropping an unused variable in the Dropdown function inside the `dropdown.js` code. There are no new/changed unit tests, as there are no feature/bug changes requiring new test cases. For the record: I agree to dual-license this contribution under the Apache 2 and MIT licenses. --- js/dropdown.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'js/dropdown.js') diff --git a/js/dropdown.js b/js/dropdown.js index a56ac8f94..13352ef7c 100644 --- a/js/dropdown.js +++ b/js/dropdown.js @@ -26,7 +26,7 @@ var backdrop = '.dropdown-backdrop' var toggle = '[data-toggle=dropdown]' var Dropdown = function (element) { - var $el = $(element).on('click.bs.dropdown', this.toggle) + $(element).on('click.bs.dropdown', this.toggle) } Dropdown.prototype.toggle = function (e) { -- cgit v1.2.3 From 351f86e1db6bbb5f37e67323094fc08f4aeceecd Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Fri, 6 Dec 2013 16:51:59 -0800 Subject: fix some JS to pass jscs --- js/dropdown.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'js/dropdown.js') diff --git a/js/dropdown.js b/js/dropdown.js index 13352ef7c..b84d219bd 100644 --- a/js/dropdown.js +++ b/js/dropdown.js @@ -85,7 +85,7 @@ if (e.keyCode == 38 && index > 0) index-- // up if (e.keyCode == 40 && index < $items.length - 1) index++ // down - if (!~index) index=0 + if (!~index) index = 0 $items.eq(index).focus() } -- cgit v1.2.3 From eca8ff380388c1187bc2c86e0ae7fa80aa33111e Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Wed, 18 Sep 2013 19:50:02 +0300 Subject: Use single quotes consistently. --- js/dropdown.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'js/dropdown.js') diff --git a/js/dropdown.js b/js/dropdown.js index b84d219bd..3f71c7569 100644 --- a/js/dropdown.js +++ b/js/dropdown.js @@ -18,7 +18,7 @@ * ======================================================================== */ -+function ($) { "use strict"; ++function ($) { 'use strict'; // DROPDOWN CLASS DEFINITION // ========================= -- cgit v1.2.3