From 02dbd87ffa94ff0d2f5bbc43a13f13033ce01f0b Mon Sep 17 00:00:00 2001
From: Kyle Tsang <6854874+kyletsang@users.noreply.github.com>
Date: Thu, 11 Feb 2021 21:51:34 -0800
Subject: Fix event handler removal in dropdown/carousel dispose (#33000)

* Fix event handler removal in carousel dispose

* Fix event handler removal in dropdown dispose

* Test event handlers in scrollspy dispose

* Test event handlers in toast dispose

* Test event handlers in tooltip dispose

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
---
 js/src/carousel.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'js/src/carousel.js')

diff --git a/js/src/carousel.js b/js/src/carousel.js
index e4c13d593..17814d42d 100644
--- a/js/src/carousel.js
+++ b/js/src/carousel.js
@@ -216,7 +216,6 @@ class Carousel extends BaseComponent {
   }
 
   dispose() {
-    super.dispose()
     EventHandler.off(this._element, EVENT_KEY)
 
     this._items = null
@@ -226,6 +225,8 @@ class Carousel extends BaseComponent {
     this._isSliding = null
     this._activeElement = null
     this._indicatorsElement = null
+
+    super.dispose()
   }
 
   // Private
-- 
cgit v1.2.3