From c834895fa0e7d215ee8cb17b3efa8d0ce57a718c Mon Sep 17 00:00:00 2001 From: Johann-S Date: Sun, 24 Mar 2019 18:30:30 +0100 Subject: rewrite unit tests for selector engine --- js/src/dom/selector-engine.js | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-) (limited to 'js/src/dom/selector-engine.js') diff --git a/js/src/dom/selector-engine.js b/js/src/dom/selector-engine.js index eb6b680ac..d66d8acfc 100644 --- a/js/src/dom/selector-engine.js +++ b/js/src/dom/selector-engine.js @@ -22,37 +22,22 @@ const SelectorEngine = { }, find(selector, element = document.documentElement) { - if (typeof selector !== 'string') { - return null - } - return findFn.call(element, selector) }, findOne(selector, element = document.documentElement) { - if (typeof selector !== 'string') { - return null - } - return findOne.call(element, selector) }, children(element, selector) { - if (typeof selector !== 'string') { - return null - } - const children = makeArray(element.children) return children.filter(child => this.matches(child, selector)) }, parents(element, selector) { - if (typeof selector !== 'string') { - return null - } - const parents = [] + let ancestor = element.parentNode while (ancestor && ancestor.nodeType === Node.ELEMENT_NODE && ancestor.nodeType !== NODE_TEXT) { @@ -67,19 +52,12 @@ const SelectorEngine = { }, closest(element, selector) { - if (typeof selector !== 'string') { - return null - } - return closest.call(element, selector) }, prev(element, selector) { - if (typeof selector !== 'string') { - return null - } - const siblings = [] + let previous = element.previousSibling while (previous && previous.nodeType === Node.ELEMENT_NODE && previous.nodeType !== NODE_TEXT) { -- cgit v1.2.3