From fc02932946424e986a72bb7b47044eab815851cb Mon Sep 17 00:00:00 2001
From: Johann-S <johann.servoire@gmail.com>
Date: Tue, 23 Jul 2019 21:15:00 +0200
Subject: use get selector from element only when needed

---
 js/src/tab/tab.js | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

(limited to 'js/src/tab')

diff --git a/js/src/tab/tab.js b/js/src/tab/tab.js
index e882ff1d2..c9f4869ef 100644
--- a/js/src/tab/tab.js
+++ b/js/src/tab/tab.js
@@ -9,7 +9,7 @@ import {
   jQuery as $,
   TRANSITION_END,
   emulateTransitionEnd,
-  getSelectorFromElement,
+  getElementFromSelector,
   getTransitionDurationFromElement,
   makeArray,
   reflow
@@ -85,10 +85,9 @@ class Tab {
       return
     }
 
-    let target
     let previous
+    const target = getElementFromSelector(this._element)
     const listElement = SelectorEngine.closest(this._element, Selector.NAV_LIST_GROUP)
-    const selector = getSelectorFromElement(this._element)
 
     if (listElement) {
       const itemSelector = listElement.nodeName === 'UL' || listElement.nodeName === 'OL' ? Selector.ACTIVE_UL : Selector.ACTIVE
@@ -113,10 +112,6 @@ class Tab {
       return
     }
 
-    if (selector) {
-      target = SelectorEngine.findOne(selector)
-    }
-
     this._activate(
       this._element,
       listElement
-- 
cgit v1.2.3