From a689120fd2af44bfb317f899b42037c46bfcd2fe Mon Sep 17 00:00:00 2001
From: Johann-S <johann.servoire@gmail.com>
Date: Wed, 12 Sep 2018 10:08:39 +0200
Subject: throw error when folks try to use a bad selector

---
 js/src/util.js | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

(limited to 'js/src/util.js')

diff --git a/js/src/util.js b/js/src/util.js
index 653598ae2..653b14a17 100644
--- a/js/src/util.js
+++ b/js/src/util.js
@@ -79,14 +79,11 @@ const Util = (($) => {
       let selector = element.getAttribute('data-target')
 
       if (!selector || selector === '#') {
-        selector = (element.getAttribute('href') || '').trim()
+        const hrefAttr = element.getAttribute('href')
+        selector = hrefAttr && hrefAttr !== '#' ? hrefAttr.trim() : ''
       }
 
-      try {
-        return document.querySelector(selector) ? selector : null
-      } catch (err) {
-        return null
-      }
+      return selector && document.querySelector(selector) ? selector : null
     },
 
     getTransitionDurationFromElement(element) {
-- 
cgit v1.2.3