From 3f247a42f2a113f9e04184987eae9019abcac778 Mon Sep 17 00:00:00 2001 From: Johann Date: Thu, 23 Mar 2017 22:22:09 +0100 Subject: Fix Modal documentation about _handleUpdate method + move to public scope (#21877) Fix Modal documentation about _handleUpdate method + move to public scope --- js/src/modal.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'js/src') diff --git a/js/src/modal.js b/js/src/modal.js index 9263efd53..7f010b8e0 100644 --- a/js/src/modal.js +++ b/js/src/modal.js @@ -215,6 +215,9 @@ const Modal = (($) => { this._scrollbarWidth = null } + handleUpdate() { + this._adjustDialog() + } // private @@ -296,7 +299,7 @@ const Modal = (($) => { _setResizeEvent() { if (this._isShown) { - $(window).on(Event.RESIZE, (event) => this._handleUpdate(event)) + $(window).on(Event.RESIZE, (event) => this.handleUpdate(event)) } else { $(window).off(Event.RESIZE) } @@ -401,10 +404,6 @@ const Modal = (($) => { // todo (fat): these should probably be refactored out of modal.js // ---------------------------------------------------------------------- - _handleUpdate() { - this._adjustDialog() - } - _adjustDialog() { const isModalOverflowing = this._element.scrollHeight > document.documentElement.clientHeight -- cgit v1.2.3