From ab39defe74914109df164c823af927de68320d55 Mon Sep 17 00:00:00 2001 From: Pierre Vanduynslager Date: Tue, 25 Apr 2017 03:32:14 -0400 Subject: Detach accordion from card without requiring 'data-children' --- js/src/collapse.js | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) (limited to 'js/src') diff --git a/js/src/collapse.js b/js/src/collapse.js index dec272297..bf1c738f5 100644 --- a/js/src/collapse.js +++ b/js/src/collapse.js @@ -56,9 +56,8 @@ const Collapse = (($) => { } const Selector = { - ACTIVES : '.card > .show, .card > .collapsing', - DATA_TOGGLE : '[data-toggle="collapse"]', - DATA_CHILDREN : 'data-children' + ACTIVES : '.show, .collapsing', + DATA_TOGGLE : '[data-toggle="collapse"]' } @@ -78,20 +77,13 @@ const Collapse = (($) => { `[data-toggle="collapse"][href="#${element.id}"],` + `[data-toggle="collapse"][data-target="#${element.id}"]` )) + this._parent = this._config.parent ? this._getParent() : null if (!this._config.parent) { this._addAriaAndCollapsedClass(this._element, this._triggerArray) } - this._selectorActives = Selector.ACTIVES - if (this._parent) { - const childrenSelector = this._parent.hasAttribute(Selector.DATA_CHILDREN) ? this._parent.getAttribute(Selector.DATA_CHILDREN) : null - if (childrenSelector !== null) { - this._selectorActives = `${childrenSelector} > .show, ${childrenSelector} > .collapsing` - } - } - if (this._config.toggle) { this.toggle() } @@ -129,7 +121,7 @@ const Collapse = (($) => { let activesData if (this._parent) { - actives = $.makeArray($(this._parent).find(this._selectorActives)) + actives = $.makeArray($(this._parent).children().children(Selector.ACTIVES)) if (!actives.length) { actives = null } -- cgit v1.2.3 From 33715a73d2eae3865cb4c1e0a13d1da4b6aeb278 Mon Sep 17 00:00:00 2001 From: Anna Date: Wed, 26 Apr 2017 19:46:05 +0300 Subject: Fix Toggle buttons don't honor [disabled] or .disabled --- js/src/button.js | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'js/src') diff --git a/js/src/button.js b/js/src/button.js index 6295d0db0..722fd489d 100644 --- a/js/src/button.js +++ b/js/src/button.js @@ -90,6 +90,12 @@ const Button = (($) => { } if (triggerChangeEvent) { + if (input.hasAttribute('disabled') || + rootElement.hasAttribute('disabled') || + input.classList.contains('disabled') || + rootElement.classList.contains('disabled')) { + return + } input.checked = !$(this._element).hasClass(ClassName.ACTIVE) $(input).trigger('change') } -- cgit v1.2.3 From db2db6cd0e654ddc3bfac5be5fbc93bf2bb3a674 Mon Sep 17 00:00:00 2001 From: Joyce Babu Date: Fri, 28 Apr 2017 19:01:35 +0530 Subject: Fix typo removeData for Tabs plugin Should remove `data` not `class` on dispose --- js/src/tab.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'js/src') diff --git a/js/src/tab.js b/js/src/tab.js index 6f8187d17..c7bc520df 100644 --- a/js/src/tab.js +++ b/js/src/tab.js @@ -140,7 +140,7 @@ const Tab = (($) => { } dispose() { - $.removeClass(this._element, DATA_KEY) + $.removeData(this._element, DATA_KEY) this._element = null } -- cgit v1.2.3