From 5fd7bc1554d492bdd5794d35fce515fe951439a6 Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Tue, 2 Jun 2015 09:41:40 +0100 Subject: generalize dropdowns / drop role="menu" as role="menu" is a very specific (and strict) ARIA pattern for desktop-like application menus, and our dropdowns are often used as pure navigation dropdowns, this change abandons ARIA menus for a more open-ended and light-weight approach (see http://heydonworks.com/practical_aria_examples/#submenus and http://www.w3.org/WAI/tutorials/menus/flyout/#improve-screen-reader-support-using-wai-aria) note that in dropdown.js, switched to now target ``.dropdown-menu`` instead of ``role["menu"]`` - this also prevents bootstrap scripts from "bleeding" into non-bootstrap components on the same page. also removed the ``role=["listbox"]`` part, which appears to be vestigial/unused (only place in bootstrap that uses that role are carousels, and their key handling is done separately) --- js/tests/unit/dropdown.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'js/tests/unit/dropdown.js') diff --git a/js/tests/unit/dropdown.js b/js/tests/unit/dropdown.js index e0d1df970..a55684d52 100644 --- a/js/tests/unit/dropdown.js +++ b/js/tests/unit/dropdown.js @@ -186,7 +186,7 @@ $(function () { + '
  • Menu 1
    • ' + '