From 89f88762c52f4c7dfca0fe1de6d41386bb673289 Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Sun, 30 Jan 2022 16:12:24 +0200 Subject: Fix visual tests (#35585) * Fix visual tests They broke in #34509 * load bundle.js in visual tests Co-authored-by: GeoSot --- js/tests/visual/alert.html | 6 +----- js/tests/visual/button.html | 6 +----- js/tests/visual/carousel.html | 7 +------ js/tests/visual/collapse.html | 7 +------ js/tests/visual/dropdown.html | 9 +-------- js/tests/visual/modal.html | 17 ++++------------- js/tests/visual/popover.html | 11 ++--------- js/tests/visual/scrollspy.html | 9 +-------- js/tests/visual/tab.html | 7 +------ js/tests/visual/toast.html | 12 ++++-------- js/tests/visual/tooltip.html | 18 ++++++------------ 11 files changed, 23 insertions(+), 86 deletions(-) (limited to 'js/tests/visual') diff --git a/js/tests/visual/alert.html b/js/tests/visual/alert.html index c5e2efafa..2433b9e8e 100644 --- a/js/tests/visual/alert.html +++ b/js/tests/visual/alert.html @@ -43,10 +43,6 @@ - - - - - + diff --git a/js/tests/visual/button.html b/js/tests/visual/button.html index 0bd2f1097..0c54934f0 100644 --- a/js/tests/visual/button.html +++ b/js/tests/visual/button.html @@ -44,10 +44,6 @@ - - - - - + diff --git a/js/tests/visual/carousel.html b/js/tests/visual/carousel.html index 561b6ce5a..b26895fd0 100644 --- a/js/tests/visual/carousel.html +++ b/js/tests/visual/carousel.html @@ -45,12 +45,7 @@ - - - - - - + - - - - - + diff --git a/js/tests/visual/dropdown.html b/js/tests/visual/dropdown.html index f1dd705f3..bc4d79542 100644 --- a/js/tests/visual/dropdown.html +++ b/js/tests/visual/dropdown.html @@ -200,13 +200,6 @@ - - - - - - - - + diff --git a/js/tests/visual/modal.html b/js/tests/visual/modal.html index 719e9cc10..f11edea95 100644 --- a/js/tests/visual/modal.html +++ b/js/tests/visual/modal.html @@ -199,16 +199,7 @@ - - - - - - - - - - + - - - - - - - + diff --git a/js/tests/visual/scrollspy.html b/js/tests/visual/scrollspy.html index 1e3215b6f..7999b0ee7 100644 --- a/js/tests/visual/scrollspy.html +++ b/js/tests/visual/scrollspy.html @@ -86,13 +86,6 @@

Ad leggings keytar, brunch id art party dolor labore.

- - - - - - - - + diff --git a/js/tests/visual/tab.html b/js/tests/visual/tab.html index 0ce8be03c..4cbc86ccc 100644 --- a/js/tests/visual/tab.html +++ b/js/tests/visual/tab.html @@ -218,11 +218,6 @@ - - - - - - + diff --git a/js/tests/visual/toast.html b/js/tests/visual/toast.html index f9e1741cf..9e6c897df 100644 --- a/js/tests/visual/toast.html +++ b/js/tests/visual/toast.html @@ -50,22 +50,18 @@ - - - - - + - - - - - - + + + + -- cgit v1.2.3 From 27f20257ebd092b2e5d11a62de0cd5e9cf5a9949 Mon Sep 17 00:00:00 2001 From: GeoSot Date: Thu, 22 Sep 2022 01:48:23 +0300 Subject: Use es6 on visual tests (#36915) --- js/tests/visual/carousel.html | 10 +++++----- js/tests/visual/modal.html | 43 ++++++++++++++++++------------------------- js/tests/visual/popover.html | 5 +---- js/tests/visual/toast.html | 23 ++++++----------------- 4 files changed, 30 insertions(+), 51 deletions(-) (limited to 'js/tests/visual') diff --git a/js/tests/visual/carousel.html b/js/tests/visual/carousel.html index b26895fd0..153c86604 100644 --- a/js/tests/visual/carousel.html +++ b/js/tests/visual/carousel.html @@ -47,17 +47,17 @@ diff --git a/js/tests/visual/modal.html b/js/tests/visual/modal.html index ab0986c58..5056c6e7c 100644 --- a/js/tests/visual/modal.html +++ b/js/tests/visual/modal.html @@ -201,8 +201,8 @@ diff --git a/js/tests/visual/popover.html b/js/tests/visual/popover.html index eed69c341..96b746b72 100644 --- a/js/tests/visual/popover.html +++ b/js/tests/visual/popover.html @@ -33,10 +33,7 @@ diff --git a/js/tests/visual/toast.html b/js/tests/visual/toast.html index 9e6c897df..cacc7da70 100644 --- a/js/tests/visual/toast.html +++ b/js/tests/visual/toast.html @@ -52,26 +52,15 @@ -- cgit v1.2.3 From abb1cf529fb8dfb8e66e44506eb32f8a9e0e0ee2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julien=20D=C3=A9ramond?= Date: Tue, 27 Sep 2022 21:53:59 +0200 Subject: Add eslint-plugin-html to lint JS in HTML files (#37186) --- js/tests/visual/.eslintrc.json | 19 +++++++++++++++++++ js/tests/visual/modal.html | 9 ++++----- js/tests/visual/popover.html | 2 ++ js/tests/visual/toast.html | 6 ++++-- js/tests/visual/tooltip.html | 17 +++++++++++------ 5 files changed, 40 insertions(+), 13 deletions(-) create mode 100644 js/tests/visual/.eslintrc.json (limited to 'js/tests/visual') diff --git a/js/tests/visual/.eslintrc.json b/js/tests/visual/.eslintrc.json new file mode 100644 index 000000000..8a3322572 --- /dev/null +++ b/js/tests/visual/.eslintrc.json @@ -0,0 +1,19 @@ +{ + "plugins": [ + "html" + ], + "extends": "../../../.eslintrc.json", + "parserOptions": { + "sourceType": "module" + }, + "settings": { + "html/html-extensions": [ + ".html" + ] + }, + "rules": { + "no-console": "off", + "no-new": "off", + "unicorn/no-array-for-each": "off" + } +} diff --git a/js/tests/visual/modal.html b/js/tests/visual/modal.html index 5056c6e7c..fd93c068a 100644 --- a/js/tests/visual/modal.html +++ b/js/tests/visual/modal.html @@ -201,6 +201,8 @@ diff --git a/js/tests/visual/toast.html b/js/tests/visual/toast.html index cacc7da70..f86926d01 100644 --- a/js/tests/visual/toast.html +++ b/js/tests/visual/toast.html @@ -52,15 +52,17 @@ diff --git a/js/tests/visual/tooltip.html b/js/tests/visual/tooltip.html index 9a65640b4..1a3b9f21d 100644 --- a/js/tests/visual/tooltip.html +++ b/js/tests/visual/tooltip.html @@ -85,6 +85,8 @@ -- cgit v1.2.3 From 0a5f6e078c9cb9ecca9ab90b3984c5f792a11bae Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Sun, 2 Oct 2022 11:02:36 +0100 Subject: Use `

` for all `modal-title` examples/uses (#37210) * Use `fs-` font sizing classes where needed * Also add info callout about heading hierarchy in modals --- js/tests/visual/modal.html | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'js/tests/visual') diff --git a/js/tests/visual/modal.html b/js/tests/visual/modal.html index fd93c068a..b738d9e81 100644 --- a/js/tests/visual/modal.html +++ b/js/tests/visual/modal.html @@ -38,7 +38,7 @@
- +

Modal title

@@ -123,7 +123,7 @@
- +

Firefox Bug Test

@@ -147,7 +147,7 @@
- +

Lorem slowly

@@ -188,7 +188,7 @@ Tall body content to force the page to have a scrollbar.
- -- cgit v1.2.3 From 137c932e473d5b14c79c6b143a3ea344aa108612 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julien=20D=C3=A9ramond?= Date: Mon, 10 Oct 2022 21:15:43 +0200 Subject: Docs: standardize usage of `` --- js/tests/visual/button.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'js/tests/visual') diff --git a/js/tests/visual/button.html b/js/tests/visual/button.html index 0c54934f0..47c50889c 100644 --- a/js/tests/visual/button.html +++ b/js/tests/visual/button.html @@ -15,7 +15,7 @@

For checkboxes and radio buttons, ensure that keyboard behavior is functioning correctly.

-

Navigate to the checkboxes with the keyboard (generally, using TAB / SHIFT + TAB), and ensure that SPACE toggles the currently focused checkbox. Click on one of the checkboxes using the mouse, ensure that focus was correctly set on the actual checkbox, and that SPACE toggles the checkbox again.

+

Navigate to the checkboxes with the keyboard (generally, using Tab / Shift + Tab), and ensure that Space toggles the currently focused checkbox. Click on one of the checkboxes using the mouse, ensure that focus was correctly set on the actual checkbox, and that Space toggles the checkbox again.

-

Navigate to the radio button group with the keyboard (generally, using TAB / SHIFT + TAB). If no radio button was initially set to be selected, the first/last radio button should receive focus (depending on whether you navigated "forward" to the group with TAB or "backwards" using SHIFT + TAB). If a radio button was already selected, navigating with the keyboard should set focus to that particular radio button. Only one radio button in a group should receive focus at any given time. Ensure that the selected radio button can be changed by using the ← and → arrow keys. Click on one of the radio buttons with the mouse, ensure that focus was correctly set on the actual radio button, and that ← and → change the selected radio button again.

+

Navigate to the radio button group with the keyboard (generally, using Tab / Shift + Tab). If no radio button was initially set to be selected, the first/last radio button should receive focus (depending on whether you navigated "forward" to the group with Tab or "backwards" using Shift + Tab). If a radio button was already selected, navigating with the keyboard should set focus to that particular radio button. Only one radio button in a group should receive focus at any given time. Ensure that the selected radio button can be changed by using the ← and → arrow keys. Click on one of the radio buttons with the mouse, ensure that focus was correctly set on the actual radio button, and that ← and → change the selected radio button again.