From 9445b84b0bdc5a97609ddeaf9b292d3a14083d55 Mon Sep 17 00:00:00 2001 From: sgamel Date: Thu, 26 Jun 2014 10:18:45 +0200 Subject: Ensure that hidden event is sent when content is really hidden (collapsing class is removed) --- js/collapse.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'js') diff --git a/js/collapse.js b/js/collapse.js index eb688f480..72db8adb5 100644 --- a/js/collapse.js +++ b/js/collapse.js @@ -96,9 +96,9 @@ var complete = function () { this.transitioning = 0 this.$element - .trigger('hidden.bs.collapse') .removeClass('collapsing') .addClass('collapse') + .trigger('hidden.bs.collapse') } if (!$.support.transition) return complete.call(this) -- cgit v1.2.3 From 519a087dbed55e3e350c5a7251ae3d76d195e47d Mon Sep 17 00:00:00 2001 From: Chris Hynes Date: Fri, 25 Jul 2014 10:16:44 -0700 Subject: Remove popover content with .children().detach() instead of .empty() so it can be reused --- js/popover.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'js') diff --git a/js/popover.js b/js/popover.js index 825e1b390..130c6c085 100644 --- a/js/popover.js +++ b/js/popover.js @@ -46,7 +46,8 @@ var content = this.getContent() $tip.find('.popover-title')[this.options.html ? 'html' : 'text'](title) - $tip.find('.popover-content').empty()[ // we use append for html objects to maintain js events + $tip.find('.popover-content').children().detach() + $tip.find('.popover-content')[ // we use append for html objects to maintain js events this.options.html ? (typeof content == 'string' ? 'html' : 'append') : 'text' ](content) -- cgit v1.2.3 From 531fc80885bd7ed9ead85017fb2c258a3069d7f7 Mon Sep 17 00:00:00 2001 From: Chris Hynes Date: Fri, 25 Jul 2014 11:10:46 -0700 Subject: Use .end() to remove extra line --- js/popover.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'js') diff --git a/js/popover.js b/js/popover.js index 130c6c085..87b8d12de 100644 --- a/js/popover.js +++ b/js/popover.js @@ -46,8 +46,7 @@ var content = this.getContent() $tip.find('.popover-title')[this.options.html ? 'html' : 'text'](title) - $tip.find('.popover-content').children().detach() - $tip.find('.popover-content')[ // we use append for html objects to maintain js events + $tip.find('.popover-content').children().detach().end()[ // we use append for html objects to maintain js events this.options.html ? (typeof content == 'string' ? 'html' : 'append') : 'text' ](content) -- cgit v1.2.3 From 18c0a1c9774e0b726813b578a5046a30d0681e33 Mon Sep 17 00:00:00 2001 From: Heinrich Fenkart Date: Wed, 30 Jul 2014 23:54:25 +0200 Subject: Revert "Use mousedown instead of click for backdrop click detection; fixes #13816" --- js/modal.js | 2 +- js/tests/unit/modal.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'js') diff --git a/js/modal.js b/js/modal.js index fdefdd2c5..92eff470a 100644 --- a/js/modal.js +++ b/js/modal.js @@ -166,7 +166,7 @@ this.$backdrop = $('