From 824d5d5de486c7540f7357972d69dd169cfcfe1c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guillermo=20Gonz=C3=A1lez=20de=20Ag=C3=BCero?= Date: Thu, 1 Aug 2013 20:07:34 +0200 Subject: Fix #8944 --- less/dropdowns.less | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'less/dropdowns.less') diff --git a/less/dropdowns.less b/less/dropdowns.less index 938e682f5..1cd76a070 100644 --- a/less/dropdowns.less +++ b/less/dropdowns.less @@ -17,6 +17,12 @@ content: ""; } +// The dropdown wrapper (div) +// -------------------------- +.dropdown { + position: relative; +} + // The dropdown menu (ul) // ---------------------- .dropdown-menu { -- cgit v1.2.3 From 3f3dfc54e77036e726154e21d1a34f1f5918b4d7 Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Tue, 6 Aug 2013 18:05:37 -0700 Subject: update use of mixins and add bg-colors where necessary --- less/dropdowns.less | 2 ++ 1 file changed, 2 insertions(+) (limited to 'less/dropdowns.less') diff --git a/less/dropdowns.less b/less/dropdowns.less index 675300de5..0dda5c9ce 100644 --- a/less/dropdowns.less +++ b/less/dropdowns.less @@ -74,6 +74,7 @@ text-decoration: none; color: @dropdown-link-hover-color; #gradient > .vertical(@start-color: @dropdown-link-hover-bg; @end-color: darken(@dropdown-link-hover-bg, 5%)); + background-color: darken(@dropdown-link-hover-bg, 5%); } } @@ -87,6 +88,7 @@ text-decoration: none; outline: 0; #gradient > .vertical(@start-color: @dropdown-link-active-bg; @end-color: darken(@dropdown-link-active-bg, 5%)); + background-color: darken(@dropdown-link-active-bg, 5%); } } -- cgit v1.2.3 From 58b90dae1570eca6c921933742bf418ebf3ee47b Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Sun, 11 Aug 2013 17:47:30 -0700 Subject: addressing #9189 manually, part 2: dropdown header and disabled link colors (and refactor commenting styles) --- less/dropdowns.less | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) (limited to 'less/dropdowns.less') diff --git a/less/dropdowns.less b/less/dropdowns.less index 0dda5c9ce..d40a82a46 100644 --- a/less/dropdowns.less +++ b/less/dropdowns.less @@ -4,7 +4,6 @@ // Dropdown arrow/caret -// -------------------- .caret { display: inline-block; width: 0; @@ -18,13 +17,11 @@ } // The dropdown wrapper (div) -// -------------------------- .dropdown { position: relative; } // The dropdown menu (ul) -// ---------------------- .dropdown-menu { position: absolute; top: 100%; @@ -67,7 +64,6 @@ } // Hover/Focus state -// ----------- .dropdown-menu > li > a { &:hover, &:focus { @@ -79,7 +75,6 @@ } // Active state -// ------------ .dropdown-menu > .active > a { &, &:hover, @@ -93,13 +88,14 @@ } // Disabled state -// -------------- +// // Gray out text and ensure the hover/focus state remains gray + .dropdown-menu > .disabled > a { &, &:hover, &:focus { - color: @gray-light; + color: @dropdown-link-disabled-color; } } // Nuke hover/focus effects @@ -115,7 +111,6 @@ } // Open state for the dropdown -// --------------------------- .open { // Show the menu > .dropdown-menu { @@ -129,19 +124,15 @@ } // Dropdown section headers -// --------------------------- .dropdown-header { display: block; padding: 3px 20px; font-size: @font-size-small; line-height: @line-height-base; - color: @gray-light; + color: @dropdown-header-color; } - - // Backdrop to catch body clicks on mobile, etc. -// --------------------------- .dropdown-backdrop { position: fixed; left: 0; @@ -152,16 +143,16 @@ } // Right aligned dropdowns -// --------------------------- .pull-right > .dropdown-menu { right: 0; left: auto; } // Allow for dropdowns to go bottom up (aka, dropup-menu) -// ------------------------------------------------------ +// // Just add .dropup after the standard .dropdown class and you're set, bro. // TODO: abstract this so that the navbar fixed styles are not placed here? + .dropup, .navbar-fixed-bottom .dropdown { // Reverse the caret -- cgit v1.2.3 From 55cfa8d38f71623aaa5e2aae97b483af60650910 Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Mon, 12 Aug 2013 10:01:13 -0700 Subject: Drop background-clip and background-size mixins since they have no prefixes anyway --- less/dropdowns.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'less/dropdowns.less') diff --git a/less/dropdowns.less b/less/dropdowns.less index d40a82a46..af14bf9e9 100644 --- a/less/dropdowns.less +++ b/less/dropdowns.less @@ -38,7 +38,7 @@ border: 1px solid @dropdown-border; border-radius: @border-radius-base; .box-shadow(0 6px 12px rgba(0,0,0,.175)); - .background-clip(padding-box); + background-clip: padding-box; // Aligns the dropdown menu to right &.pull-right { -- cgit v1.2.3 From 8bb7def26cac4d3166fbf2cc98f16c4151794676 Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Mon, 12 Aug 2013 21:23:28 -0700 Subject: Navbar refactor * Now responsive by default (fits better with mobile-first approach) * Requires `.nav-header` to group `.navbar-brand` and `.navbar-toggle` for proper mobile display. * Changed `.nav-collapse` to `.navbar-collapse` * Simplified examples in docs --- less/dropdowns.less | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'less/dropdowns.less') diff --git a/less/dropdowns.less b/less/dropdowns.less index af14bf9e9..14ce2b473 100644 --- a/less/dropdowns.less +++ b/less/dropdowns.less @@ -21,6 +21,11 @@ position: relative; } +// Prevent the focus on the dropdown toggle when closing dropdowns +.dropdown-toggle:focus { + outline: 0; +} + // The dropdown menu (ul) .dropdown-menu { position: absolute; -- cgit v1.2.3 From 270af4dda31692eb22d48d56db5c98a0c89f4c28 Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Tue, 13 Aug 2013 13:16:56 -0700 Subject: fixes #9431: specify font-size in dropdown menus to avoid inheritance issues --- less/dropdowns.less | 1 + 1 file changed, 1 insertion(+) (limited to 'less/dropdowns.less') diff --git a/less/dropdowns.less b/less/dropdowns.less index af14bf9e9..055d76717 100644 --- a/less/dropdowns.less +++ b/less/dropdowns.less @@ -33,6 +33,7 @@ padding: 5px 0; margin: 2px 0 0; // override default ul list-style: none; + font-size: @font-size-base; background-color: @dropdown-bg; border: 1px solid @dropdown-fallback-border; // IE8 fallback border: 1px solid @dropdown-border; -- cgit v1.2.3 From 2e8a146b61af1e197208ae2d52ee4bf4034352d4 Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Wed, 14 Aug 2013 21:24:48 -0700 Subject: remove gradients from dropdown menu items on hover/active (fixes #9473) --- less/dropdowns.less | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'less/dropdowns.less') diff --git a/less/dropdowns.less b/less/dropdowns.less index 99cf7d00d..d9417358b 100644 --- a/less/dropdowns.less +++ b/less/dropdowns.less @@ -75,8 +75,7 @@ &:focus { text-decoration: none; color: @dropdown-link-hover-color; - #gradient > .vertical(@start-color: @dropdown-link-hover-bg; @end-color: darken(@dropdown-link-hover-bg, 5%)); - background-color: darken(@dropdown-link-hover-bg, 5%); + background-color: @dropdown-link-hover-bg; } } @@ -88,8 +87,7 @@ color: @dropdown-link-active-color; text-decoration: none; outline: 0; - #gradient > .vertical(@start-color: @dropdown-link-active-bg; @end-color: darken(@dropdown-link-active-bg, 5%)); - background-color: darken(@dropdown-link-active-bg, 5%); + background-color: @dropdown-link-active-bg; } } -- cgit v1.2.3