From 1be0b57d34c4712ba747ccb0e917acef2117dc13 Mon Sep 17 00:00:00 2001 From: Rob Fletcher Date: Mon, 17 Mar 2014 14:36:58 +0000 Subject: Fix vertical alignment of temporal inputs on iOS Fixes #13098 Closes #13099 --- less/forms.less | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index 8578e8ce6..f8de2e403 100644 --- a/less/forms.less +++ b/less/forms.less @@ -170,7 +170,10 @@ input[type="search"] { // given height of the input. Since this fucks up everything else, we have to // appropriately reset it for Internet Explorer and the size variations. -input[type="date"] { +input[type="date"], +input[type="time"], +input[type="datetime-local"], +input[type="month"] { line-height: @input-height-base; // IE8+ misaligns the text within date inputs, so we reset line-height: @line-height-base ~"\0"; -- cgit v1.2.3 From 6f6bce5944bd0e6ab36ab6b39339f381d8a80b2a Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Mon, 24 Mar 2014 19:26:41 -0700 Subject: Fixes #13141: Add a max-width: 100%; to label elements so IE8 wraps text --- less/forms.less | 1 + 1 file changed, 1 insertion(+) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index f8de2e403..d51065cf6 100644 --- a/less/forms.less +++ b/less/forms.less @@ -31,6 +31,7 @@ legend { label { display: inline-block; + max-width: 100%; // Force IE8 to wrap long content (see #13141) margin-bottom: 5px; font-weight: bold; } -- cgit v1.2.3 From 06451a58d0d69ca035d3564f4a69c6e7b7f15ff9 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 24 Mar 2014 19:48:21 -0700 Subject: expand issue # ref to full URL --- less/forms.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index d51065cf6..8bec21e48 100644 --- a/less/forms.less +++ b/less/forms.less @@ -31,7 +31,7 @@ legend { label { display: inline-block; - max-width: 100%; // Force IE8 to wrap long content (see #13141) + max-width: 100%; // Force IE8 to wrap long content (see https://github.com/twbs/bootstrap/issues/13141) margin-bottom: 5px; font-weight: bold; } -- cgit v1.2.3 From acf57073231ebd521a87f523de6c51930d3c1ff4 Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Mon, 24 Mar 2014 20:07:54 -0700 Subject: Fixes #13066: Add z-index to the form control feedback icons so input groups don't render on top of them --- less/forms.less | 1 + 1 file changed, 1 insertion(+) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index 8bec21e48..0368c0c0f 100644 --- a/less/forms.less +++ b/less/forms.less @@ -292,6 +292,7 @@ input[type="checkbox"], position: absolute; top: (@line-height-computed + 5); // Height of the `label` and its margin right: 0; + z-index: 2; // Ensure icon is above input groups display: block; width: @input-height-base; height: @input-height-base; -- cgit v1.2.3 From 3777ef007d7329e44a415e12858606b8728e95b5 Mon Sep 17 00:00:00 2001 From: Sean Dwyer Date: Thu, 10 Apr 2014 17:43:53 -0700 Subject: Fix form-control-feedback position when label has sr-only class --- less/forms.less | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index 0368c0c0f..15044cc49 100644 --- a/less/forms.less +++ b/less/forms.less @@ -322,6 +322,12 @@ input[type="checkbox"], } +// Reposition feedback icon if label is hidden with "screenreader only" state +.has-feedback label.sr-only ~ .form-control-feedback { + top: 0; +} + + // Static form control text // // Apply class to a `p` element to make any string of text align with labels in -- cgit v1.2.3 From 06f6c9f00691e9d536958f775b9bc72dc2b3f5c5 Mon Sep 17 00:00:00 2001 From: Sean Dwyer Date: Fri, 11 Apr 2014 14:15:33 -0700 Subject: Fix indent --- less/forms.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index 15044cc49..335c1e0e8 100644 --- a/less/forms.less +++ b/less/forms.less @@ -324,7 +324,7 @@ input[type="checkbox"], // Reposition feedback icon if label is hidden with "screenreader only" state .has-feedback label.sr-only ~ .form-control-feedback { - top: 0; + top: 0; } -- cgit v1.2.3 From 3261ab704e0608740919eeedcac866b0b470887c Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Wed, 21 May 2014 16:44:09 -0700 Subject: update explanatory comment about iOS date/time inputs bug Per: * http://jsbin.com/purer/2/edit * https://github.com/cvrebert/bs-css-hacks/blob/6e8aa78384a005b007fc45327c9516dcf6ec0f30/README.md#ios-temporal-input-line-height Thanks @mdo <3 [skip sauce] [skip validator] --- less/forms.less | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index 335c1e0e8..f0e9204f4 100644 --- a/less/forms.less +++ b/less/forms.less @@ -165,9 +165,11 @@ input[type="search"] { } -// Special styles for iOS date input +// Special styles for iOS temporal inputs // -// In Mobile Safari, date inputs require a pixel line-height that matches the +// In Mobile Safari, setting `display: block` on temporal inputs causes the +// text within the input to become vertically misaligned. +// As a workaround, we set a pixel line-height that matches the // given height of the input. Since this fucks up everything else, we have to // appropriately reset it for Internet Explorer and the size variations. -- cgit v1.2.3 From fab9ab8fe9b51ebc88872482556df3f793e5ac4a Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Thu, 22 May 2014 18:42:21 -0700 Subject: Reset the padding on radio/checkbox labels in form-inline --- less/forms.less | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index 335c1e0e8..e3fe6c3d2 100644 --- a/less/forms.less +++ b/less/forms.less @@ -410,8 +410,11 @@ input[type="checkbox"], display: inline-block; margin-top: 0; margin-bottom: 0; - padding-left: 0; vertical-align: middle; + + label { + padding-left: 0; + } } .radio input[type="radio"], .checkbox input[type="checkbox"] { -- cgit v1.2.3 From 739bf379a93a2a396e23f0423167b3552eb88191 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Thu, 5 Jun 2014 13:31:39 -0700 Subject: set not-allowed cursor on disabled radio+checkbox labels; fixes #13281 [skip validator] [skip sauce] --- less/forms.less | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index cb8a74fa1..b678d44fc 100644 --- a/less/forms.less +++ b/less/forms.less @@ -247,19 +247,35 @@ input[type="month"] { } // Apply same disabled cursor tweak as for inputs +// Some special care is needed because