From e71a85a525da06100a4b3882fcb95909454c5dca Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Sun, 19 Jan 2014 10:23:00 -0800 Subject: remove confusing comment --- less/forms.less | 3 --- 1 file changed, 3 deletions(-) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index 6b475ae13..9c765c2ba 100644 --- a/less/forms.less +++ b/less/forms.less @@ -139,9 +139,6 @@ output { .form-control-focus(); // Placeholder - // - // Placeholder text gets special styles because when browsers invalidate entire - // lines if it doesn't understand a selector/ .placeholder(); // Disabled and read-only inputs -- cgit v1.2.3 From 08e83a62b7a3b12d459b2e025661e60024b10ca7 Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Wed, 22 Jan 2014 21:43:08 -0600 Subject: Fix #11655: Fix broken disabled states for iOS form controls and buttons --- less/forms.less | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index 9c765c2ba..375a387ef 100644 --- a/less/forms.less +++ b/less/forms.less @@ -33,6 +33,10 @@ label { // Normalize form controls +// +// While most of our form styles require extra classes, some basic normalization +// is required to ensure optimum display with or without those classes to better +// address browser inconsistencies. // Override content-box in Normalize (* isn't specific enough) input[type="search"] { @@ -79,8 +83,9 @@ input[type="checkbox"]:focus { } // Fix for Chrome number input -// Setting certain font-sizes causes the `I` bar to appear on hover of the bottom increment button. -// See https://github.com/twbs/bootstrap/issues/8350 for more. +// +// Setting certain font-sizes causes the `I` bar to appear on hover of the +// bottom increment button. See https://github.com/twbs/bootstrap/issues/8350. input[type="number"] { &::-webkit-outer-spin-button, &::-webkit-inner-spin-button { @@ -150,6 +155,7 @@ output { fieldset[disabled] & { cursor: not-allowed; background-color: @input-bg-disabled; + opacity: 1; // iOS fix for unreadable disabled content } // Reset height for `textarea`s -- cgit v1.2.3 From 31e8a48783c2c58becbd59f9c686f18c28e2d0ef Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Thu, 23 Jan 2014 15:07:04 -0800 Subject: "bottom increment" => "decrement" in explanatory comment --- less/forms.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index 375a387ef..6560c8c39 100644 --- a/less/forms.less +++ b/less/forms.less @@ -85,7 +85,7 @@ input[type="checkbox"]:focus { // Fix for Chrome number input // // Setting certain font-sizes causes the `I` bar to appear on hover of the -// bottom increment button. See https://github.com/twbs/bootstrap/issues/8350. +// decrement button. See https://github.com/twbs/bootstrap/issues/8350. input[type="number"] { &::-webkit-outer-spin-button, &::-webkit-inner-spin-button { -- cgit v1.2.3 From 64e81324261548a8de8cda5fde4b87d0f7a8f8fb Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Fri, 24 Jan 2014 11:55:59 -0600 Subject: Fix #12359: Reset min-width on fieldsets so that they don't break responsive tables and behave more like standard block level elements --- less/forms.less | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index 6560c8c39..687d1f437 100644 --- a/less/forms.less +++ b/less/forms.less @@ -11,6 +11,10 @@ fieldset { padding: 0; margin: 0; border: 0; + // Chrome and Firefox set a `min-width: -webkit-min-content;` on fieldsets, + // so we reset that to ensure it behaves more like a standard block element. + // See https://github.com/twbs/bootstrap/issues/12359. + min-width: 0; } legend { -- cgit v1.2.3 From 400720d00b2ebab99c2d54ad036b0100af499620 Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Mon, 27 Jan 2014 12:24:35 -0800 Subject: Remove optgroup resets from #7611 since Normalize fixes those upstream --- less/forms.less | 7 ------- 1 file changed, 7 deletions(-) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index 687d1f437..c3d4821db 100644 --- a/less/forms.less +++ b/less/forms.less @@ -72,13 +72,6 @@ select[size] { height: auto; } -// Fix optgroup Firefox bug per https://github.com/twbs/bootstrap/issues/7611 -select optgroup { - font-size: inherit; - font-style: inherit; - font-family: inherit; -} - // Focus for file, radio, and checkbox input[type="file"]:focus, input[type="radio"]:focus, -- cgit v1.2.3 From b7ac009a527869dc381b9e4c2272c822d85d2b1c Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Mon, 27 Jan 2014 12:25:39 -0800 Subject: Remove #8350's reset for number inputs since Normalize fixes those upstream --- less/forms.less | 11 ----------- 1 file changed, 11 deletions(-) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index c3d4821db..d0189d0cc 100644 --- a/less/forms.less +++ b/less/forms.less @@ -79,17 +79,6 @@ input[type="checkbox"]:focus { .tab-focus(); } -// Fix for Chrome number input -// -// Setting certain font-sizes causes the `I` bar to appear on hover of the -// decrement button. See https://github.com/twbs/bootstrap/issues/8350. -input[type="number"] { - &::-webkit-outer-spin-button, - &::-webkit-inner-spin-button { - height: auto; - } -} - // Adjust output element output { display: block; -- cgit v1.2.3 From da43f97be170b9c14623d1615721755a9a5959cc Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Fri, 7 Feb 2014 02:08:32 -0800 Subject: Override iOS search input's extra round corners --- less/forms.less | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index d0189d0cc..d97993318 100644 --- a/less/forms.less +++ b/less/forms.less @@ -150,10 +150,24 @@ output { } } + +// Search inputs in iOS +// +// This overrides the extra rounded corners on search inputs in iOS so that our +// `.form-control` class can properly style them. Note that this cannot simply +// be added to `.form-control` as it's not specific enough. For details, see +// https://github.com/twbs/bootstrap/issues/11586. + +input[type="search"] { + -webkit-appearance: none; +} + + // Special styles for iOS date input // // In Mobile Safari, date inputs require a pixel line-height that matches the // given height of the input. + input[type="date"] { line-height: @input-height-base; } -- cgit v1.2.3 From 4d7b2ddba92e47f923d22d9d7b23cb7b0a3e0bc2 Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Fri, 7 Feb 2014 02:58:10 -0800 Subject: Fixes #12486: Restore full width inputs for input groups in inline forms and navbars --- less/forms.less | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index d97993318..df83c9d8d 100644 --- a/less/forms.less +++ b/less/forms.less @@ -133,9 +133,14 @@ output { .placeholder(); // Disabled and read-only inputs - // Note: HTML5 says that controls under a fieldset > legend:first-child won't - // be disabled if the fieldset is disabled. Due to implementation difficulty, - // we don't honor that edge case; we style them as disabled anyway. + // + // HTML5 says that controls under a fieldset > legend:first-child won't be + // disabled if the fieldset is disabled. Due to implementation difficulty, we + // don't honor that edge case; we style them as disabled anyway. + // + // Also note that we include `[disabled]` for IE8. All other browsers take the + // `:disabled` selector. + &:disabled, &[disabled], &[readonly], fieldset[disabled] & { @@ -348,6 +353,10 @@ input[type="checkbox"], width: auto; // Prevent labels from stacking above inputs in `.form-group` vertical-align: middle; } + // Input groups need that 100% width though + .input-group > .form-control { + width: 100%; + } .control-label { margin-bottom: 0; -- cgit v1.2.3 From a2f08158d032c1025ca0c6bf411b8282b606fb7b Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Fri, 7 Feb 2014 15:44:50 -0800 Subject: Nuke shit I added in 4d7b2ddba92e47f923d22d9d7b23cb7b0a3e0bc2 that shouldn't come until v4 --- less/forms.less | 4 ---- 1 file changed, 4 deletions(-) (limited to 'less/forms.less') diff --git a/less/forms.less b/less/forms.less index df83c9d8d..f607b8509 100644 --- a/less/forms.less +++ b/less/forms.less @@ -137,10 +137,6 @@ output { // HTML5 says that controls under a fieldset > legend:first-child won't be // disabled if the fieldset is disabled. Due to implementation difficulty, we // don't honor that edge case; we style them as disabled anyway. - // - // Also note that we include `[disabled]` for IE8. All other browsers take the - // `:disabled` selector. - &:disabled, &[disabled], &[readonly], fieldset[disabled] & { -- cgit v1.2.3