From d7d6384d397c457a69f1ec1ee8ebaf390334111f Mon Sep 17 00:00:00 2001 From: vsn4ik Date: Fri, 5 Dec 2014 23:30:30 +0300 Subject: Fix margin-bottom on dropdown (navbar-fixed-bottom). --- less/navbar.less | 1 + 1 file changed, 1 insertion(+) (limited to 'less') diff --git a/less/navbar.less b/less/navbar.less index 67fd3528f..0c835030e 100644 --- a/less/navbar.less +++ b/less/navbar.less @@ -331,6 +331,7 @@ } // Menu position and menu caret support for dropups via extra dropup class .navbar-fixed-bottom .navbar-nav > li > .dropdown-menu { + margin-bottom: 0; .border-top-radius(@navbar-border-radius); .border-bottom-radius(0); } -- cgit v1.2.3 From cb4c3a0eae9114af42c3be9a5bca134431e3260f Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Thu, 11 Dec 2014 11:45:33 -0800 Subject: glyphicons.less: lowercase F in codepoint number for consistency --- less/glyphicons.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'less') diff --git a/less/glyphicons.less b/less/glyphicons.less index fcdc91de4..eaf9aa229 100644 --- a/less/glyphicons.less +++ b/less/glyphicons.less @@ -239,7 +239,7 @@ .glyphicon-copy { &:before { content: "\e205"; } } .glyphicon-paste { &:before { content: "\e206"; } } .glyphicon-door { &:before { content: "\1f6aa"; } } -.glyphicon-key { &:before { content: "\1F511"; } } +.glyphicon-key { &:before { content: "\1f511"; } } .glyphicon-alert { &:before { content: "\e209"; } } .glyphicon-equalizer { &:before { content: "\e210"; } } .glyphicon-king { &:before { content: "\e211"; } } -- cgit v1.2.3 From bc36e312800e72f1f76515fac8977602b66f012a Mon Sep 17 00:00:00 2001 From: Bastien Date: Fri, 12 Dec 2014 11:07:16 +0100 Subject: Add new brand-primary color in the doc and the true color in comment --- less/variables.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'less') diff --git a/less/variables.less b/less/variables.less index b13be9d44..59747d536 100644 --- a/less/variables.less +++ b/less/variables.less @@ -14,7 +14,7 @@ @gray-light: lighten(@gray-base, 46.7%); // #777 @gray-lighter: lighten(@gray-base, 93.5%); // #eee -@brand-primary: darken(#428bca, 6.5%); +@brand-primary: darken(#428bca, 6.5%); // #337ab7 @brand-success: #5cb85c; @brand-info: #5bc0de; @brand-warning: #f0ad4e; -- cgit v1.2.3 From c8855a7ad120b37fd9a25125f90093478656362f Mon Sep 17 00:00:00 2001 From: Bastien Date: Fri, 12 Dec 2014 14:22:41 +0100 Subject: Add glyphicons fonts in woff2 --- less/glyphicons.less | 1 + 1 file changed, 1 insertion(+) (limited to 'less') diff --git a/less/glyphicons.less b/less/glyphicons.less index eaf9aa229..cb02f9945 100644 --- a/less/glyphicons.less +++ b/less/glyphicons.less @@ -12,6 +12,7 @@ font-family: 'Glyphicons Halflings'; src: url('@{icon-font-path}@{icon-font-name}.eot'); src: url('@{icon-font-path}@{icon-font-name}.eot?#iefix') format('embedded-opentype'), + url('@{icon-font-path}@{icon-font-name}.woff2') format('woff2'), url('@{icon-font-path}@{icon-font-name}.woff') format('woff'), url('@{icon-font-path}@{icon-font-name}.ttf') format('truetype'), url('@{icon-font-path}@{icon-font-name}.svg#@{icon-font-svg-id}') format('svg'); -- cgit v1.2.3 From e674ea553d13429e51044d46ccc6908c341c7fe2 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 15 Dec 2014 11:54:50 -0800 Subject: Add docs for #15340 border-radius CSS property doesn't affect in some browsers. Closes #15340. [skip sauce] [skip validator] --- less/variables.less | 1 + 1 file changed, 1 insertion(+) (limited to 'less') diff --git a/less/variables.less b/less/variables.less index 59747d536..4c51ce96f 100644 --- a/less/variables.less +++ b/less/variables.less @@ -187,6 +187,7 @@ // TODO: Rename `@input-border-radius` to `@input-border-radius-base` in v4 //** Default `.form-control` border radius +// This has no effect on ``s in CSS. @input-border-radius: @border-radius-base; //** Large `.form-control` border radius @input-border-radius-large: @border-radius-large; -- cgit v1.2.3 From 75517230540feabc270ff089c0008380a6dc0c37 Mon Sep 17 00:00:00 2001 From: Nicole Sullivan Date: Wed, 17 Dec 2014 11:19:06 -0500 Subject: Fixes #14990: Media bodies take up full width Signed-off-by: Beatrice Peng --- less/media.less | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'less') diff --git a/less/media.less b/less/media.less index ee1a600ea..a6bf78192 100644 --- a/less/media.less +++ b/less/media.less @@ -13,6 +13,10 @@ overflow: hidden; } +.media-body { + width: 10000px; +} + .media-object { display: block; } -- cgit v1.2.3 From b8844f639fcddb2ef70758ad4b0dcf89f9792d73 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Fri, 19 Dec 2014 18:19:18 -0800 Subject: fix "propertes" typos in comments --- less/popovers.less | 2 +- less/tooltip.less | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'less') diff --git a/less/popovers.less b/less/popovers.less index 53ee0ecd7..2748eead1 100644 --- a/less/popovers.less +++ b/less/popovers.less @@ -11,7 +11,7 @@ display: none; max-width: @popover-max-width; padding: 1px; - // Reset font and text propertes given new insertion method + // Reset font and text properties given new insertion method font-family: @font-family-base; font-size: @font-size-base; font-weight: normal; diff --git a/less/tooltip.less b/less/tooltip.less index 9c2a37fd4..3ebfdcdff 100644 --- a/less/tooltip.less +++ b/less/tooltip.less @@ -9,7 +9,7 @@ z-index: @zindex-tooltip; display: block; visibility: visible; - // Reset font and text propertes given new insertion method + // Reset font and text properties given new insertion method font-family: @font-family-base; font-size: @font-size-small; font-weight: normal; -- cgit v1.2.3 From c27585098278c3629377de5fc5948e1d8fddb9ae Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 22 Dec 2014 14:57:40 -0800 Subject: Remove reference to old fixed WebKit bug in Less comment. Per https://github.com/twbs/bootstrap/issues/1969#issuecomment-36971094 [skip sauce] [skip validator] --- less/forms.less | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'less') diff --git a/less/forms.less b/less/forms.less index 085d9d47c..c57c2beb0 100644 --- a/less/forms.less +++ b/less/forms.less @@ -461,8 +461,7 @@ input[type="checkbox"] { } // Remove default margin on radios/checkboxes that were used for stacking, and - // then undo the floating of radios and checkboxes to match (which also avoids - // a bug in WebKit: https://github.com/twbs/bootstrap/issues/1969). + // then undo the floating of radios and checkboxes to match. .radio, .checkbox { display: inline-block; -- cgit v1.2.3 From e5051e76feaeafb0b999b0b2662f0c2669c48d10 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 22 Dec 2014 15:02:34 -0800 Subject: Reference iOS Safari temporal input bug in explanatory Less comment Refs #11266, #13098, #15415 [skip sauce] [skip validator] --- less/forms.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'less') diff --git a/less/forms.less b/less/forms.less index c57c2beb0..f37d1c8f8 100644 --- a/less/forms.less +++ b/less/forms.less @@ -170,7 +170,7 @@ input[type="search"] { // In Mobile Safari, setting `display: block` on temporal inputs causes the // text within the input to become vertically misaligned. As a workaround, we // set a pixel line-height that matches the given height of the input, but only -// for Safari. +// for Safari. See https://bugs.webkit.org/show_bug.cgi?id=139848 @media screen and (-webkit-min-device-pixel-ratio: 0) { input[type="date"], -- cgit v1.2.3 From 15c9c3aef7f047c9cce45fd33ada799e99fbd390 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 22 Dec 2014 16:54:50 -0800 Subject: add more refs to browser-related bugs in Less comments --- less/carousel.less | 1 + less/close.less | 1 + less/forms.less | 2 +- less/theme.less | 4 ++-- 4 files changed, 5 insertions(+), 3 deletions(-) (limited to 'less') diff --git a/less/carousel.less b/less/carousel.less index a28e397a5..4bbe946d3 100644 --- a/less/carousel.less +++ b/less/carousel.less @@ -196,6 +196,7 @@ // Internet Explorer 8-9 does not support clicks on elements without a set // `background-color`. We cannot use `filter` since that's not viewed as a // background color by the browser. Thus, a hack is needed. + // See https://developer.mozilla.org/en-US/docs/Web/Events/click#Internet_Explorer // // For IE8, we set solid black as it doesn't support `rgba()`. For IE9, we // set alpha transparency for the best results possible. diff --git a/less/close.less b/less/close.less index 9b4e74f2b..6d5bfe087 100644 --- a/less/close.less +++ b/less/close.less @@ -23,6 +23,7 @@ // Additional properties for button version // iOS requires the button element instead of an anchor tag. // If you want the anchor version, it requires `href="#"`. + // See https://developer.mozilla.org/en-US/docs/Web/Events/click#Safari_Mobile button& { padding: 0; cursor: pointer; diff --git a/less/forms.less b/less/forms.less index f37d1c8f8..d1e29b118 100644 --- a/less/forms.less +++ b/less/forms.less @@ -143,7 +143,7 @@ output { fieldset[disabled] & { cursor: @cursor-disabled; background-color: @input-bg-disabled; - opacity: 1; // iOS fix for unreadable disabled content + opacity: 1; // iOS fix for unreadable disabled content; see https://github.com/twbs/bootstrap/issues/11655 } // Reset height for `textarea`s diff --git a/less/theme.less b/less/theme.less index a15d16ecd..3673accc0 100644 --- a/less/theme.less +++ b/less/theme.less @@ -36,7 +36,7 @@ // Mixin for generating new styles .btn-styles(@btn-color: #555) { #gradient > .vertical(@start-color: @btn-color; @end-color: darken(@btn-color, 12%)); - .reset-filter(); // Disable gradients for IE9 because filter bleeds through rounded corners + .reset-filter(); // Disable gradients for IE9 because filter bleeds through rounded corners; see https://github.com/twbs/bootstrap/issues/10620 background-repeat: repeat-x; border-color: darken(@btn-color, 14%); @@ -130,7 +130,7 @@ // Inverted navbar .navbar-inverse { #gradient > .vertical(@start-color: lighten(@navbar-inverse-bg, 10%); @end-color: @navbar-inverse-bg); - .reset-filter(); // Remove gradient in IE<10 to fix bug where dropdowns don't get triggered + .reset-filter(); // Remove gradient in IE<10 to fix bug where dropdowns don't get triggered; see https://github.com/twbs/bootstrap/issues/10257 .navbar-nav > .open > a, .navbar-nav > .active > a { -- cgit v1.2.3 From d84f726da4f55434de853202961310d153f35739 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 22 Dec 2014 17:02:29 -0800 Subject: IE11 & current Firefox are still affected. Refs #11623 --- less/tables.less | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'less') diff --git a/less/tables.less b/less/tables.less index ba24498a3..3c801aedb 100644 --- a/less/tables.less +++ b/less/tables.less @@ -133,7 +133,7 @@ th { // Reset default table behavior table col[class*="col-"] { - position: static; // Prevent border hiding in Firefox and IE9/10 (see https://github.com/twbs/bootstrap/issues/11623) + position: static; // Prevent border hiding in Firefox and IE9-11 (see https://github.com/twbs/bootstrap/issues/11623) float: none; display: table-column; } @@ -141,7 +141,7 @@ table { td, th { &[class*="col-"] { - position: static; // Prevent border hiding in Firefox and IE9/10 (see https://github.com/twbs/bootstrap/issues/11623) + position: static; // Prevent border hiding in Firefox and IE9-11 (see https://github.com/twbs/bootstrap/issues/11623) float: none; display: table-cell; } -- cgit v1.2.3 From 75ec7393ec2940cb1f015dc2d002328833ad3ef8 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 22 Dec 2014 17:03:45 -0800 Subject: Add summary of #11526 to explanatory Less comment [skip sauce] [skip validator] --- less/mixins/vendor-prefixes.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'less') diff --git a/less/mixins/vendor-prefixes.less b/less/mixins/vendor-prefixes.less index 31f8e2f7a..afd3331c3 100644 --- a/less/mixins/vendor-prefixes.less +++ b/less/mixins/vendor-prefixes.less @@ -102,7 +102,7 @@ // Firefox &::-moz-placeholder { color: @color; - opacity: 1; // See https://github.com/twbs/bootstrap/pull/11526 + opacity: 1; // Override Firefox's unusual default opacity; see https://github.com/twbs/bootstrap/pull/11526 } &:-ms-input-placeholder { color: @color; } // Internet Explorer 10+ &::-webkit-input-placeholder { color: @color; } // Safari and Chrome -- cgit v1.2.3 From c41970c5797cd1c3b61a5396031a3258c9c07705 Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Mon, 22 Dec 2014 19:28:29 -0800 Subject: Fixes #15422: Alternate fix for temporal input sizing in input groups --- less/forms.less | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) (limited to 'less') diff --git a/less/forms.less b/less/forms.less index f37d1c8f8..d2ea45036 100644 --- a/less/forms.less +++ b/less/forms.less @@ -178,18 +178,16 @@ input[type="search"] { input[type="datetime-local"], input[type="month"] { line-height: @input-height-base; - } - input[type="date"].input-sm, - input[type="time"].input-sm, - input[type="datetime-local"].input-sm, - input[type="month"].input-sm { - line-height: @input-height-small; - } - input[type="date"].input-lg, - input[type="time"].input-lg, - input[type="datetime-local"].input-lg, - input[type="month"].input-lg { - line-height: @input-height-large; + + &.input-sm, + .input-group-sm & { + line-height: @input-height-small; + } + + &.input-lg, + .input-group-lg & { + line-height: @input-height-large; + } } } -- cgit v1.2.3 From ad138ed885626280be7e9c55b1719b1282e73817 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 29 Dec 2014 16:44:33 -0800 Subject: Disable .glyphicon-door & .glyphicon-key for the time being Closes #15419 Refs #10106 --- less/glyphicons.less | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'less') diff --git a/less/glyphicons.less b/less/glyphicons.less index cb02f9945..8b25f89a5 100644 --- a/less/glyphicons.less +++ b/less/glyphicons.less @@ -239,8 +239,14 @@ .glyphicon-level-up { &:before { content: "\e204"; } } .glyphicon-copy { &:before { content: "\e205"; } } .glyphicon-paste { &:before { content: "\e206"; } } -.glyphicon-door { &:before { content: "\1f6aa"; } } -.glyphicon-key { &:before { content: "\1f511"; } } +// The following 2 Glyphicons are omitted for the time being because +// they currently use Unicode codepoints that are outside the +// Basic Multilingual Plane (BMP). Older buggy versions of WebKit can't handle +// non-BMP codepoints in CSS string escapes, and thus can't display these two icons. +// Notably, the bug affects some older versions of the Android Browser. +// More info: https://github.com/twbs/bootstrap/issues/10106 +// .glyphicon-door { &:before { content: "\1f6aa"; } } +// .glyphicon-key { &:before { content: "\1f511"; } } .glyphicon-alert { &:before { content: "\e209"; } } .glyphicon-equalizer { &:before { content: "\e210"; } } .glyphicon-king { &:before { content: "\e211"; } } -- cgit v1.2.3 From ba8a40e7888f80ee22760b36e032417804ce3cec Mon Sep 17 00:00:00 2001 From: liias Date: Fri, 2 Jan 2015 11:28:09 +0200 Subject: Add .disabled class styling for .btn-styles Bootstrap itself has .btn-default.disabled styled. IE8 with angularjs has some weird behaviour if anchor has disabled attribute set, so I use disabled class as a workaround and assume the .disabled class styles the buttons the same as disabled attribute would. --- less/theme.less | 1 + 1 file changed, 1 insertion(+) (limited to 'less') diff --git a/less/theme.less b/less/theme.less index 3673accc0..6f2eb6212 100644 --- a/less/theme.less +++ b/less/theme.less @@ -52,6 +52,7 @@ border-color: darken(@btn-color, 14%); } + &.disabled, &:disabled, &[disabled] { background-color: darken(@btn-color, 12%); -- cgit v1.2.3 From 0c8cb3f2dca3aa2dafec5762092fcf728dd2f962 Mon Sep 17 00:00:00 2001 From: Lee Penkman Date: Tue, 13 Jan 2015 14:18:52 +1300 Subject: Fix table-striped to work with bootstraps tooltips on rows --- less/tables.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'less') diff --git a/less/tables.less b/less/tables.less index 3c801aedb..2242c0368 100644 --- a/less/tables.less +++ b/less/tables.less @@ -111,7 +111,7 @@ th { // Default zebra-stripe styles (alternating gray and transparent backgrounds) .table-striped { - > tbody > tr:nth-child(odd) { + > tbody > tr:nth-of-type(odd) { background-color: @table-bg-accent; } } -- cgit v1.2.3 From 65721f531536e05026b1ae5f0359955c78d13156 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Wed, 14 Jan 2015 14:42:22 -0800 Subject: Use @link-hover-decoration for .btn-link too; fixes #15565 [skip sauce] [skip validator] --- less/buttons.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'less') diff --git a/less/buttons.less b/less/buttons.less index 40553c638..5a746049e 100644 --- a/less/buttons.less +++ b/less/buttons.less @@ -107,7 +107,7 @@ &:hover, &:focus { color: @link-hover-color; - text-decoration: underline; + text-decoration: @link-hover-decoration; background-color: transparent; } &[disabled], -- cgit v1.2.3 From bb479b8f4775507b5fe817b1724ccca335bc135c Mon Sep 17 00:00:00 2001 From: Kevin Jannis Date: Thu, 15 Jan 2015 20:17:02 +0100 Subject: Added blank line between selectors in jumbotron --- less/jumbotron.less | 1 + 1 file changed, 1 insertion(+) (limited to 'less') diff --git a/less/jumbotron.less b/less/jumbotron.less index 340d4a372..d6410238a 100644 --- a/less/jumbotron.less +++ b/less/jumbotron.less @@ -13,6 +13,7 @@ .h1 { color: @jumbotron-heading-color; } + p { margin-bottom: (@jumbotron-padding / 2); font-size: @jumbotron-font-size; -- cgit v1.2.3 From dbffb0b47f573097ec2a0500720accb6aeeab72e Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Thu, 15 Jan 2015 16:03:13 -0800 Subject: Fixes #15536, #15559: Add .form-group sizing support to .form-control-static --- less/forms.less | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'less') diff --git a/less/forms.less b/less/forms.less index bf15cc8a9..c45d6bdff 100644 --- a/less/forms.less +++ b/less/forms.less @@ -318,6 +318,12 @@ input[type="checkbox"] { .form-control { .input-size(@input-height-small; @padding-small-vertical; @padding-small-horizontal; @font-size-small; @line-height-small; @input-border-radius-small); } + .form-control-static { + height: @input-height-small; + padding: @padding-small-vertical @padding-small-horizontal; + font-size: @font-size-small; + line-height: @line-height-small; + } } .input-lg { @@ -327,6 +333,12 @@ input[type="checkbox"] { .form-control { .input-size(@input-height-large; @padding-large-vertical; @padding-large-horizontal; @font-size-large; @line-height-large; @input-border-radius-large); } + .form-control-static { + height: @input-height-large; + padding: @padding-large-vertical @padding-large-horizontal; + font-size: @font-size-large; + line-height: @line-height-large; + } } -- cgit v1.2.3 From 1c131fb95d312c0f555ffd3c71443bf4eaf96132 Mon Sep 17 00:00:00 2001 From: Kevin Jannis Date: Fri, 16 Jan 2015 10:06:35 +0100 Subject: Added blank lines between selectors for alerts --- less/alerts.less | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'less') diff --git a/less/alerts.less b/less/alerts.less index df070b8ab..5618bfcec 100644 --- a/less/alerts.less +++ b/less/alerts.less @@ -18,6 +18,7 @@ // Specified for the h4 to prevent conflicts of changing @headings-color color: inherit; } + // Provide class for links that match alerts .alert-link { font-weight: @alert-link-font-weight; @@ -28,6 +29,7 @@ > ul { margin-bottom: 0; } + > p + p { margin-top: 5px; } @@ -57,12 +59,15 @@ .alert-success { .alert-variant(@alert-success-bg; @alert-success-border; @alert-success-text); } + .alert-info { .alert-variant(@alert-info-bg; @alert-info-border; @alert-info-text); } + .alert-warning { .alert-variant(@alert-warning-bg; @alert-warning-border; @alert-warning-text); } + .alert-danger { .alert-variant(@alert-danger-bg; @alert-danger-border; @alert-danger-text); } -- cgit v1.2.3 From 85a6595a716fa6549383356e75c2091bfdfee585 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Fri, 16 Jan 2015 11:02:51 -0800 Subject: .form-control: add note about s in some browsers, due to the limited stylability of