From abca00870f862d024a943b2c563bd42ff3f8418f Mon Sep 17 00:00:00 2001 From: Julian Thilo Date: Sun, 18 Aug 2013 23:05:56 +0200 Subject: Add a .navbar-default class for default colors * Extract color styles from .navbar { } and put them into .navbar-default { } * Change variable names * Change the docs accordingly (i.e., add the .navbar-default class to all default navbars) * Change customizer accordingly --- less/navbar.less | 233 +++++++++++++++++++++++++++++++--------------------- less/variables.less | 32 ++++---- 2 files changed, 154 insertions(+), 111 deletions(-) (limited to 'less') diff --git a/less/navbar.less b/less/navbar.less index 0554f5fbf..454e9c1ce 100644 --- a/less/navbar.less +++ b/less/navbar.less @@ -12,8 +12,7 @@ position: relative; min-height: @navbar-height; // Ensure a navbar always shows (e.g., without a .navbar-brand in collapsed mode) margin-bottom: @navbar-margin-bottom; - background-color: @navbar-bg; - border: 1px solid @navbar-border; + border: 1px solid transparent; // Prevent floats from breaking the navbar .clearfix(); @@ -53,7 +52,7 @@ overflow-x: visible; padding-right: @navbar-padding-horizontal; padding-left: @navbar-padding-horizontal; - border-top: 1px solid darken(@navbar-bg, 7%); + border-top: 1px solid transparent; box-shadow: inset 0 1px 0 rgba(255,255,255,.1); .clearfix(); -webkit-overflow-scrolling: touch; @@ -145,12 +144,9 @@ padding: @navbar-padding-vertical @navbar-padding-horizontal; font-size: @font-size-large; line-height: @line-height-computed; - color: @navbar-brand-color; &:hover, &:focus { - color: @navbar-brand-hover-color; text-decoration: none; - background-color: @navbar-brand-hover-bg; } @media (min-width: @grid-float-breakpoint) { @@ -173,20 +169,14 @@ padding: 9px 10px; .navbar-vertical-align(34px); background-color: transparent; - border: 1px solid @navbar-toggle-border-color; + border: 1px solid transparent; border-radius: @border-radius-base; - &:hover, - &:focus { - background-color: @navbar-toggle-hover-bg; - } - // Bars .icon-bar { display: block; width: 22px; height: 2px; - background-color: @navbar-toggle-icon-bar-bg; border-radius: 1px; } .icon-bar + .icon-bar { @@ -210,29 +200,7 @@ > li > a { padding-top: 10px; padding-bottom: 10px; - color: @navbar-link-color; line-height: @line-height-computed; - &:hover, - &:focus { - color: @navbar-link-hover-color; - background-color: @navbar-link-hover-bg; - } - } - > .active > a { - &, - &:hover, - &:focus { - color: @navbar-link-active-color; - background-color: @navbar-link-active-bg; - } - } - > .disabled > a { - &, - &:hover, - &:focus { - color: @navbar-link-disabled-color; - background-color: @navbar-link-disabled-bg; - } } @media (max-width: @screen-xs-max) { @@ -250,31 +218,12 @@ padding: 5px 15px 5px 25px; } > li > a { - color: @navbar-link-color; line-height: @line-height-computed; &:hover, &:focus { - color: @navbar-link-hover-color; - background-color: @navbar-link-hover-bg; background-image: none; } } - > .active > a { - &, - &:hover, - &:focus { - color: @navbar-link-active-color; - background-color: @navbar-link-active-bg; - } - } - > .disabled > a { - &, - &:hover, - &:focus { - color: @navbar-link-disabled-color; - background-color: @navbar-link-disabled-bg; - } - } } } @@ -321,8 +270,8 @@ margin-left: -@navbar-padding-horizontal; margin-right: -@navbar-padding-horizontal; padding: 10px @navbar-padding-horizontal; - border-top: 1px solid darken(@navbar-bg, 7%); - border-bottom: 1px solid darken(@navbar-bg, 7%); + border-top: 1px solid transparent; + border-bottom: 1px solid transparent; @shadow: inset 0 1px 0 rgba(255,255,255,.1), 0 1px 0 rgba(255,255,255,.1); .box-shadow(@shadow); @@ -363,34 +312,6 @@ .border-bottom-radius(0); } -// Dropdown menu items and carets -.navbar-nav { - // Caret should match text color on hover - > .dropdown > a:hover .caret, - > .dropdown > a:focus .caret { - border-top-color: @navbar-link-hover-color; - border-bottom-color: @navbar-link-hover-color; - } - - // Remove background color from open dropdown - > .open > a { - &, - &:hover, - &:focus { - background-color: @navbar-link-active-bg; - color: @navbar-link-active-color; - .caret { - border-top-color: @navbar-link-active-color; - border-bottom-color: @navbar-link-active-color; - } - } - } - > .dropdown > a .caret { - border-top-color: @navbar-link-color; - border-bottom-color: @navbar-link-color; - } -} - // Right aligned menus need alt position .navbar-nav.pull-right > li > .dropdown-menu, .navbar-nav > li > .dropdown-menu.pull-right { @@ -414,7 +335,6 @@ .navbar-text { float: left; - color: @navbar-color; .navbar-vertical-align(@line-height-computed); @media (min-width: @grid-float-breakpoint) { @@ -423,22 +343,145 @@ } } +// Alternate navbars +// -------------------------------------------------- -// Links in navbars -// -// Add a class to ensure links outside the navbar nav are colored correctly. +// Default navbar +.navbar-default { + background-color: @navbar-bg; + border-color: @navbar-border; + + .navbar-brand { + color: @navbar-brand-color; + &:hover, + &:focus { + color: @navbar-brand-hover-color; + background-color: @navbar-brand-hover-bg; + } + } -// Default navbar variables -.navbar-link { - color: @navbar-link-color; - &:hover { - color: @navbar-link-hover-color; + .navbar-text { + color: @navbar-color; + } + + .navbar-nav { + > li > a { + color: @navbar-link-color; + + &:hover, + &:focus { + color: @navbar-link-hover-color; + background-color: @navbar-link-hover-bg; + } + } + > .active > a { + &, + &:hover, + &:focus { + color: @navbar-link-active-color; + background-color: @navbar-link-active-bg; + } + } + > .disabled > a { + &, + &:hover, + &:focus { + color: @navbar-link-disabled-color; + background-color: @navbar-link-disabled-bg; + } + } } -} + .navbar-toggle { + border-color: @navbar-toggle-border-color; + &:hover, + &:focus { + background-color: @navbar-toggle-hover-bg; + } + .icon-bar { + background-color: @navbar-toggle-icon-bar-bg; + } + } + + .navbar-collapse, + .navbar-form { + border-color: darken(@navbar-bg, 7%); + } + + // Dropdown menu items and carets + .navbar-nav { + // Caret should match text color on hover + > .dropdown > a:hover .caret, + > .dropdown > a:focus .caret { + border-top-color: @navbar-link-hover-color; + border-bottom-color: @navbar-link-hover-color; + } + + // Remove background color from open dropdown + > .open > a { + &, + &:hover, + &:focus { + background-color: @navbar-link-active-bg; + color: @navbar-link-active-color; + .caret { + border-top-color: @navbar-link-active-color; + border-bottom-color: @navbar-link-active-color; + } + } + } + > .dropdown > a .caret { + border-top-color: @navbar-link-color; + border-bottom-color: @navbar-link-color; + } + + + @media (max-width: @screen-xs-max) { + // Dropdowns get custom display when collapsed + .open .dropdown-menu { + > li > a { + color: @navbar-link-color; + &:hover, + &:focus { + color: @navbar-link-hover-color; + background-color: @navbar-link-hover-bg; + } + } + > .active > a { + &, + &:hover, + &:focus { + color: @navbar-link-active-color; + background-color: @navbar-link-active-bg; + } + } + > .disabled > a { + &, + &:hover, + &:focus { + color: @navbar-link-disabled-color; + background-color: @navbar-link-disabled-bg; + } + } + } + } + } + + + // Links in navbars + // + // Add a class to ensure links outside the navbar nav are colored correctly. + + .navbar-link { + color: @navbar-link-color; + &:hover { + color: @navbar-link-hover-color; + } + } + +} // Inverse navbar -// -------------------------------------------------- .navbar-inverse { background-color: @navbar-inverse-bg; diff --git a/less/variables.less b/less/variables.less index 3ba25f768..da0786637 100644 --- a/less/variables.less +++ b/less/variables.less @@ -237,31 +237,31 @@ // Basics of a navbar @navbar-height: 50px; @navbar-margin-bottom: @line-height-computed; -@navbar-color: #777; -@navbar-bg: #f8f8f8; -@navbar-border: darken(@navbar-bg, 6.5%); +@navbar-default-color: #777; +@navbar-default-bg: #f8f8f8; +@navbar-default-border: darken(@navbar-bg, 6.5%); @navbar-border-radius: @border-radius-base; @navbar-padding-horizontal: floor(@grid-gutter-width / 2); @navbar-padding-vertical: ((@navbar-height - @line-height-computed) / 2); // Navbar links -@navbar-link-color: #777; -@navbar-link-hover-color: #333; -@navbar-link-hover-bg: transparent; -@navbar-link-active-color: #555; -@navbar-link-active-bg: darken(@navbar-bg, 6.5%); -@navbar-link-disabled-color: #ccc; -@navbar-link-disabled-bg: transparent; +@navbar-default-link-color: #777; +@navbar-default-link-hover-color: #333; +@navbar-default-link-hover-bg: transparent; +@navbar-default-link-active-color: #555; +@navbar-default-link-active-bg: darken(@navbar-bg, 6.5%); +@navbar-default-link-disabled-color: #ccc; +@navbar-default-link-disabled-bg: transparent; // Navbar brand label -@navbar-brand-color: @navbar-link-color; -@navbar-brand-hover-color: darken(@navbar-link-color, 10%); -@navbar-brand-hover-bg: transparent; +@navbar-default-brand-color: @navbar-link-color; +@navbar-default-brand-hover-color: darken(@navbar-link-color, 10%); +@navbar-default-brand-hover-bg: transparent; // Navbar toggle -@navbar-toggle-hover-bg: #ddd; -@navbar-toggle-icon-bar-bg: #ccc; -@navbar-toggle-border-color: #ddd; +@navbar-default-toggle-hover-bg: #ddd; +@navbar-default-toggle-icon-bar-bg: #ccc; +@navbar-default-toggle-border-color: #ddd; // Inverted navbar -- cgit v1.2.3 From 546b2cc614ed57f1068eb455b592d6966d49d2d3 Mon Sep 17 00:00:00 2001 From: Julian Thilo Date: Sun, 18 Aug 2013 23:30:40 +0200 Subject: Fix some forgotten things for navbar-default New variable names were missing here and there. --- less/navbar.less | 68 ++++++++++++++++++++++++++--------------------------- less/theme.less | 4 ++-- less/variables.less | 8 +++---- 3 files changed, 40 insertions(+), 40 deletions(-) (limited to 'less') diff --git a/less/navbar.less b/less/navbar.less index 454e9c1ce..754b018ad 100644 --- a/less/navbar.less +++ b/less/navbar.less @@ -348,64 +348,64 @@ // Default navbar .navbar-default { - background-color: @navbar-bg; - border-color: @navbar-border; + background-color: @navbar-default-bg; + border-color: @navbar-default-border; .navbar-brand { - color: @navbar-brand-color; + color: @navbar-default-brand-color; &:hover, &:focus { - color: @navbar-brand-hover-color; - background-color: @navbar-brand-hover-bg; + color: @navbar-default-brand-hover-color; + background-color: @navbar-default-brand-hover-bg; } } .navbar-text { - color: @navbar-color; + color: @navbar-default-color; } .navbar-nav { > li > a { - color: @navbar-link-color; + color: @navbar-default-link-color; &:hover, &:focus { - color: @navbar-link-hover-color; - background-color: @navbar-link-hover-bg; + color: @navbar-default-link-hover-color; + background-color: @navbar-default-link-hover-bg; } } > .active > a { &, &:hover, &:focus { - color: @navbar-link-active-color; - background-color: @navbar-link-active-bg; + color: @navbar-default-link-active-color; + background-color: @navbar-default-link-active-bg; } } > .disabled > a { &, &:hover, &:focus { - color: @navbar-link-disabled-color; - background-color: @navbar-link-disabled-bg; + color: @navbar-default-link-disabled-color; + background-color: @navbar-default-link-disabled-bg; } } } .navbar-toggle { - border-color: @navbar-toggle-border-color; + border-color: @navbar-default-toggle-border-color; &:hover, &:focus { - background-color: @navbar-toggle-hover-bg; + background-color: @navbar-default-toggle-hover-bg; } .icon-bar { - background-color: @navbar-toggle-icon-bar-bg; + background-color: @navbar-default-toggle-icon-bar-bg; } } .navbar-collapse, .navbar-form { - border-color: darken(@navbar-bg, 7%); + border-color: darken(@navbar-default-bg, 7%); } // Dropdown menu items and carets @@ -413,8 +413,8 @@ // Caret should match text color on hover > .dropdown > a:hover .caret, > .dropdown > a:focus .caret { - border-top-color: @navbar-link-hover-color; - border-bottom-color: @navbar-link-hover-color; + border-top-color: @navbar-default-link-hover-color; + border-bottom-color: @navbar-default-link-hover-color; } // Remove background color from open dropdown @@ -422,17 +422,17 @@ &, &:hover, &:focus { - background-color: @navbar-link-active-bg; - color: @navbar-link-active-color; + background-color: @navbar-default-link-active-bg; + color: @navbar-default-link-active-color; .caret { - border-top-color: @navbar-link-active-color; - border-bottom-color: @navbar-link-active-color; + border-top-color: @navbar-default-link-active-color; + border-bottom-color: @navbar-default-link-active-color; } } } > .dropdown > a .caret { - border-top-color: @navbar-link-color; - border-bottom-color: @navbar-link-color; + border-top-color: @navbar-default-link-color; + border-bottom-color: @navbar-default-link-color; } @@ -440,27 +440,27 @@ // Dropdowns get custom display when collapsed .open .dropdown-menu { > li > a { - color: @navbar-link-color; + color: @navbar-default-link-color; &:hover, &:focus { - color: @navbar-link-hover-color; - background-color: @navbar-link-hover-bg; + color: @navbar-default-link-hover-color; + background-color: @navbar-default-link-hover-bg; } } > .active > a { &, &:hover, &:focus { - color: @navbar-link-active-color; - background-color: @navbar-link-active-bg; + color: @navbar-default-link-active-color; + background-color: @navbar-default-link-active-bg; } } > .disabled > a { &, &:hover, &:focus { - color: @navbar-link-disabled-color; - background-color: @navbar-link-disabled-bg; + color: @navbar-default-link-disabled-color; + background-color: @navbar-default-link-disabled-bg; } } } @@ -473,9 +473,9 @@ // Add a class to ensure links outside the navbar nav are colored correctly. .navbar-link { - color: @navbar-link-color; + color: @navbar-default-link-color; &:hover { - color: @navbar-link-hover-color; + color: @navbar-default-link-hover-color; } } diff --git a/less/theme.less b/less/theme.less index f7e503644..d2f98f2fb 100644 --- a/less/theme.less +++ b/less/theme.less @@ -93,13 +93,13 @@ // Basic navbar .navbar { - #gradient > .vertical(@start-color: lighten(@navbar-bg, 10%); @end-color: @navbar-bg;); + #gradient > .vertical(@start-color: lighten(@navbar-default-bg, 10%); @end-color: @navbar-default-bg;); border-radius: @navbar-border-radius; @shadow: inset 0 1px 0 rgba(255,255,255,.15), 0 1px 5px rgba(0,0,0,.075); .box-shadow(@shadow); .navbar-nav > .active > a { - background-color: @navbar-bg; + background-color: @navbar-default-bg; } } .navbar-brand, diff --git a/less/variables.less b/less/variables.less index da0786637..53aad251b 100644 --- a/less/variables.less +++ b/less/variables.less @@ -239,7 +239,7 @@ @navbar-margin-bottom: @line-height-computed; @navbar-default-color: #777; @navbar-default-bg: #f8f8f8; -@navbar-default-border: darken(@navbar-bg, 6.5%); +@navbar-default-border: darken(@navbar-default-bg, 6.5%); @navbar-border-radius: @border-radius-base; @navbar-padding-horizontal: floor(@grid-gutter-width / 2); @navbar-padding-vertical: ((@navbar-height - @line-height-computed) / 2); @@ -249,13 +249,13 @@ @navbar-default-link-hover-color: #333; @navbar-default-link-hover-bg: transparent; @navbar-default-link-active-color: #555; -@navbar-default-link-active-bg: darken(@navbar-bg, 6.5%); +@navbar-default-link-active-bg: darken(@navbar-default-bg, 6.5%); @navbar-default-link-disabled-color: #ccc; @navbar-default-link-disabled-bg: transparent; // Navbar brand label -@navbar-default-brand-color: @navbar-link-color; -@navbar-default-brand-hover-color: darken(@navbar-link-color, 10%); +@navbar-default-brand-color: @navbar-default-link-color; +@navbar-default-brand-hover-color: darken(@navbar-default-link-color, 10%); @navbar-default-brand-hover-bg: transparent; // Navbar toggle -- cgit v1.2.3