From 27e4e97840861446eb4f33770b1ad083c8717324 Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Sun, 23 Aug 2015 00:28:02 -0700 Subject: there is no navbar default for this --- scss/_navbar.scss | 1 - 1 file changed, 1 deletion(-) (limited to 'scss/_navbar.scss') diff --git a/scss/_navbar.scss b/scss/_navbar.scss index 61c212144..36d9abf03 100644 --- a/scss/_navbar.scss +++ b/scss/_navbar.scss @@ -35,7 +35,6 @@ right: 0; left: 0; z-index: $zindex-navbar-fixed; - margin-bottom: 0; // override .navbar defaults // Undo the rounded corners @include media-breakpoint-up(sm) { -- cgit v1.2.3 From b2dccb15d79085af2a507b6b9f2c35c0e5770ffa Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Sun, 23 Aug 2015 01:00:22 -0700 Subject: fix majority of scss linter errors --- scss/_navbar.scss | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'scss/_navbar.scss') diff --git a/scss/_navbar.scss b/scss/_navbar.scss index 36d9abf03..f196b8c7e 100644 --- a/scss/_navbar.scss +++ b/scss/_navbar.scss @@ -69,9 +69,9 @@ .navbar-brand { float: left; - margin-right: 1rem; padding-top: .25rem; padding-bottom: .25rem; + margin-right: 1rem; font-size: $font-size-lg; @include hover-focus { @@ -89,12 +89,12 @@ width: 1px; padding-top: .425rem; padding-bottom: .425rem; - overflow: hidden; margin-left: $navbar-padding-horizontal; margin-right: $navbar-padding-horizontal; + overflow: hidden; &:before { - content: '\00a0'; + content: "\00a0"; } } -- cgit v1.2.3 From a5bfbe0fcad5334e68d236f0603b685441829656 Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Sun, 23 Aug 2015 01:12:00 -0700 Subject: fix remaining scss lint errors --- scss/_navbar.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'scss/_navbar.scss') diff --git a/scss/_navbar.scss b/scss/_navbar.scss index f196b8c7e..94cf1004b 100644 --- a/scss/_navbar.scss +++ b/scss/_navbar.scss @@ -89,8 +89,8 @@ width: 1px; padding-top: .425rem; padding-bottom: .425rem; - margin-left: $navbar-padding-horizontal; margin-right: $navbar-padding-horizontal; + margin-left: $navbar-padding-horizontal; overflow: hidden; &:before { -- cgit v1.2.3 From d51f0a4f816534e8c39ff58d8d4c562d2dd568fb Mon Sep 17 00:00:00 2001 From: Kevin Kirsche Date: Wed, 19 Aug 2015 16:31:31 -0400 Subject: Use double colons for psuedo elements Fix #17052 --- scss/_navbar.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'scss/_navbar.scss') diff --git a/scss/_navbar.scss b/scss/_navbar.scss index 94cf1004b..7fbd4448e 100644 --- a/scss/_navbar.scss +++ b/scss/_navbar.scss @@ -93,7 +93,7 @@ margin-left: $navbar-padding-horizontal; overflow: hidden; - &:before { + &::before { content: "\00a0"; } } -- cgit v1.2.3 From 319009a72b8889d8db5b84ad69ce4118cdf3143f Mon Sep 17 00:00:00 2001 From: Luke Bonaccorsi Date: Wed, 2 Sep 2015 22:08:52 +0100 Subject: Added .navbar-toggleable-md class In Bootstrap 3, the menu collapsed on the -sm- breakpoint, I believe the equivalent of this breakpoint in Bootstrap 4 is actually the -md- breakpoint. The navbar currently has no option to collapse at the -md- breakpoint and I'd like to add this. --- scss/_navbar.scss | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'scss/_navbar.scss') diff --git a/scss/_navbar.scss b/scss/_navbar.scss index 7fbd4448e..d812212a0 100644 --- a/scss/_navbar.scss +++ b/scss/_navbar.scss @@ -129,6 +129,11 @@ display: block !important; } } + &-md { + @include media-breakpoint-up(lg) { + display: block !important; + } + } } -- cgit v1.2.3 From 584cfdd72b4afbb3c2e21e83bb8109f7881511a0 Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Sat, 5 Sep 2015 20:58:28 -0700 Subject: Fixes #17230: Renames .navbar-static-top to .navbar-full and adds docs for it --- scss/_navbar.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'scss/_navbar.scss') diff --git a/scss/_navbar.scss b/scss/_navbar.scss index d812212a0..ffe133b9f 100644 --- a/scss/_navbar.scss +++ b/scss/_navbar.scss @@ -19,8 +19,8 @@ // Display the navbar across the entirety of the page or fixed it to the top or // bottom of the page. -// Static top (unfixed, but 100% wide) navbar -.navbar-static-top { +// A static, full width modifier with no rounded corners. +.navbar-full { z-index: $zindex-navbar; @include media-breakpoint-up(sm) { -- cgit v1.2.3