From d51f0a4f816534e8c39ff58d8d4c562d2dd568fb Mon Sep 17 00:00:00 2001 From: Kevin Kirsche Date: Wed, 19 Aug 2015 16:31:31 -0400 Subject: Use double colons for psuedo elements Fix #17052 --- scss/_reboot.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'scss/_reboot.scss') diff --git a/scss/_reboot.scss b/scss/_reboot.scss index de32aae2b..0c0accb8b 100644 --- a/scss/_reboot.scss +++ b/scss/_reboot.scss @@ -22,8 +22,8 @@ html { } *, -*:before, -*:after { +*::before, +*::after { box-sizing: inherit; } -- cgit v1.2.3 From d2930ce1ad063554e339ac28adb4bcccff087fed Mon Sep 17 00:00:00 2001 From: Tom Byrer Date: Wed, 26 Aug 2015 18:59:08 -0600 Subject: clarifies normalize.css is a dependency Perhaps I'm a little slow & need to have things spelled out :) https://github.com/twbs/bootstrap/issues/17301#issuecomment-134469886 --- scss/_reboot.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'scss/_reboot.scss') diff --git a/scss/_reboot.scss b/scss/_reboot.scss index 0c0accb8b..93726afe3 100644 --- a/scss/_reboot.scss +++ b/scss/_reboot.scss @@ -1,7 +1,7 @@ // Reboot // // Global resets to common HTML elements and more for easier usage by Bootstrap. -// Builds on the resets of Normalize.css. +// Adds additional rules on top of Normalize.css. // Reset the box-sizing -- cgit v1.2.3 From 8f9e50c02d226f3abc083330f8e30b10b2f6511c Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Tue, 1 Sep 2015 21:14:51 -0700 Subject: fixes #17385: add var for default link decoration --- scss/_reboot.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'scss/_reboot.scss') diff --git a/scss/_reboot.scss b/scss/_reboot.scss index 0c0accb8b..8f07a5ec0 100644 --- a/scss/_reboot.scss +++ b/scss/_reboot.scss @@ -146,7 +146,7 @@ blockquote { a { color: $link-color; - text-decoration: none; + text-decoration: $link-decoration; @include hover-focus { color: $link-hover-color; -- cgit v1.2.3 From 468a9d9359a1008675b2c19a1fae1d9016a7686d Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Tue, 1 Sep 2015 21:16:26 -0700 Subject: fixes #17379: override search input box-sizing to match our global overrides --- scss/_reboot.scss | 2 ++ 1 file changed, 2 insertions(+) (limited to 'scss/_reboot.scss') diff --git a/scss/_reboot.scss b/scss/_reboot.scss index 8f07a5ec0..2b2721561 100644 --- a/scss/_reboot.scss +++ b/scss/_reboot.scss @@ -284,6 +284,8 @@ input[type="search"] { // be added to `.form-control` as it's not specific enough. For details, see // https://github.com/twbs/bootstrap/issues/11586. -webkit-appearance: none; + // Undo Normalize's default here to match our global overrides. + box-sizing: inherit; } // todo: needed? -- cgit v1.2.3 From cf70fce245da359a3b7513108217418e4d6ba05a Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Tue, 1 Sep 2015 21:20:35 -0700 Subject: mention overrides too --- scss/_reboot.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'scss/_reboot.scss') diff --git a/scss/_reboot.scss b/scss/_reboot.scss index 8a70714b8..9e22c3a70 100644 --- a/scss/_reboot.scss +++ b/scss/_reboot.scss @@ -1,7 +1,7 @@ // Reboot // // Global resets to common HTML elements and more for easier usage by Bootstrap. -// Adds additional rules on top of Normalize.css. +// Adds additional rules on top of Normalize.css, including several overrides. // Reset the box-sizing -- cgit v1.2.3 From 57998dc274a06b64d4caeda372aeea7b9d1af3ee Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Tue, 1 Sep 2015 21:23:26 -0700 Subject: linter --- scss/_reboot.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'scss/_reboot.scss') diff --git a/scss/_reboot.scss b/scss/_reboot.scss index 9e22c3a70..a4dc0398c 100644 --- a/scss/_reboot.scss +++ b/scss/_reboot.scss @@ -279,13 +279,13 @@ legend { } input[type="search"] { + // Undo Normalize's default here to match our global overrides. + box-sizing: inherit; // This overrides the extra rounded corners on search inputs in iOS so that our // `.form-control` class can properly style them. Note that this cannot simply // be added to `.form-control` as it's not specific enough. For details, see // https://github.com/twbs/bootstrap/issues/11586. -webkit-appearance: none; - // Undo Normalize's default here to match our global overrides. - box-sizing: inherit; } // todo: needed? -- cgit v1.2.3