From 07ef67da20c800eb3afa51d2064549ed325cc145 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Thu, 18 Dec 2014 19:07:22 -0800 Subject: Remove .hidden and .show classes .hidden is incompatible with jQuery's $(...).hide() --- scss/_utilities.scss | 12 ------------ 1 file changed, 12 deletions(-) (limited to 'scss') diff --git a/scss/_utilities.scss b/scss/_utilities.scss index 6b82d2fc3..d33400125 100644 --- a/scss/_utilities.scss +++ b/scss/_utilities.scss @@ -48,9 +48,6 @@ // Toggling content -.show { - display: block !important; -} .invisible { visibility: hidden; } @@ -59,15 +56,6 @@ } -// Hide from screenreaders and browsers -// -// Credit: HTML5 Boilerplate -.hidden { - display: none !important; - visibility: hidden !important; -} - - // For Affix plugin .affix { position: fixed; -- cgit v1.2.3 From 5b03c9ad634499ff00a0248602d9f097c3be5e00 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 22 Dec 2014 13:33:58 -0800 Subject: [disabled] => :disabled :disabled is supported in IE9+ and all modern browsers --- scss/_buttons.scss | 6 +++--- scss/_forms.scss | 4 ++-- scss/_navbar.scss | 4 ++-- scss/mixins/_buttons.scss | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) (limited to 'scss') diff --git a/scss/_buttons.scss b/scss/_buttons.scss index 08feff3b6..8f75cbec1 100644 --- a/scss/_buttons.scss +++ b/scss/_buttons.scss @@ -43,7 +43,7 @@ } &.disabled, - &[disabled], + &:disabled, fieldset[disabled] & { pointer-events: none; // Future-proof disabling of clicks cursor: $cursor-disabled; @@ -88,7 +88,7 @@ &, &:active, &.active, - &[disabled], + &:disabled, fieldset[disabled] & { background-color: transparent; @include box-shadow(none); @@ -105,7 +105,7 @@ text-decoration: underline; background-color: transparent; } - &[disabled], + &:disabled, fieldset[disabled] & { &:hover, &:focus { diff --git a/scss/_forms.scss b/scss/_forms.scss index 1f68383f9..8d6d00af0 100644 --- a/scss/_forms.scss +++ b/scss/_forms.scss @@ -140,7 +140,7 @@ output { // HTML5 says that controls under a fieldset > legend:first-child won't be // disabled if the fieldset is disabled. Due to implementation difficulty, we // don't honor that edge case; we style them as disabled anyway. - &[disabled], + &:disabled, &[readonly], fieldset[disabled] & { cursor: $cursor-disabled; @@ -263,7 +263,7 @@ input[type="search"] { // Note: Neither radios nor checkboxes can be readonly. input[type="radio"], input[type="checkbox"] { - &[disabled], + &:disabled, &.disabled, fieldset[disabled] & { cursor: $cursor-disabled; diff --git a/scss/_navbar.scss b/scss/_navbar.scss index d021ab0de..d4dcb673f 100644 --- a/scss/_navbar.scss +++ b/scss/_navbar.scss @@ -309,7 +309,7 @@ &:focus { color: $navbar-default-link-hover-color; } - &[disabled], + &:disabled, fieldset[disabled] & { &:hover, &:focus { @@ -422,7 +422,7 @@ color: $navbar-inverse-link-hover-color; } - &[disabled], + &:disabled, fieldset[disabled] & { &:hover, &:focus { diff --git a/scss/mixins/_buttons.scss b/scss/mixins/_buttons.scss index 7233b4dc2..b043d60de 100644 --- a/scss/mixins/_buttons.scss +++ b/scss/mixins/_buttons.scss @@ -28,7 +28,7 @@ @include box-shadow(inset 0 3px 5px rgba(0,0,0,.125)); } &.disabled, - &[disabled], + &:disabled, fieldset[disabled] & { &, &:hover, -- cgit v1.2.3 From 4d8559f8956ae26f0c967fe6d3143be8bc793ae6 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 22 Dec 2014 16:32:25 -0800 Subject: Remove min--moz-device-pixel-ratio Bootstrap v4 no longer supports the old versions of Firefox affected by this typo bug. --- scss/mixins/_image.scss | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'scss') diff --git a/scss/mixins/_image.scss b/scss/mixins/_image.scss index f25e0ab21..bec9626f6 100644 --- a/scss/mixins/_image.scss +++ b/scss/mixins/_image.scss @@ -16,15 +16,13 @@ // Retina image // -// Short retina mixin for setting background-image and -size. Note that the -// spelling of `min--moz-device-pixel-ratio` is intentional. +// Short retina mixin for setting background-image and -size. @mixin img-retina($file-1x, $file-2x, $width-1x, $height-1x) { background-image: url("#{file-1x}"); @media only screen and (-webkit-min-device-pixel-ratio: 2), - only screen and ( min--moz-device-pixel-ratio: 2), only screen and ( -o-min-device-pixel-ratio: 2/1), only screen and ( min-device-pixel-ratio: 2), only screen and ( min-resolution: 192dpi), -- cgit v1.2.3 From 96d273e28f721f5a8e22c3fd870955e213e955aa Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 22 Dec 2014 17:27:08 -0800 Subject: Re-add Firefox placeholder opacity workaround --- scss/_forms.scss | 1 + 1 file changed, 1 insertion(+) (limited to 'scss') diff --git a/scss/_forms.scss b/scss/_forms.scss index 1f68383f9..9ea0ebc67 100644 --- a/scss/_forms.scss +++ b/scss/_forms.scss @@ -133,6 +133,7 @@ output { // Placeholder &::placeholder { color: $input-color-placeholder; + opacity: 1; // Override Firefox's unusual default opacity; see https://github.com/twbs/bootstrap/pull/11526 } // Disabled and read-only inputs -- cgit v1.2.3