From 548be2ed6604ddfc8488cd4a793c6271c2caf485 Mon Sep 17 00:00:00 2001 From: GeoSot Date: Tue, 2 Mar 2021 19:10:10 +0200 Subject: Offcanvas as component (#29017) * Add a new offcanvas component * offcanvas.js: switch to string constants and `event.key` * Remove unneeded code * Sass optimizations * Fixes Make sure the element is hidden and not offscreen when inactive fix close icon negative margins Add content in right & bottom examples Re-fix bottom offcanvas height not to cover all viewport * Wording tweaks * update tests and offcanvas class * separate scrollbar functionality and use it in offcanvas * Update .bundlewatch.config.json * fix focus * update btn-close / fix focus on close * add aria-modal and role return focus on trigger when offcanvas is closed change body scrolling timings * move common code to reusable functions * add aria-labelledby * Replace lorem ipsum text * fix focus when offcanvas is closed * updates * revert modal, add tests for scrollbar * show backdrop by default * Update offcanvas.md * Update offcanvas CSS to better match modals - Add background-clip for borders - Move from outline to border (less clever, more consistent) - Add scss-docs in vars * Revamp offcanvas docs - Add static example to show and explain the components - Split live examples and rename them - Simplify example content - Expand docs notes elsewhere - Add sass docs * Add .offcanvas-title instead of .modal-title * Rename offcanvas example to offcanvas-navbar to reflect it's purpose * labelledby references title and not header * Add default shadow to offcanvas * enable offcanvas-body to fill all the remaining wrapper area * Be more descriptive, on Accessibility area * remove redundant classes * ensure in case of an already open offcanvas, not to open another one * bring back backdrop|scroll combinations * bring back toggling class * refactor scrollbar method, plus tests * add check if element is not full-width, according to #30621 * revert all in modal * use documentElement innerWidth * Rename classes to -start and -end Also copyedit some docs wording * omit some things on scrollbar * PASS BrowserStack tests -- IOS devices, Android devices and Browsers on Mac, hide scrollbar by default and appear it, only while scrolling. * Rename '_handleClosing' to '_addEventListeners' * change pipe usage to comma * change Data.getData to Data.get Co-authored-by: XhmikosR Co-authored-by: Martijn Cuppens Co-authored-by: Mark Otto --- site/data/examples.yml | 8 ++------ site/data/sidebar.yml | 1 + 2 files changed, 3 insertions(+), 6 deletions(-) (limited to 'site/data') diff --git a/site/data/examples.yml b/site/data/examples.yml index 0ddafaf41..d243bdad0 100644 --- a/site/data/examples.yml +++ b/site/data/examples.yml @@ -47,12 +47,8 @@ description: "Single navbar example with a fixed top navbar along with some additional content." - name: Navbar bottom description: "Single navbar example with a bottom navbar along with some additional content." - -- category: Experiments - description: "Examples that focus on future-friendly features or techniques." - examples: - - name: Offcanvas - description: "Turn your expandable navbar into a sliding offcanvas menu." + - name: Offcanvas navbar + description: "Turn your expandable navbar into a sliding offcanvas menu (doesn't use our offcanvas component)." - category: RTL description: "See Bootstrap's RTL version in action with these modified Custom Components examples." diff --git a/site/data/sidebar.yml b/site/data/sidebar.yml index 2c8f9b45c..4e43255a3 100644 --- a/site/data/sidebar.yml +++ b/site/data/sidebar.yml @@ -72,6 +72,7 @@ - title: Modal - title: Navs & tabs - title: Navbar + - title: Offcanvas - title: Pagination - title: Popovers - title: Progress -- cgit v1.2.3