From 7ce29d75f38f2c81f57e8a6cf14c510655e2e316 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Laussel=20Lo=C3=AFc?= Date: Sat, 28 Mar 2020 08:51:24 +0100 Subject: v5 tabs - accessibility issue when using ul/li semantic Add aria-role presentation on li element when ul element has role tablist and remove dropdown from visual tests as they've been removed from doc --- site/content/docs/4.3/components/navs.md | 40 ++++++++++++++++---------------- 1 file changed, 20 insertions(+), 20 deletions(-) (limited to 'site') diff --git a/site/content/docs/4.3/components/navs.md b/site/content/docs/4.3/components/navs.md index adbb7749b..0c7f54981 100644 --- a/site/content/docs/4.3/components/navs.md +++ b/site/content/docs/4.3/components/navs.md @@ -313,13 +313,13 @@ Note that dynamic tabbed interfaces should not contain dropdown menus,
@@ -338,13 +338,13 @@ Note that dynamic tabbed interfaces should not contain dropdown menus, {{< highlight html >}} @@ -397,13 +397,13 @@ The tabs plugin also works with pills.
@@ -422,13 +422,13 @@ The tabs plugin also works with pills. {{< highlight html >}} @@ -498,16 +498,16 @@ You can activate a tab or pill navigation without writing any JavaScript by simp {{< highlight html >}} @@ -572,16 +572,16 @@ Activates a tab element and content container. Tab should have either a `data-ta {{< highlight html >}} -- cgit v1.2.3 From c0efceb6d586cff4256478fb1e242c6075248f72 Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Sat, 28 Mar 2020 11:41:03 +0200 Subject: docs: remove duplicate code for indeterminate (#30471) --- site/assets/js/application.js | 10 ---------- site/content/docs/4.3/forms/checks.md | 2 +- 2 files changed, 1 insertion(+), 11 deletions(-) (limited to 'site') diff --git a/site/assets/js/application.js b/site/assets/js/application.js index d5a68c7e1..c825d7373 100644 --- a/site/assets/js/application.js +++ b/site/assets/js/application.js @@ -19,16 +19,6 @@ return [].slice.call(list) } - (function () { - var checkbox = document.getElementById('flexCheckIndeterminate') - - if (!checkbox) { - return - } - - checkbox.indeterminate = true - })() - makeArray(document.querySelectorAll('.js-sidenav-group')) .forEach(function (sidenavGroup) { var groupHasLinks = Boolean(sidenavGroup.querySelector('li')) diff --git a/site/content/docs/4.3/forms/checks.md b/site/content/docs/4.3/forms/checks.md index 6b90fb9bf..e189d1bb9 100644 --- a/site/content/docs/4.3/forms/checks.md +++ b/site/content/docs/4.3/forms/checks.md @@ -35,7 +35,7 @@ Our checks use custom Bootstrap icons to indicate checked or indeterminate state Checkboxes can utilize the `:indeterminate` pseudo class when manually set via JavaScript (there is no available HTML attribute for specifying it). -{{< example >}} +{{< example class="bd-example-indeterminate">}}
diff --git a/site/content/docs/4.3/examples/navbars/index.html b/site/content/docs/4.3/examples/navbars/index.html index 1016b5b9a..6cd9ae380 100644 --- a/site/content/docs/4.3/examples/navbars/index.html +++ b/site/content/docs/4.3/examples/navbars/index.html @@ -25,11 +25,11 @@ extra_css: @@ -82,11 +82,11 @@ extra_css: @@ -116,11 +116,11 @@ extra_css: @@ -150,11 +150,11 @@ extra_css: @@ -184,11 +184,11 @@ extra_css: @@ -218,11 +218,11 @@ extra_css: @@ -252,11 +252,11 @@ extra_css: @@ -289,11 +289,11 @@ extra_css:
@@ -321,11 +321,11 @@ extra_css: @@ -354,11 +354,11 @@ extra_css:
diff --git a/site/content/docs/4.3/examples/offcanvas/index.html b/site/content/docs/4.3/examples/offcanvas/index.html index 4a8501e3a..cc41316bc 100644 --- a/site/content/docs/4.3/examples/offcanvas/index.html +++ b/site/content/docs/4.3/examples/offcanvas/index.html @@ -31,11 +31,11 @@ body_class: "bg-light" diff --git a/site/content/docs/4.3/examples/starter-template/index.html b/site/content/docs/4.3/examples/starter-template/index.html index 0a6ea6291..d2869091e 100644 --- a/site/content/docs/4.3/examples/starter-template/index.html +++ b/site/content/docs/4.3/examples/starter-template/index.html @@ -25,11 +25,11 @@ extra_css: diff --git a/site/layouts/partials/docs-versions.html b/site/layouts/partials/docs-versions.html index cddf4a116..ef0b4518a 100644 --- a/site/layouts/partials/docs-versions.html +++ b/site/layouts/partials/docs-versions.html @@ -2,13 +2,13 @@ - + -- cgit v1.2.3 From 43d866313d5849c08f4e0f6589691ad63ee4e42a Mon Sep 17 00:00:00 2001 From: Martijn Cuppens Date: Tue, 31 Mar 2020 22:42:45 +0200 Subject: Fix active state dropdown --- site/assets/scss/_subnav.scss | 4 +--- site/layouts/partials/docs-versions.html | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) (limited to 'site') diff --git a/site/assets/scss/_subnav.scss b/site/assets/scss/_subnav.scss index e0492edc1..5b4d2806f 100644 --- a/site/assets/scss/_subnav.scss +++ b/site/assets/scss/_subnav.scss @@ -11,10 +11,8 @@ box-shadow: 0 .5rem 1rem rgba(0, 0, 0, .05); } - .dropdown-item.active { + .dropdown-item.current { font-weight: 600; - color: $gray-900; - background-color: transparent; background-image: escape-svg($dropdown-active-icon); background-repeat: no-repeat; background-position: .4rem .6rem; diff --git a/site/layouts/partials/docs-versions.html b/site/layouts/partials/docs-versions.html index ef0b4518a..bfe3c2a55 100644 --- a/site/layouts/partials/docs-versions.html +++ b/site/layouts/partials/docs-versions.html @@ -3,7 +3,7 @@ Bootstrap v{{ .Site.Params.docs_version }}