Issue 1114: New datatype module

Current status:
- moved number(), float(), hexaDecimal(), boolean(), uuid() from random to datatype
- moved respective test from random.unit to datatype.unit
- tests of moved methods in random now check if DeprecationWarning is printed and respective method in datatype module is called
- adapted all lib files that use moved methods (mostly number)
- adapted tests of respective files to spy on the correct method
- adapted README in order to promote usage of method that logs a DeprecationWarning

1 files changed, 11 insertions, 12 deletions

diff --git a/lib/finance.js b/lib/finance.js
index 43fe6710..f6818e33 100644
--- a/lib/finance.js
+++ b/lib/finance.js
@@ -109,7 +109,7 @@ var Finance = function (faker) {
       max = max || 1000;
       dec = dec === undefined ? 2 : dec;
       symbol = symbol || '';
-      const randValue = faker.random.number({ max: max, min: min, precision: Math.pow(10, -dec) });
+      const randValue = faker.datatype.number({ max: max, min: min, precision: Math.pow(10, -dec) });
 
       let formattedString;
       if(autoFormat) {
@@ -169,7 +169,7 @@ var Finance = function (faker) {
    * @method  faker.finance.bitcoinAddress
    */
   self.bitcoinAddress = function () {
-    var addressLength = faker.random.number({ min: 25, max: 34 });
+    var addressLength = faker.datatype.number({ min: 25, max: 34 });
 
     var address = faker.random.arrayElement(['1', '3']);
 
@@ -185,7 +185,7 @@ var Finance = function (faker) {
  * @method  faker.finance.litecoinAddress
  */
 self.litecoinAddress = function () {
-  var addressLength = faker.random.number({ min: 26, max: 33 });
+  var addressLength = faker.datatype.number({ min: 26, max: 33 });
 
   var address = faker.random.arrayElement(['L', 'M', '3']);
 
@@ -236,7 +236,7 @@ self.litecoinAddress = function () {
   self.creditCardCVV = function() {
     var cvv = "";
     for (var i = 0; i < 3; i++) {
-      cvv += faker.random.number({max:9}).toString();
+      cvv += faker.datatype.number({max:9}).toString();
     }
     return cvv;
   };
@@ -247,8 +247,7 @@ self.litecoinAddress = function () {
    * @method  faker.finance.ethereumAddress
    */
   self.ethereumAddress = function () {
-    var address = faker.random.hexaDecimal(40).toLowerCase();
-
+    var address = faker.datatype.hexaDecimal(40).toLowerCase();
     return address;
   };
 
@@ -284,14 +283,14 @@ self.litecoinAddress = function () {
               if (bban.type == "a") {
                   s += faker.random.arrayElement(ibanLib.alpha);
               } else if (bban.type == "c") {
-                  if (faker.random.number(100) < 80) {
-                      s += faker.random.number(9);
+                  if (faker.datatype.number(100) < 80) {
+                      s += faker.datatype.number(9);
                   } else {
                       s += faker.random.arrayElement(ibanLib.alpha);
                   }
               } else {
-                  if (c >= 3 && faker.random.number(100) < 30) {
-                      if (faker.random.boolean()) {
+                  if (c >= 3 && faker.datatype.number(100) < 30) {
+                      if (faker.datatype.boolean()) {
                           s += faker.random.arrayElement(ibanLib.pattern100);
                           c -= 2;
                       } else {
@@ -299,7 +298,7 @@ self.litecoinAddress = function () {
                           c--;
                       }
                   } else {
-                      s += faker.random.number(9);
+                      s += faker.datatype.number(9);
                   }
               }
               c--;
@@ -321,7 +320,7 @@ self.litecoinAddress = function () {
    */
   self.bic = function () {
       var vowels = ["A", "E", "I", "O", "U"];
-      var prob = faker.random.number(100);
+      var prob = faker.datatype.number(100);
       return Helpers.replaceSymbols("???") +
           faker.random.arrayElement(vowels) +
           faker.random.arrayElement(ibanLib.iso3166) +