diff options
| author | LBuerstmayr <[email protected]> | 2021-03-01 22:46:26 +0100 |
|---|---|---|
| committer | Marak <[email protected]> | 2021-03-03 20:14:45 -0500 |
| commit | 7ad22c2e2aae2f5e6215bcdb91cf3fd28e727d92 (patch) | |
| tree | 03941188e92583a105c8ef17fde438fb1b52bdcf /lib/name.js | |
| parent | 58c61afb1b8baa160add593e5af7c110de011968 (diff) | |
| download | faker-7ad22c2e2aae2f5e6215bcdb91cf3fd28e727d92.tar.xz faker-7ad22c2e2aae2f5e6215bcdb91cf3fd28e727d92.zip | |
Issue 1114: New datatype module
Current status:
- moved number(), float(), hexaDecimal(), boolean(), uuid() from random to datatype
- moved respective test from random.unit to datatype.unit
- tests of moved methods in random now check if DeprecationWarning is printed and respective method in datatype module is called
- adapted all lib files that use moved methods (mostly number)
- adapted tests of respective files to spy on the correct method
- adapted README in order to promote usage of method that logs a DeprecationWarning
Diffstat (limited to 'lib/name.js')
| -rw-r--r-- | lib/name.js | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/lib/name.js b/lib/name.js index 3d42cb10..053e3a01 100644 --- a/lib/name.js +++ b/lib/name.js @@ -27,7 +27,7 @@ function Name (faker) { if (typeof gender !== 'number') { if(typeof faker.definitions.name.first_name === "undefined") { - gender = faker.random.number(1); + gender = faker.datatype.number(1); } else { //Fall back to non-gendered names if they exist and gender wasn't specified @@ -55,7 +55,7 @@ function Name (faker) { // some locale datasets ( like ru ) have last_name split by gender. i have no idea how last names can have genders, but also i do not speak russian // see above comment of firstName method if (typeof gender !== 'number') { - gender = faker.random.number(1); + gender = faker.datatype.number(1); } if (gender === 0) { return faker.random.arrayElement(faker.locales[faker.locale].name.male_last_name); @@ -76,7 +76,7 @@ function Name (faker) { this.middleName = function (gender) { if (typeof faker.definitions.name.male_middle_name !== "undefined" && typeof faker.definitions.name.female_middle_name !== "undefined") { if (typeof gender !== 'number') { - gender = faker.random.number(1); + gender = faker.datatype.number(1); } if (gender === 0) { return faker.random.arrayElement(faker.locales[faker.locale].name.male_middle_name); @@ -97,12 +97,12 @@ function Name (faker) { * @memberof faker.name */ this.findName = function (firstName, lastName, gender) { - var r = faker.random.number(8); + var r = faker.datatype.number(8); var prefix, suffix; // in particular locales first and last names split by gender, // thus we keep consistency by passing 0 as male and 1 as female if (typeof gender !== 'number') { - gender = faker.random.number(1); + gender = faker.datatype.number(1); } firstName = firstName || faker.name.firstName(gender); lastName = lastName || faker.name.lastName(gender); @@ -158,7 +158,7 @@ function Name (faker) { this.prefix = function (gender) { if (typeof faker.definitions.name.male_prefix !== "undefined" && typeof faker.definitions.name.female_prefix !== "undefined") { if (typeof gender !== 'number') { - gender = faker.random.number(1); + gender = faker.datatype.number(1); } if (gender === 0) { return faker.random.arrayElement(faker.locales[faker.locale].name.male_prefix); |
