From 86d0a279144eeed6793a37b1523ee887a60cd77d Mon Sep 17 00:00:00 2001 From: "A.J. May" Date: Tue, 2 Apr 2019 15:23:39 -0400 Subject: fix: lowercase eth addresses Ethereum addresses should be all lowercase. Uppercase chars in ethereum addresses are a sort of optional checksum. If a program is validating ethereum addresses, random capital letters in the hex string will cause the checksum to fail. --- lib/finance.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/finance.js b/lib/finance.js index e3506265..c16b9e49 100644 --- a/lib/finance.js +++ b/lib/finance.js @@ -223,7 +223,7 @@ var Finance = function (faker) { * @method faker.finance.ethereumAddress */ self.ethereumAddress = function () { - var address = faker.random.hexaDecimal(40); + var address = faker.random.hexaDecimal(40).toLowerCase(); return address; }; -- cgit v1.2.3 From 4d537b3589635cc30129b29746db8673f1e3c910 Mon Sep 17 00:00:00 2001 From: "A.J. May" Date: Tue, 2 Apr 2019 15:25:17 -0400 Subject: test: check generated ethereum addresses are all lowercase --- test/finance.unit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/finance.unit.js b/test/finance.unit.js index a64b879a..bad85884 100644 --- a/test/finance.unit.js +++ b/test/finance.unit.js @@ -246,7 +246,7 @@ describe('finance.js', function () { describe("ethereumAddress()", function(){ it("returns a random ethereum address", function(){ var ethereumAddress = faker.finance.ethereumAddress(); - assert.ok(ethereumAddress.match(/^(0x)[0-9a-f]{40}$/i)); + assert.ok(ethereumAddress.match(/^(0x)[0-9a-f]{40}$/)); }); }); -- cgit v1.2.3