From c7182f01afe7dc07549599363e55d676e799e2d6 Mon Sep 17 00:00:00 2001 From: ST-DDT Date: Mon, 18 Sep 2023 16:55:34 +0200 Subject: docs(contributing): clarify locale PR rules (#2399) --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'CONTRIBUTING.md') diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 75ce7166..d5a9ff79 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -45,7 +45,7 @@ If adding new data definitions to Faker, you'll often need to find source data. ## Adding new locale or updating existing one After adding new or updating existing locale data, you need to run `pnpm run generate:locales` to generate/update the related files. -If you change more than 20 locale files, please consider splitting your PR into one per category (e.g. person, location). +Please only change files related to one module (e.g. person, location) whenever possible. This can simplify/speed up the review process. Additionally, it allows the maintainers to track PRs in a meaningful way by adding related labels. ## Building Faker -- cgit v1.2.3