From f2f37f8ef531798f30d8010b6a30a0bbc68875f4 Mon Sep 17 00:00:00 2001 From: Richard Butler Date: Thu, 27 Jun 2013 14:10:58 +0100 Subject: Split male and female names into two groups --- lib/name.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/name.js') diff --git a/lib/name.js b/lib/name.js index 48759dcf..4f504aa5 100644 --- a/lib/name.js +++ b/lib/name.js @@ -1,8 +1,8 @@ var Faker = require('../index'); var _name = { - firstName: function () { - return Faker.random.first_name(); + firstName: function ( gender ) { + return Faker.random.first_name( gender ); }, lastName: function () { -- cgit v1.2.3 From 553aca8463666b815628ee71c97199856f2e5702 Mon Sep 17 00:00:00 2001 From: Richard Butler Date: Thu, 27 Jun 2013 14:17:12 +0100 Subject: Add gender to name class --- lib/name.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'lib/name.js') diff --git a/lib/name.js b/lib/name.js index 4f504aa5..d806d64b 100644 --- a/lib/name.js +++ b/lib/name.js @@ -9,16 +9,20 @@ var _name = { return Faker.random.last_name(); }, - findName: function () { + findName: function ( gender ) { var r = Faker.random.number(8); switch (r) { case 0: - return Faker.random.name_prefix() + " " + this.firstName() + " " + this.lastName(); + return Faker.random.name_prefix() + " " + this.firstName( gender ) + " " + this.lastName(); case 1: - return this.firstName() + " " + this.lastName() + " " + Faker.random.name_suffix(); + return this.firstName( gender ) + " " + this.lastName() + " " + Faker.random.name_suffix(); } - return this.firstName() + " " + this.lastName(); + return this.firstName( gender ) + " " + this.lastName(); + }, + + gender: function() { + return Faker.random.gender(); } }; -- cgit v1.2.3 From c8f71cd072b74c66693cae927bdaf9a97ee15c1f Mon Sep 17 00:00:00 2001 From: cyanos3 Date: Tue, 5 Nov 2013 20:10:31 -0700 Subject: My take on separating male and female names. Tests passing, Coverage restored. --- lib/name.js | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) (limited to 'lib/name.js') diff --git a/lib/name.js b/lib/name.js index d806d64b..5ad87bc4 100644 --- a/lib/name.js +++ b/lib/name.js @@ -1,27 +1,35 @@ var Faker = require('../index'); var _name = { - firstName: function ( gender ) { - return Faker.random.first_name( gender ); + firstName: function () { + return Faker.random.first_name(); + }, + + firstNameMale: function () { + return Faker.random.first_name_male(); + }, + + firstNameFemale: function () { + return Faker.random.first_name_female(); }, lastName: function () { return Faker.random.last_name(); }, - findName: function ( gender ) { + findName: function () { var r = Faker.random.number(8); switch (r) { - case 0: - return Faker.random.name_prefix() + " " + this.firstName( gender ) + " " + this.lastName(); - case 1: - return this.firstName( gender ) + " " + this.lastName() + " " + Faker.random.name_suffix(); + case 0: + return Faker.random.name_prefix() + " " + this.firstName() + " " + this.lastName(); + case 1: + return this.firstName() + " " + this.lastName() + " " + Faker.random.name_suffix(); } - return this.firstName( gender ) + " " + this.lastName(); + return this.firstName() + " " + this.lastName(); }, - gender: function() { + gender: function () { return Faker.random.gender(); } }; -- cgit v1.2.3