From 194e1a8896067b929315a603acad2e750dfa1526 Mon Sep 17 00:00:00 2001 From: Charles Lowell Date: Wed, 24 Mar 2021 16:10:13 +0200 Subject: Give each faker instance its own random number generator Currently, every Faker instance shares the same random number generator instance which means that to seed one faker instance is to seed them all. This can result in duplicate data being generated all over the place. This just extracts the public API of the mersenne twister found in `vendor/mersenne.js` and creates a single instance of it per faker. This implementation is a tad sub-optimal since calling `seed()` on a faker instance will result in two redundant calls to `mersenne.init_genrand()`: one in `random.js` and the other in `datatype.js`. It would probably be more DRY to create the mersenne instance once in faker and then pass it into to the `Random` and `Datatype` instances, however, this takes the strategy of the smallest possible API change. --- lib/random.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'lib/random.js') diff --git a/lib/random.js b/lib/random.js index 4c2daaac..4443c555 100644 --- a/lib/random.js +++ b/lib/random.js @@ -1,5 +1,3 @@ -var mersenne = require('../vendor/mersenne'); - /** * Method to reduce array of characters * @param arr existing array of characters @@ -22,10 +20,10 @@ var arrayRemove = function (arr, values) { function Random (faker, seed) { // Use a user provided seed if it is an array or number if (Array.isArray(seed) && seed.length) { - mersenne.seed_array(seed); + faker.mersenne.seed_array(seed); } else if(!isNaN(seed)) { - mersenne.seed(seed); + faker.mersenne.seed(seed); } /** -- cgit v1.2.3