From f2f37f8ef531798f30d8010b6a30a0bbc68875f4 Mon Sep 17 00:00:00 2001 From: Richard Butler Date: Thu, 27 Jun 2013 14:10:58 +0100 Subject: Split male and female names into two groups --- lib/random.js | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) (limited to 'lib/random.js') diff --git a/lib/random.js b/lib/random.js index 7d010109..9b82c6dc 100644 --- a/lib/random.js +++ b/lib/random.js @@ -48,8 +48,19 @@ var random = { return this.array_element(definitions.uk_country); }, - first_name: function () { - return this.array_element(definitions.first_name); + first_name: function ( gender ) { + var def; + + if ( typeof gender === "undefined" ) { + def = [].concat( + definitions.first_name.male, + definitions.first_name.female + ); + } else { + def = definitions.first_name[ gender ]; + } + + return this.array_element( def || [] ); }, last_name: function () { -- cgit v1.2.3 From 8183e08fb3efbf8c40c847ed66e301000bc74ddf Mon Sep 17 00:00:00 2001 From: Richard Butler Date: Thu, 27 Jun 2013 14:12:10 +0100 Subject: Add random gender --- lib/random.js | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'lib/random.js') diff --git a/lib/random.js b/lib/random.js index 9b82c6dc..b3c0604a 100644 --- a/lib/random.js +++ b/lib/random.js @@ -48,6 +48,10 @@ var random = { return this.array_element(definitions.uk_country); }, + gender: function() { + return this.array_element([ "male", "female" ]); + }, + first_name: function ( gender ) { var def; -- cgit v1.2.3 From c8f71cd072b74c66693cae927bdaf9a97ee15c1f Mon Sep 17 00:00:00 2001 From: cyanos3 Date: Tue, 5 Nov 2013 20:10:31 -0700 Subject: My take on separating male and female names. Tests passing, Coverage restored. --- lib/random.js | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) (limited to 'lib/random.js') diff --git a/lib/random.js b/lib/random.js index b3c0604a..0aff3fd2 100644 --- a/lib/random.js +++ b/lib/random.js @@ -48,23 +48,20 @@ var random = { return this.array_element(definitions.uk_country); }, - gender: function() { + gender: function () { return this.array_element([ "male", "female" ]); }, - first_name: function ( gender ) { - var def; + first_name: function () { + return this.array_element(definitions.first_name); + }, - if ( typeof gender === "undefined" ) { - def = [].concat( - definitions.first_name.male, - definitions.first_name.female - ); - } else { - def = definitions.first_name[ gender ]; - } + first_name_female: function () { + return this.array_element(definitions.first_name_female); + }, - return this.array_element( def || [] ); + first_name_male: function () { + return this.array_element(definitions.first_name_male); }, last_name: function () { -- cgit v1.2.3 From e80be6e92d27e129d9504b60562069bd83ef9dee Mon Sep 17 00:00:00 2001 From: FotoVerite Date: Mon, 17 Feb 2014 21:40:33 -0500 Subject: Fixes so build runs. --- lib/random.js | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'lib/random.js') diff --git a/lib/random.js b/lib/random.js index 7d010109..fcd451d7 100644 --- a/lib/random.js +++ b/lib/random.js @@ -94,8 +94,13 @@ var random = { domain_suffix: function () { return this.array_element(definitions.domain_suffix); + }, + + avatar_uri: function () { + return this.array_element(definitions.avatar_uri); } + }; module.exports = random; -- cgit v1.2.3