From c8f71cd072b74c66693cae927bdaf9a97ee15c1f Mon Sep 17 00:00:00 2001 From: cyanos3 Date: Tue, 5 Nov 2013 20:10:31 -0700 Subject: My take on separating male and female names. Tests passing, Coverage restored. --- lib/random.js | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) (limited to 'lib/random.js') diff --git a/lib/random.js b/lib/random.js index b3c0604a..0aff3fd2 100644 --- a/lib/random.js +++ b/lib/random.js @@ -48,23 +48,20 @@ var random = { return this.array_element(definitions.uk_country); }, - gender: function() { + gender: function () { return this.array_element([ "male", "female" ]); }, - first_name: function ( gender ) { - var def; + first_name: function () { + return this.array_element(definitions.first_name); + }, - if ( typeof gender === "undefined" ) { - def = [].concat( - definitions.first_name.male, - definitions.first_name.female - ); - } else { - def = definitions.first_name[ gender ]; - } + first_name_female: function () { + return this.array_element(definitions.first_name_female); + }, - return this.array_element( def || [] ); + first_name_male: function () { + return this.array_element(definitions.first_name_male); }, last_name: function () { -- cgit v1.2.3