From ec87c45fa09ec653a4afc7edad6791956a2f3f64 Mon Sep 17 00:00:00 2001 From: Ari Gesher Date: Thu, 20 Nov 2014 00:37:06 -0800 Subject: Fixed male/female split check on findName() (It was failing on locales that use a fallback) --- lib/name.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib') diff --git a/lib/name.js b/lib/name.js index e61e0c41..cb43e596 100644 --- a/lib/name.js +++ b/lib/name.js @@ -3,7 +3,7 @@ var faker = require('../index'); var _name = { firstName: function () { - if (typeof faker.locales[faker.locale].name.male_first_name !== "undefined" && typeof faker.locales[faker.locale].name.female_first_name !== "undefined") { + if (typeof faker.definitions.name.male_first_name !== "undefined" && typeof faker.definitions.name.female_first_name !== "undefined") { // some locale datasets ( like ru ) have first_name split by gender. since the name.first_name field does not exist in these datasets, // we must randomly pick a name from either gender array so faker.name.firstName will return the correct locale data ( and not fallback ) var rand = faker.random.number(1); @@ -17,7 +17,7 @@ var _name = { }, lastName: function () { - if (typeof faker.locales[faker.locale].name.male_last_name !== "undefined" && typeof faker.locales[faker.locale].name.female_last_name !== "undefined") { + if (typeof faker.definitions.name.male_last_name !== "undefined" && typeof faker.defintions.name.female_last_name !== "undefined") { // some locale datasets ( like ru ) have last_name split by gender. i have no idea how last names can have genders, but also i do not speak russian // see above comment of firstName method var rand = faker.random.number(1); -- cgit v1.2.3