From f6b3ef94ecc1f37feb56bd4a41e9c65e962b4bd1 Mon Sep 17 00:00:00 2001 From: Ognjen Jevremovic Date: Sun, 28 Feb 2021 19:09:35 +0100 Subject: =?UTF-8?q?perf:=20=E2=9A=A1=EF=B8=8F=20Optimize=20finance=20trans?= =?UTF-8?q?action=20description=20method?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove the multiple calls to `createTransaction` method from within the `finance.transactionDescription` and instead call the method once and reference the properties from the returned transaction object. ✅ Closes: #1108 --- lib/finance.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'lib') diff --git a/lib/finance.js b/lib/finance.js index bbe2b17f..43fe6710 100644 --- a/lib/finance.js +++ b/lib/finance.js @@ -338,14 +338,15 @@ self.litecoinAddress = function () { * @method faker.finance.transactionDescription */ self.transactionDescription = function() { - var account = Helpers.createTransaction().account + var transaction = Helpers.createTransaction(); + var account = transaction.account; + var amount = transaction.amount; + var transactionType = transaction.type; + var company = transaction.business; var card = faker.finance.mask(); var currency = faker.finance.currencyCode(); - var amount = Helpers.createTransaction().amount - var transactionType = Helpers.createTransaction().type - var company = Helpers.createTransaction().business return transactionType + " transaction at " + company + " using card ending with ***" + card + " for " + currency + " " + amount + " in account ***" + account - } + }; }; -- cgit v1.2.3