From 9b00fe9f7353df50c67966141a5f024ec9b95208 Mon Sep 17 00:00:00 2001 From: ST-DDT Date: Thu, 23 Nov 2023 20:03:32 +0100 Subject: infra(unicorn): prefer-code-point (#2509) --- src/modules/internet/index.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'src/modules/internet') diff --git a/src/modules/internet/index.ts b/src/modules/internet/index.ts index 8367825f..395266fb 100644 --- a/src/modules/internet/index.ts +++ b/src/modules/internet/index.ts @@ -660,13 +660,15 @@ export class InternetModule extends ModuleBase { return charMapping[char]; } - if (char.charCodeAt(0) < 0x80) { + const charCode = char.codePointAt(0) ?? Number.NaN; + + if (charCode < 0x80) { // Keep ASCII characters return char; } // Final fallback return the Unicode char code value for Chinese, Japanese, Korean etc, base-36 encoded - return char.charCodeAt(0).toString(36); + return charCode.toString(36); }) .join(''); result = result.toString().replace(/'/g, ''); @@ -1495,7 +1497,7 @@ export class InternetModule extends ModuleBase { } const n = this.faker.number.int(94) + 33; - let char = String.fromCharCode(n); + let char = String.fromCodePoint(n); if (memorable) { char = char.toLowerCase(); } -- cgit v1.2.3