From 1bc622a9499bf236052809610ecabe80f87de482 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leyla=20J=C3=A4hnig?= <77127505+xDivisionByZerox@users.noreply.github.com> Date: Mon, 21 Mar 2022 14:42:44 +0100 Subject: fix: remove unreachable code finance (#508) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Leyla Jähnig --- src/finance.ts | 23 ++++------------------- 1 file changed, 4 insertions(+), 19 deletions(-) (limited to 'src') diff --git a/src/finance.ts b/src/finance.ts index ae70728e..b71e63b2 100644 --- a/src/finance.ts +++ b/src/finance.ts @@ -258,32 +258,17 @@ export class Finance { */ creditCardNumber(provider = ''): string { let format: string; - let formats: string | string[]; const localeFormat = this.faker.definitions.finance.credit_card; if (provider in localeFormat) { - formats = localeFormat[provider]; // there could be multiple formats - if (typeof formats === 'string') { - format = formats; - } else { - format = this.faker.random.arrayElement(formats); - } + format = this.faker.random.arrayElement(localeFormat[provider]); } else if (provider.match(/#/)) { // The user chose an optional scheme format = provider; } else { // Choose a random provider - // TODO ST-DDT 2022-01-30: #375 This is impossible to access - if (typeof localeFormat === 'string') { - format = localeFormat; - } else if (typeof localeFormat === 'object') { - // Credit cards are in a object structure - formats = this.faker.random.objectElement(localeFormat, 'value'); // There could be multiple formats - if (typeof formats === 'string') { - format = formats; - } else { - format = this.faker.random.arrayElement(formats); - } - } + // Credit cards are in an object structure + const formats = this.faker.random.objectElement(localeFormat, 'value'); // There could be multiple formats + format = this.faker.random.arrayElement(formats); } format = format.replace(/\//g, ''); return this.Helpers.replaceCreditCardSymbols(format); -- cgit v1.2.3