From 307c2d20c6cafef55a10fb424e5683c0d018cc55 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leyla=20J=C3=A4hnig?= <77127505+xDivisionByZerox@users.noreply.github.com> Date: Tue, 5 Apr 2022 18:16:41 +0200 Subject: refactor(helpers.shuffle): remove unused default value (#698) --- src/helpers.ts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/helpers.ts b/src/helpers.ts index f302ac46..e451eaab 100644 --- a/src/helpers.ts +++ b/src/helpers.ts @@ -417,11 +417,9 @@ export class Helpers { return o || []; } - // TODO ST-DDT 2022-02-06: This default will never be taken!? - o = o || (['a', 'b', 'c'] as unknown as T[]); - for (let x: T, j: number, i = o.length - 1; i > 0; --i) { - j = this.faker.datatype.number(i); - x = o[i]; + for (let i = o.length - 1; i > 0; --i) { + const j = this.faker.datatype.number(i); + const x = o[i]; o[i] = o[j]; o[j] = x; } -- cgit v1.2.3