From 336123fe05e7f80d79fc8522b4ff21a60fffe77c Mon Sep 17 00:00:00 2001 From: Nick Merwin Date: Wed, 20 Nov 2019 17:05:48 -0800 Subject: ES6 * remove unused variables * move `require`s at the top * check for prototype built-ins * run in strict mode * always check for error values in tests * make style consistent * mark Node.js 6 as the minimum supported version in package.json * Use the arrow return syntax * logger.js: use `Boolean` to make the intention clearer. * Use the rest params instead of arguments. * test/getOptions.js: beautify git data. * Update logger.js Remove `hasDebugEnvVariable` function; it's just a `process.env` check * Create .jshintrc --- lib/handleInput.js | 34 ++++++++++++++++++++-------------- 1 file changed, 20 insertions(+), 14 deletions(-) (limited to 'lib/handleInput.js') diff --git a/lib/handleInput.js b/lib/handleInput.js index 326671e..e7da536 100644 --- a/lib/handleInput.js +++ b/lib/handleInput.js @@ -1,33 +1,39 @@ -var index = require('../index'); -var logger = require('./logger')(); +'use strict'; + +const logger = require('./logger')(); +const index = require('..'); function handleInput(input, cb, userOptions) { logger.debug(input); - logger.debug('user options ' + userOptions); - index.getOptions(function(err, options){ - if (err){ - logger.error("error from getOptions"); + logger.debug(`user options ${userOptions}`); + index.getOptions((err, options) => { + if (err) { + logger.error('error from getOptions'); cb(err); return; } + logger.debug(options); - index.convertLcovToCoveralls(input, options, function(err, postData){ - if (err){ - logger.error("error from convertLcovToCoveralls"); + index.convertLcovToCoveralls(input, options, (err, postData) => { + if (err) { + logger.error('error from convertLcovToCoveralls'); cb(err); return; } - logger.info("sending this to coveralls.io: ", JSON.stringify(postData)); - index.sendToCoveralls(postData, function(err, response, body){ - if (err){ + + logger.info('sending this to coveralls.io: ', JSON.stringify(postData)); + index.sendToCoveralls(postData, (err, response, body) => { + if (err) { cb(err); return; } - if (response.statusCode >= 400){ - cb("Bad response: " + response.statusCode + " " + body); + + if (response.statusCode >= 400) { + cb(`Bad response: ${response.statusCode} ${body}`); return; } + logger.debug(response.statusCode); logger.debug(body); cb(null, body); -- cgit v1.2.3