From 45ef2a5508ed4485a0ee15354dcb1e3829fa9a6e Mon Sep 17 00:00:00 2001 From: Josh Callender Date: Fri, 24 Apr 2015 12:00:41 -0700 Subject: add support for CircleCI pull request commenting --- test/getOptions.js | 2 ++ 1 file changed, 2 insertions(+) (limited to 'test/getOptions.js') diff --git a/test/getOptions.js b/test/getOptions.js index 8a77708..12505a1 100644 --- a/test/getOptions.js +++ b/test/getOptions.js @@ -282,9 +282,11 @@ var testCircleCi = function(sut, done){ process.env.CIRCLE_BRANCH = "master"; process.env.CIRCLE_BUILD_NUM = "1234"; process.env.CIRCLE_SHA1 = "e3e3e3e3e3e3e3e3e"; + process.env.CI_PULL_REQUEST = 'http://github.com/node-coveralls/pull/3'; sut(function(err, options){ options.service_name.should.equal("circleci"); options.service_job_id.should.equal("1234"); + options.service_pull_request.should.equal('http://github.com/node-coveralls/pull/3'); options.git.should.eql({ head: { id: 'e3e3e3e3e3e3e3e3e', author_name: 'Unknown Author', -- cgit v1.2.3 From fba900513bb8653d8d83b7c35053be72d519d5d6 Mon Sep 17 00:00:00 2001 From: Josh Callender Date: Fri, 24 Apr 2015 12:57:16 -0700 Subject: CI_PULL_REQUEST is just the url for the entire PR, have to split it and grab the number there. CIRCLE_PR_NUMBER is only defined for forks. --- test/getOptions.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'test/getOptions.js') diff --git a/test/getOptions.js b/test/getOptions.js index 12505a1..05f9657 100644 --- a/test/getOptions.js +++ b/test/getOptions.js @@ -286,7 +286,7 @@ var testCircleCi = function(sut, done){ sut(function(err, options){ options.service_name.should.equal("circleci"); options.service_job_id.should.equal("1234"); - options.service_pull_request.should.equal('http://github.com/node-coveralls/pull/3'); + options.service_pull_request.should.equal('3'); options.git.should.eql({ head: { id: 'e3e3e3e3e3e3e3e3e', author_name: 'Unknown Author', -- cgit v1.2.3