diff options
| author | Johan Beckers <[email protected]> | 2018-09-07 13:12:04 +0200 |
|---|---|---|
| committer | XhmikosR <[email protected]> | 2018-10-21 21:31:28 +0300 |
| commit | 09aca3fb9a398273d8442d660bb6a29b42f231aa (patch) | |
| tree | 3993db6f3cdae0de6b719c403f3f6463354a38f8 | |
| parent | 9ed0b318b9e39bee74854eefe7170d7c4fe0aeae (diff) | |
| download | bootstrap-09aca3fb9a398273d8442d660bb6a29b42f231aa.tar.xz bootstrap-09aca3fb9a398273d8442d660bb6a29b42f231aa.zip | |
Unitless breakpoints
If I want to customise the breakpoints using `em`, I get compatibility errors.
It is good practice to set breakpoints in `em` instead of `px` when users use browser scaling.
See https://zellwk.com/blog/media-query-units/#concluding-the-experiments for more information why someone would like to do this. Only Safari users can get annoyed: https://adamwathan.me/dont-use-em-for-media-queries/
In any case, using a unitless number at line 42 would be very convenient.
| -rw-r--r-- | scss/mixins/_breakpoints.scss | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scss/mixins/_breakpoints.scss b/scss/mixins/_breakpoints.scss index 59f25a27e..cfdb1976b 100644 --- a/scss/mixins/_breakpoints.scss +++ b/scss/mixins/_breakpoints.scss @@ -39,7 +39,7 @@ // 767.98px @function breakpoint-max($name, $breakpoints: $grid-breakpoints) { $next: breakpoint-next($name, $breakpoints); - @return if($next, breakpoint-min($next, $breakpoints) - .02px, null); + @return if($next, breakpoint-min($next, $breakpoints) - .02, null); } // Returns a blank string if smallest breakpoint, otherwise returns the name with a dash in front. |