aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMark Otto <[email protected]>2014-01-09 14:28:27 -0800
committerMark Otto <[email protected]>2014-01-09 14:28:27 -0800
commit1c66664bed59c8fc3a416883226dcff870b8fba9 (patch)
tree7e1bccd2f41fdf8ac83e192c7697d9d6dbca7ffa
parent82eccef7e3de32dcc2149ec1bb59320bcbe1b8a3 (diff)
parentcba9d813400b410540cbc6480791ec927b91f619 (diff)
downloadbootstrap-1c66664bed59c8fc3a416883226dcff870b8fba9.tar.xz
bootstrap-1c66664bed59c8fc3a416883226dcff870b8fba9.zip
Merge pull request #12175 from waynn/patch-3
use periods for consistency in each line
-rw-r--r--CONTRIBUTING.md20
1 files changed, 10 insertions, 10 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 56b4f27a5..94eb110ae 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -154,20 +154,20 @@ license your work under the terms of the [MIT License](LICENSE.md).
### HTML
-- Two spaces for indentation, never tabs
-- Double quotes only, never single quotes
-- Always use proper indentation
-- Use tags and elements appropriate for an HTML5 doctype (e.g., self-closing tags)
+- Two spaces for indentation, never tabs.
+- Double quotes only, never single quotes.
+- Always use proper indentation.
+- Use tags and elements appropriate for an HTML5 doctype (e.g., self-closing tags).
- Use CDNs and HTTPS for third-party JS when possible. We don't use protocol-relative URLs in this case because they break when viewing the page locally via `file://`.
### CSS
-- CSS changes must be done in `.less` files first, never just in the compiled `.css` files
-- Adhere to the [CSS property order](http://markdotto.com/2011/11/29/css-property-order/)
-- Multiple-line approach (one property and value per line)
-- Always a space after a property's colon (e.g., `display: block;` and not `display:block;`)
-- End all lines with a semi-colon
-- For multiple, comma-separated selectors, place each selector on its own line
+- CSS changes must be done in `.less` files first, never just in the compiled `.css` files.
+- Adhere to the [CSS property order](http://markdotto.com/2011/11/29/css-property-order/).
+- Multiple-line approach (one property and value per line).
+- Always a space after a property's colon (e.g., `display: block;` and not `display:block;`).
+- End all lines with a semi-colon.
+- For multiple, comma-separated selectors, place each selector on its own line.
- Attribute selectors, like `input[type="text"]` should always wrap the attribute's value in double quotes, for consistency and safety (see this [blog post on unquoted attribute values](http://mathiasbynens.be/notes/unquoted-attribute-values) that can lead to XSS attacks).
- Attribute selectors should only be used where absolutely necessary (e.g., form controls) and should be avoided on custom components for performance and explicitness.
- Series of classes for a component should include a base class (e.g., `.component`) and use the base class as a prefix for modifier and sub-components (e.g., `.component-lg`).