aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorXhmikosR <[email protected]>2021-03-18 12:58:26 +0200
committerXhmikosR <[email protected]>2021-10-05 19:52:11 +0300
commit9f1579aa048eb6a7dee30f60e5c2357b049eff3a (patch)
tree109f14cb931e0922ca1bc1a9b75234b3422e62ed
parent57d80fcd3274ba1ff0a1580966e098fda80f74e7 (diff)
downloadbootstrap-9f1579aa048eb6a7dee30f60e5c2357b049eff3a.tar.xz
bootstrap-9f1579aa048eb6a7dee30f60e5c2357b049eff3a.zip
Enable `unicorn/prefer-prototype-methods` rule
-rw-r--r--.eslintrc.json1
-rw-r--r--js/src/util/index.js2
-rw-r--r--js/tests/visual/modal.html4
-rw-r--r--js/tests/visual/popover.html2
-rw-r--r--js/tests/visual/tooltip.html2
-rw-r--r--site/.eslintrc.json1
-rw-r--r--site/content/docs/5.1/components/alerts.md2
-rw-r--r--site/content/docs/5.1/components/collapse.md2
-rw-r--r--site/content/docs/5.1/components/dropdowns.md2
-rw-r--r--site/content/docs/5.1/components/list-group.md2
-rw-r--r--site/content/docs/5.1/components/navs-tabs.md2
-rw-r--r--site/content/docs/5.1/components/offcanvas.md2
-rw-r--r--site/content/docs/5.1/components/popovers.md2
-rw-r--r--site/content/docs/5.1/components/scrollspy.md2
-rw-r--r--site/content/docs/5.1/components/toasts.md2
-rw-r--r--site/content/docs/5.1/components/tooltips.md2
-rw-r--r--site/content/docs/5.1/examples/sidebars/sidebars.js2
17 files changed, 16 insertions, 18 deletions
diff --git a/.eslintrc.json b/.eslintrc.json
index 9bd404dfa..72b267691 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -60,7 +60,6 @@
"unicorn/prefer-array-flat": "off",
"unicorn/prefer-dom-node-dataset": "off",
"unicorn/prefer-module": "off",
- "unicorn/prefer-prototype-methods": "off",
"unicorn/prefer-query-selector": "off",
"unicorn/prefer-spread": "off",
"unicorn/prevent-abbreviations": "off"
diff --git a/js/src/util/index.js b/js/src/util/index.js
index 7e9e9b046..b99496301 100644
--- a/js/src/util/index.js
+++ b/js/src/util/index.js
@@ -15,7 +15,7 @@ const toType = obj => {
return `${obj}`
}
- return {}.toString.call(obj).match(/\s([a-z]+)/i)[1].toLowerCase()
+ return Object.prototype.toString.call(obj).match(/\s([a-z]+)/i)[1].toLowerCase()
}
/**
diff --git a/js/tests/visual/modal.html b/js/tests/visual/modal.html
index ac0a931af..eeb0aa567 100644
--- a/js/tests/visual/modal.html
+++ b/js/tests/visual/modal.html
@@ -220,12 +220,12 @@
}
}
- [].slice.call(document.querySelectorAll('[data-bs-toggle="popover"]'))
+ Array.prototype.slice.call(document.querySelectorAll('[data-bs-toggle="popover"]'))
.forEach(function (popover) {
new Popover(popover)
})
- var tooltipList = [].slice.call(document.querySelectorAll('[data-bs-toggle="tooltip"]'))
+ var tooltipList = Array.prototype.slice.call(document.querySelectorAll('[data-bs-toggle="tooltip"]'))
tooltipList.forEach(function (tooltip) {
new Tooltip(tooltip)
})
diff --git a/js/tests/visual/popover.html b/js/tests/visual/popover.html
index 986ac571e..f914f2b3b 100644
--- a/js/tests/visual/popover.html
+++ b/js/tests/visual/popover.html
@@ -40,7 +40,7 @@
<script src="../../dist/tooltip.js"></script>
<script src="../../dist/popover.js"></script>
<script>
- [].slice.call(document.querySelectorAll('[data-bs-toggle="popover"]'))
+ Array.prototype.slice.call(document.querySelectorAll('[data-bs-toggle="popover"]'))
.forEach(function (popover) {
new Popover(popover)
})
diff --git a/js/tests/visual/tooltip.html b/js/tests/visual/tooltip.html
index ab6040920..29248f9da 100644
--- a/js/tests/visual/tooltip.html
+++ b/js/tests/visual/tooltip.html
@@ -92,7 +92,7 @@
})
}
- [].slice.call(document.querySelectorAll('[data-bs-toggle="tooltip"]'))
+ Array.prototype.slice.call(document.querySelectorAll('[data-bs-toggle="tooltip"]'))
.forEach(function (tooltip) {
new Tooltip(tooltip)
})
diff --git a/site/.eslintrc.json b/site/.eslintrc.json
index 0660ebbaf..656465c39 100644
--- a/site/.eslintrc.json
+++ b/site/.eslintrc.json
@@ -54,7 +54,6 @@
"unicorn/prefer-array-flat": "off",
"unicorn/prefer-dom-node-dataset": "off",
"unicorn/prefer-module": "off",
- "unicorn/prefer-prototype-methods": "off",
"unicorn/prefer-query-selector": "off",
"unicorn/prevent-abbreviations": "off"
}
diff --git a/site/content/docs/5.1/components/alerts.md b/site/content/docs/5.1/components/alerts.md
index 6127279f5..d54f7b9ce 100644
--- a/site/content/docs/5.1/components/alerts.md
+++ b/site/content/docs/5.1/components/alerts.md
@@ -182,7 +182,7 @@ Initialize elements as alerts
```js
var alertList = document.querySelectorAll('.alert')
-var alerts = [].slice.call(alertList).map(function (element) {
+var alerts = Array.prototype.slice.call(alertList).map(function (element) {
return new bootstrap.Alert(element)
})
```
diff --git a/site/content/docs/5.1/components/collapse.md b/site/content/docs/5.1/components/collapse.md
index 1e1b58c29..75e4b20a3 100644
--- a/site/content/docs/5.1/components/collapse.md
+++ b/site/content/docs/5.1/components/collapse.md
@@ -133,7 +133,7 @@ To add accordion-like group management to a collapsible area, add the data attri
Enable manually with:
```js
-var collapseElementList = [].slice.call(document.querySelectorAll('.collapse'))
+var collapseElementList = Array.prototype.slice.call(document.querySelectorAll('.collapse'))
var collapseList = collapseElementList.map(function (collapseEl) {
return new bootstrap.Collapse(collapseEl)
})
diff --git a/site/content/docs/5.1/components/dropdowns.md b/site/content/docs/5.1/components/dropdowns.md
index 738940fc9..2750ce540 100644
--- a/site/content/docs/5.1/components/dropdowns.md
+++ b/site/content/docs/5.1/components/dropdowns.md
@@ -1003,7 +1003,7 @@ Add `data-bs-toggle="dropdown"` to a link or button to toggle a dropdown.
Call the dropdowns via JavaScript:
```js
-var dropdownElementList = [].slice.call(document.querySelectorAll('.dropdown-toggle'))
+var dropdownElementList = Array.prototype.slice.call(document.querySelectorAll('.dropdown-toggle'))
var dropdownList = dropdownElementList.map(function (dropdownToggleEl) {
return new bootstrap.Dropdown(dropdownToggleEl)
})
diff --git a/site/content/docs/5.1/components/list-group.md b/site/content/docs/5.1/components/list-group.md
index 71e45245c..af0237a07 100644
--- a/site/content/docs/5.1/components/list-group.md
+++ b/site/content/docs/5.1/components/list-group.md
@@ -397,7 +397,7 @@ You can activate a list group navigation without writing any JavaScript by simpl
Enable tabbable list item via JavaScript (each list item needs to be activated individually):
```js
-var triggerTabList = [].slice.call(document.querySelectorAll('#myTab a'))
+var triggerTabList = Array.prototype.slice.call(document.querySelectorAll('#myTab a'))
triggerTabList.forEach(function (triggerEl) {
var tabTrigger = new bootstrap.Tab(triggerEl)
diff --git a/site/content/docs/5.1/components/navs-tabs.md b/site/content/docs/5.1/components/navs-tabs.md
index 353d03d2d..68e744b1a 100644
--- a/site/content/docs/5.1/components/navs-tabs.md
+++ b/site/content/docs/5.1/components/navs-tabs.md
@@ -525,7 +525,7 @@ You can activate a tab or pill navigation without writing any JavaScript by simp
Enable tabbable tabs via JavaScript (each tab needs to be activated individually):
```js
-var triggerTabList = [].slice.call(document.querySelectorAll('#myTab button'))
+var triggerTabList = Array.prototype.slice.call(document.querySelectorAll('#myTab button'))
triggerTabList.forEach(function (triggerEl) {
var tabTrigger = new bootstrap.Tab(triggerEl)
diff --git a/site/content/docs/5.1/components/offcanvas.md b/site/content/docs/5.1/components/offcanvas.md
index 6be2cd64d..a5bf9426f 100644
--- a/site/content/docs/5.1/components/offcanvas.md
+++ b/site/content/docs/5.1/components/offcanvas.md
@@ -211,7 +211,7 @@ While both ways to dismiss an offcanvas are supported, keep in mind that dismiss
Enable manually with:
```js
-var offcanvasElementList = [].slice.call(document.querySelectorAll('.offcanvas'))
+var offcanvasElementList = Array.prototype.slice.call(document.querySelectorAll('.offcanvas'))
var offcanvasList = offcanvasElementList.map(function (offcanvasEl) {
return new bootstrap.Offcanvas(offcanvasEl)
})
diff --git a/site/content/docs/5.1/components/popovers.md b/site/content/docs/5.1/components/popovers.md
index 4511645ce..dc1c985d3 100644
--- a/site/content/docs/5.1/components/popovers.md
+++ b/site/content/docs/5.1/components/popovers.md
@@ -36,7 +36,7 @@ Keep reading to see how popovers work with some examples.
One way to initialize all popovers on a page would be to select them by their `data-bs-toggle` attribute:
```js
-var popoverTriggerList = [].slice.call(document.querySelectorAll('[data-bs-toggle="popover"]'))
+var popoverTriggerList = Array.prototype.slice.call(document.querySelectorAll('[data-bs-toggle="popover"]'))
var popoverList = popoverTriggerList.map(function (popoverTriggerEl) {
return new bootstrap.Popover(popoverTriggerEl)
})
diff --git a/site/content/docs/5.1/components/scrollspy.md b/site/content/docs/5.1/components/scrollspy.md
index bcd9fb78a..aeabb8185 100644
--- a/site/content/docs/5.1/components/scrollspy.md
+++ b/site/content/docs/5.1/components/scrollspy.md
@@ -278,7 +278,7 @@ Target elements that are not visible will be ignored and their corresponding nav
When using scrollspy in conjunction with adding or removing of elements from the DOM, you'll need to call the refresh method like so:
```js
-var dataSpyList = [].slice.call(document.querySelectorAll('[data-bs-spy="scroll"]'))
+var dataSpyList = Array.prototype.slice.call(document.querySelectorAll('[data-bs-spy="scroll"]'))
dataSpyList.forEach(function (dataSpyEl) {
bootstrap.ScrollSpy.getInstance(dataSpyEl)
.refresh()
diff --git a/site/content/docs/5.1/components/toasts.md b/site/content/docs/5.1/components/toasts.md
index 449f0275c..10093b6bc 100644
--- a/site/content/docs/5.1/components/toasts.md
+++ b/site/content/docs/5.1/components/toasts.md
@@ -335,7 +335,7 @@ While technically it's possible to add focusable/actionable controls (such as ad
Initialize toasts via JavaScript:
```js
-var toastElList = [].slice.call(document.querySelectorAll('.toast'))
+var toastElList = Array.prototype.slice.call(document.querySelectorAll('.toast'))
var toastList = toastElList.map(function (toastEl) {
return new bootstrap.Toast(toastEl, option)
})
diff --git a/site/content/docs/5.1/components/tooltips.md b/site/content/docs/5.1/components/tooltips.md
index 58da2076b..caa2a2d0c 100644
--- a/site/content/docs/5.1/components/tooltips.md
+++ b/site/content/docs/5.1/components/tooltips.md
@@ -35,7 +35,7 @@ Got all that? Great, let's see how they work with some examples.
One way to initialize all tooltips on a page would be to select them by their `data-bs-toggle` attribute:
```js
-var tooltipTriggerList = [].slice.call(document.querySelectorAll('[data-bs-toggle="tooltip"]'))
+var tooltipTriggerList = Array.prototype.slice.call(document.querySelectorAll('[data-bs-toggle="tooltip"]'))
var tooltipList = tooltipTriggerList.map(function (tooltipTriggerEl) {
return new bootstrap.Tooltip(tooltipTriggerEl)
})
diff --git a/site/content/docs/5.1/examples/sidebars/sidebars.js b/site/content/docs/5.1/examples/sidebars/sidebars.js
index 68384c163..d00bc0db1 100644
--- a/site/content/docs/5.1/examples/sidebars/sidebars.js
+++ b/site/content/docs/5.1/examples/sidebars/sidebars.js
@@ -1,7 +1,7 @@
/* global bootstrap: false */
(function () {
'use strict'
- var tooltipTriggerList = [].slice.call(document.querySelectorAll('[data-bs-toggle="tooltip"]'))
+ var tooltipTriggerList = Array.prototype.slice.call(document.querySelectorAll('[data-bs-toggle="tooltip"]'))
tooltipTriggerList.forEach(function (tooltipTriggerEl) {
new bootstrap.Tooltip(tooltipTriggerEl)
})