diff options
| author | Rohit Sharma <[email protected]> | 2020-11-30 15:42:40 +0530 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-11-30 12:12:40 +0200 |
| commit | c3689ac07335c1c76a9d16efc5363ed32ea6c1f3 (patch) | |
| tree | 2c43415e67708e80ac2b6a56a4c97f51694d5d7a | |
| parent | 03ed3e0b3b0ed3449e24bf9694d3868cbde19c80 (diff) | |
| download | bootstrap-c3689ac07335c1c76a9d16efc5363ed32ea6c1f3.tar.xz bootstrap-c3689ac07335c1c76a9d16efc5363ed32ea6c1f3.zip | |
Remove the `show` property from the modal plugin (#32279)
Drop the support of show property from the modal plugin.
When creating the new modal instance in v5, the `show` property does not work anymore, so instead of fixing the behavior just removing it permanently to keep the consistency between all the plugins. (All other plugins require the `show()` method to be called on the instances to be shown)
Co-authored-by: XhmikosR <[email protected]>
| -rw-r--r-- | js/src/modal.js | 8 | ||||
| -rw-r--r-- | site/content/docs/5.0/components/modal.md | 6 |
2 files changed, 2 insertions, 12 deletions
diff --git a/js/src/modal.js b/js/src/modal.js index db8345fac..fdca48213 100644 --- a/js/src/modal.js +++ b/js/src/modal.js @@ -37,15 +37,13 @@ const ESCAPE_KEY = 'Escape' const Default = { backdrop: true, keyboard: true, - focus: true, - show: true + focus: true } const DefaultType = { backdrop: '(boolean|string)', keyboard: 'boolean', - focus: 'boolean', - show: 'boolean' + focus: 'boolean' } const EVENT_HIDE = `hide${EVENT_KEY}` @@ -557,8 +555,6 @@ class Modal extends BaseComponent { } data[config](relatedTarget) - } else if (_config.show) { - data.show(relatedTarget) } }) } diff --git a/site/content/docs/5.0/components/modal.md b/site/content/docs/5.0/components/modal.md index 5bd116c8e..36dc3b548 100644 --- a/site/content/docs/5.0/components/modal.md +++ b/site/content/docs/5.0/components/modal.md @@ -877,12 +877,6 @@ Options can be passed via data attributes or JavaScript. For data attributes, ap <td><code>true</code></td> <td>Puts the focus on the modal when initialized.</td> </tr> - <tr> - <td><code>show</code></td> - <td>boolean</td> - <td><code>true</code></td> - <td>Shows the modal when initialized.</td> - </tr> </tbody> </table> |
