diff options
| author | GeoSot <[email protected]> | 2021-05-13 18:17:20 +0300 |
|---|---|---|
| committer | GitHub <[email protected]> | 2021-05-13 18:17:20 +0300 |
| commit | 6e1c9096f08ed21063fd6ba16aa998a3ac4149f9 (patch) | |
| tree | f6d0ecf0ebe37529a6b5eb3c262e1d423093b6cc /js/src/base-component.js | |
| parent | e376142d85e3ce0a5f5e49f3d676e419287a7292 (diff) | |
| download | bootstrap-6e1c9096f08ed21063fd6ba16aa998a3ac4149f9.tar.xz bootstrap-6e1c9096f08ed21063fd6ba16aa998a3ac4149f9.zip | |
Move get element functionality to a helper (#33327)
Looking around on js components I found out many checks, different expressed but with same purpose.
Some of them are trying to parse string to element, others, jQuery element to js simple nodeElement etc
With this Pr, I am trying to give a standard way to parse an element
So this pr:
* Creates `getElement` helper that tries to parse an argument to element or null
* Changes `isElement` to make explicit checks and return Boolean
* fixes tests deficiencies
Diffstat (limited to 'js/src/base-component.js')
| -rw-r--r-- | js/src/base-component.js | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/js/src/base-component.js b/js/src/base-component.js index eacc8420b..05b0adcd2 100644 --- a/js/src/base-component.js +++ b/js/src/base-component.js @@ -9,6 +9,7 @@ import Data from './dom/data' import { emulateTransitionEnd, execute, + getElement, getTransitionDurationFromElement } from './util/index' import EventHandler from './dom/event-handler' @@ -23,7 +24,7 @@ const VERSION = '5.0.0' class BaseComponent { constructor(element) { - element = typeof element === 'string' ? document.querySelector(element) : element + element = getElement(element) if (!element) { return |