aboutsummaryrefslogtreecommitdiff
path: root/js/src/button
diff options
context:
space:
mode:
authorJohann-S <[email protected]>2019-07-28 15:24:46 +0200
committerJohann-S <[email protected]>2019-07-29 11:34:12 +0200
commitdcba52677556bedb04a07825c2023e0beeea6f1e (patch)
treeddf5bbf334408536c609f2ded245e119c1a9de17 /js/src/button
parent144220f0c5777e07fb1832324d52a590bec363e2 (diff)
downloadbootstrap-dcba52677556bedb04a07825c2023e0beeea6f1e.tar.xz
bootstrap-dcba52677556bedb04a07825c2023e0beeea6f1e.zip
remove underscore for static methods
Diffstat (limited to 'js/src/button')
-rw-r--r--js/src/button/button.js8
-rw-r--r--js/src/button/button.spec.js16
2 files changed, 12 insertions, 12 deletions
diff --git a/js/src/button/button.js b/js/src/button/button.js
index 2e6033b64..b7e20461d 100644
--- a/js/src/button/button.js
+++ b/js/src/button/button.js
@@ -122,7 +122,7 @@ class Button {
// Static
- static _jQueryInterface(config) {
+ static jQueryInterface(config) {
return this.each(function () {
let data = Data.getData(this, DATA_KEY)
@@ -136,7 +136,7 @@ class Button {
})
}
- static _getInstance(element) {
+ static getInstance(element) {
return Data.getData(element, DATA_KEY)
}
}
@@ -188,12 +188,12 @@ EventHandler.on(document, Event.BLUR_DATA_API, Selector.DATA_TOGGLE_CARROT, even
/* istanbul ignore if */
if (typeof $ !== 'undefined') {
const JQUERY_NO_CONFLICT = $.fn[NAME]
- $.fn[NAME] = Button._jQueryInterface
+ $.fn[NAME] = Button.jQueryInterface
$.fn[NAME].Constructor = Button
$.fn[NAME].noConflict = () => {
$.fn[NAME] = JQUERY_NO_CONFLICT
- return Button._jQueryInterface
+ return Button.jQueryInterface
}
}
diff --git a/js/src/button/button.spec.js b/js/src/button/button.spec.js
index 711408896..622881185 100644
--- a/js/src/button/button.spec.js
+++ b/js/src/button/button.spec.js
@@ -236,15 +236,15 @@ describe('Button', () => {
const btnEl = fixtureEl.querySelector('.btn')
const button = new Button(btnEl)
- expect(Button._getInstance(btnEl)).toBeDefined()
+ expect(Button.getInstance(btnEl)).toBeDefined()
button.dispose()
- expect(Button._getInstance(btnEl)).toBeNull()
+ expect(Button.getInstance(btnEl)).toBeNull()
})
})
- describe('_jQueryInterface', () => {
+ describe('jQueryInterface', () => {
it('should handle config passed and toggle existing button', () => {
fixtureEl.innerHTML = '<button class="btn" data-toggle="button"></button>'
@@ -253,7 +253,7 @@ describe('Button', () => {
spyOn(button, 'toggle')
- jQueryMock.fn.button = Button._jQueryInterface
+ jQueryMock.fn.button = Button.jQueryInterface
jQueryMock.elements = [btnEl]
jQueryMock.fn.button.call(jQueryMock, 'toggle')
@@ -266,12 +266,12 @@ describe('Button', () => {
const btnEl = fixtureEl.querySelector('.btn')
- jQueryMock.fn.button = Button._jQueryInterface
+ jQueryMock.fn.button = Button.jQueryInterface
jQueryMock.elements = [btnEl]
jQueryMock.fn.button.call(jQueryMock, 'toggle')
- expect(Button._getInstance(btnEl)).toBeDefined()
+ expect(Button.getInstance(btnEl)).toBeDefined()
expect(btnEl.classList.contains('active')).toEqual(true)
})
@@ -280,12 +280,12 @@ describe('Button', () => {
const btnEl = fixtureEl.querySelector('.btn')
- jQueryMock.fn.button = Button._jQueryInterface
+ jQueryMock.fn.button = Button.jQueryInterface
jQueryMock.elements = [btnEl]
jQueryMock.fn.button.call(jQueryMock)
- expect(Button._getInstance(btnEl)).toBeDefined()
+ expect(Button.getInstance(btnEl)).toBeDefined()
expect(btnEl.classList.contains('active')).toEqual(false)
})
})