aboutsummaryrefslogtreecommitdiff
path: root/js/src/offcanvas.js
diff options
context:
space:
mode:
authorGeoSot <[email protected]>2021-07-28 17:39:32 +0300
committerGitHub <[email protected]>2021-07-28 17:39:32 +0300
commit4bfd8a2cbcb10610b4078cefa45756b4a96301a0 (patch)
tree2358a92299ff8fa105623932caacddbf8cd83a41 /js/src/offcanvas.js
parent047145e8086793e7c39747e70f5d74a8860c2e50 (diff)
downloadbootstrap-4bfd8a2cbcb10610b4078cefa45756b4a96301a0.tar.xz
bootstrap-4bfd8a2cbcb10610b4078cefa45756b4a96301a0.zip
Use a streamlined way to trigger component dismiss (#34170)
* use a streamlined way to trigger component dismiss * add documentation Co-authored-by: XhmikosR <[email protected]>
Diffstat (limited to 'js/src/offcanvas.js')
-rw-r--r--js/src/offcanvas.js6
1 files changed, 2 insertions, 4 deletions
diff --git a/js/src/offcanvas.js b/js/src/offcanvas.js
index 6c563cb4f..7725b0188 100644
--- a/js/src/offcanvas.js
+++ b/js/src/offcanvas.js
@@ -19,6 +19,7 @@ import SelectorEngine from './dom/selector-engine'
import Manipulator from './dom/manipulator'
import Backdrop from './util/backdrop'
import FocusTrap from './util/focustrap'
+import { enableDismissTrigger } from './util/component-functions'
/**
* ------------------------------------------------------------------------
@@ -54,10 +55,8 @@ const EVENT_SHOWN = `shown${EVENT_KEY}`
const EVENT_HIDE = `hide${EVENT_KEY}`
const EVENT_HIDDEN = `hidden${EVENT_KEY}`
const EVENT_CLICK_DATA_API = `click${EVENT_KEY}${DATA_API_KEY}`
-const EVENT_CLICK_DISMISS = `click.dismiss${EVENT_KEY}`
const EVENT_KEYDOWN_DISMISS = `keydown.dismiss${EVENT_KEY}`
-const SELECTOR_DATA_DISMISS = '[data-bs-dismiss="offcanvas"]'
const SELECTOR_DATA_TOGGLE = '[data-bs-toggle="offcanvas"]'
/**
@@ -197,8 +196,6 @@ class Offcanvas extends BaseComponent {
}
_addEventListeners() {
- EventHandler.on(this._element, EVENT_CLICK_DISMISS, SELECTOR_DATA_DISMISS, () => this.hide())
-
EventHandler.on(this._element, EVENT_KEYDOWN_DISMISS, event => {
if (this._config.keyboard && event.key === ESCAPE_KEY) {
this.hide()
@@ -263,6 +260,7 @@ EventHandler.on(window, EVENT_LOAD_DATA_API, () =>
SelectorEngine.find(OPEN_SELECTOR).forEach(el => Offcanvas.getOrCreateInstance(el).show())
)
+enableDismissTrigger(Offcanvas)
/**
* ------------------------------------------------------------------------
* jQuery